From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 501CFA0C41 for ; Thu, 30 Sep 2021 08:47:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CD72410EA; Thu, 30 Sep 2021 08:47:52 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id AD034410EA; Thu, 30 Sep 2021 08:47:49 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10122"; a="205262891" X-IronPort-AV: E=Sophos;i="5.85,335,1624345200"; d="scan'208";a="205262891" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2021 23:47:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,335,1624345200"; d="scan'208";a="707708688" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga006.fm.intel.com with ESMTP; 29 Sep 2021 23:47:48 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 29 Sep 2021 23:47:47 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 29 Sep 2021 23:47:47 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 29 Sep 2021 23:47:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J7JANAS7H8ewdyUa+VyBAZ1tQYza5b4SKfyOl7iM+SFm1U2MGSb5rIkESW9rJmNd97gdcHaJGTcgjcqUOMFqWkoEcKSULKrdefhr8vEvFh27RqSAbtGXipIFwb/ESblgiYrOG9hEyipZ4xEszyTu9dP/PQeQKvobx0lie5xlYwinjKdsBE4fZW7v0rcQ21SM4lkx6E5v4X5QM7c+WbJGXE0DqOu4EJ7c6JFhHfSbzWAojbfVb9pxOX816xVxFxnviR+05WuWsuMVAr4W7rOyLUiBNcKdID2qg2cwFqRu+RoKSVYWbxmNdHALG5q91YMh2aeFAdsGfc/nuVy1Z3oy7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jCPieasclgI0D2ua9NxUI+p7snTYsNpQWonNlfGK1nM=; b=YgK6PYyW3BLjHYljdeLJO5Q2KxCeEPTaaTrwgAl5Yw72AU0p/Z5G3n6N//URx7iD15NmsZsQ9a8bZ7RLk7LPhK55g8DQsTdKiBLs0rGaoYIsAp3aZNs79Yv2UEyDK4nto56F/6hs5XB4cMfTH7Ws9y1eggG001S9d7Mk/fsHj4LcTPYx4AU6+F0q4sjV1aLbCAnttW8GJieA77Nw6M5UQP28CXY3n4J6wmycro/6i67IEQ9h3mKMumtgCgX12Y5Zrq82KnVCyrFnY0Jic39YTAHab9lFeEoij8lml09wZpYCFgx8L1Y2k8W8dYinDdtCM6CnxpaedE4P9Tvv2fREBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jCPieasclgI0D2ua9NxUI+p7snTYsNpQWonNlfGK1nM=; b=gRS6hLD+jSWy3/Rdn+dU2BznBIvuO2rYQ81+JXQLOt2BPXZywnORr/8OZ1P3kedjRSbuTA6hsNvyqn2dTWzo3h0ZusKcnZmDyWeomQowd4U9ADmcErBzqyOChXmhZKbwZFp6iT2y/9+3IAl9U0WxAWKe9bpJjuddBlPKRWoDJu4= Received: from DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) by DM8PR11MB5624.namprd11.prod.outlook.com (2603:10b6:8:35::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Thu, 30 Sep 2021 06:47:45 +0000 Received: from DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::904:ace8:b3b:c1a2]) by DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::904:ace8:b3b:c1a2%4]) with mapi id 15.20.4566.015; Thu, 30 Sep 2021 06:47:45 +0000 From: "Peng, ZhihongX" To: "olivier.matz@6wind.com" , "stephen@networkplumber.org" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2 1/2] lib/cmdline: release cl when cmdline exit Thread-Index: AQHXq2sjzy64eWfDm0ePWYX+i8T5Jqu8NxUw Date: Thu, 30 Sep 2021 06:47:45 +0000 Message-ID: References: <20210831022844.18057-1-zhihongx.peng@intel.com> <20210917021502.502560-1-zhihongx.peng@intel.com> In-Reply-To: <20210917021502.502560-1-zhihongx.peng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8500e02f-b06d-41af-b5f4-08d983de359d x-ms-traffictypediagnostic: DM8PR11MB5624: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2089; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cQEsQoPnYeYLrW/xAvknPwu52gSLWRcPzrcnFYTlQdCTv5n2mOAIRRbb1ALCiqB1oSNqfcwGMLYMj8ygoDbS2LCRmUtTaGibAzeF2UUC1+v3tGAtPDsfGy/cGUQ2UrN2TjlFh+fwTGtQ2omski8qwoHbiHmKDXwv4w+muE1Moh3PPdtFm/M4X45ZZ/maJqo3Z/G+XE/uv8CM4HkVuIUqWU8fmUdEeoayDheBy0ADxPdgBTEzZDIhZJ/chExumD25Ou/mL4+4XaRgYIDQjFCeQlY7DwFJhXUWBVCPiWfx8dKPSUvifa4jqFf4TGdGzKlpwXo3uXrl0IFS/5xJQ684Z1Uj19d9F/GoRy3gJOk5NQhjo3cngRIXJCr58TU1593eNAadbazZ4JwaYgfQHMDAONV+Gz5cQ7GVS2IKLcAqRyvHNGT9r7qrTRCt1Fp47jntclrKr61j+i6BK6U+nRW1/l3p+5Yi6xVmzqDoFjXAulUWYspOcNIMFUiD7w3PHKoDOp9UXsT4fkOylUQV3yfALDKmXQQzCZvRxdGyF/lNmcOqPbhF5hlcbzUviCSrJ42YZzFAHHHWngwoA+VMkx2Su2WgAxbLk3Z/w5GiBxv+wfJuq86hXjNhdzM/cOEu8pN7RNtOYRwsEln0EwnTfzT4VMdhtKWkrWdxiYdSh5z/Iy7lI4m44GbHd/5d/L25b3YbfbgzBc4IMGvL8dkmcKaFeA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5591.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(52536014)(122000001)(4744005)(83380400001)(8676002)(8936002)(2906002)(86362001)(110136005)(66446008)(64756008)(66476007)(66556008)(38100700002)(76116006)(38070700005)(6506007)(5660300002)(186003)(4326008)(54906003)(66946007)(53546011)(508600001)(55016002)(316002)(33656002)(7696005)(9686003)(71200400001)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o4iUAKpL0N/YzKbhnwZVBXPl/2Z68IpYdW7rjR/2jEXFkRMJoPFUpN1DgU6W?= =?us-ascii?Q?AuejRaN3tegSQ/R3UE+fSNTeEl2Aj0xge/6KPfThpcVXHR89TjHBnzeR9fWY?= =?us-ascii?Q?RMC0ptGxzqSgrnEsQUdcMBYe0D0SKMMdSFRZ9tSdSVGTOl/C46Xu437hiIdk?= =?us-ascii?Q?MECdjZ+2XwAYU9qoa7Oc+Z+aN1/iMipU//S/TD0rB10g6JYR2ZxAg11ynPm0?= =?us-ascii?Q?pPR2P0xxGMqBciCrO5Sg5KgJZd5uE++z/Zq1LPzA4NQRkXAlxw15wGpynlTN?= =?us-ascii?Q?BfBDfb/9WYTXE9ARzhAbv9OctsAfQyUBDm+lBQWP+DPaAoKnJSI6H3Blem3F?= =?us-ascii?Q?e9MgSH0XXs8qiUAAWhseBsRgAVbUSMW2MO2XjkSxNxiyt3cL45wZZ7MUyKH3?= =?us-ascii?Q?o2+xpcVVG/SWdD4SUWG98SvIKuw25mb0T7z+hlsdZDmmI6qBrg8/O0n9bFhO?= =?us-ascii?Q?NZViS2mN/vl0qHzK4L5lsugqQp212SK+R4mLr0RZIDExAx5i8D4gpd8q7IFd?= =?us-ascii?Q?IW2DCY898Bui+leGeWpF1b/5pHlDVw4bQjvgM8hXNKGLqfEewaZpgrSjmrHR?= =?us-ascii?Q?sqh9icGSL4NpV6hAU1B9utZRPUqJ8D1kOnj0JxmQYX228ng3gUWebb5vEdln?= =?us-ascii?Q?lvjsPUI23AAwYYXl9yWpewEAMnwtDFx0IFBwmv1mh3CLeUFcOqNEJPBp3hTz?= =?us-ascii?Q?oBQMbyXHQ/YGkOrf2RhfF8GAlNejI3X+s8omy2+q5XY4w9rMzt92meuFcS+e?= =?us-ascii?Q?J9Q3qNFJeGIGk+ulk5+7UuOiQOVZ+9srwJgUg/1HVgdNCD72aPXb8v/cudwM?= =?us-ascii?Q?djagtJRcfDsTfBkywrCKyDmbWYU630g734Q88jWVh1+kPSCb0UVyfjouJral?= =?us-ascii?Q?K3hIsMn4DjG9oQi9kwSQDpDWTWQejp7sidFBAXTyWJncLzvorjTEYXrjjXhN?= =?us-ascii?Q?UBzaipdga/uCzEWKX3jMEvk3q6zqbFGtI7s0AtnQ262X5yDO1BhprpDzV4fB?= =?us-ascii?Q?abZyVHq4o5TkJ/VmF26HygPaEEKEBwy2YhgFJvRhF7KYAtM6IaJjvQ0W6Al5?= =?us-ascii?Q?pHZu75Of2UDTP9mUSdmykcB6fQd0DY4pmrC7A6rfXIDmiJnlTOH+2eGDQOKR?= =?us-ascii?Q?EQNBVawz9nAzyGdhszjp+UTiZss4nGaR1IP3/veqTHjwRBq1Fg1tP4bzmb53?= =?us-ascii?Q?2NO52++oPgrVPaM0MAsVVuHbjx35poU9qUrLLhXgAPctAi6LJeI7EWTANqrw?= =?us-ascii?Q?uF5aHcjliFK5Sqpo9pAwRuV4Jeferi0aTtUFowvRoaqcyQK6gLC6d11F8XIg?= =?us-ascii?Q?aGzDs6bPq4nczDLYMbXi8kU5?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8500e02f-b06d-41af-b5f4-08d983de359d X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2021 06:47:45.4395 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NCwTD+rRptEVvmK1tSduqvbn0BzxDT0J4RMtK0QJzxM9Pw5k1vzuUa/VG3dlQN9T29pB3JL2o8KqnSXkiE5MUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5624 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v2 1/2] lib/cmdline: release cl when cmdline exit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Peng, ZhihongX > Sent: Friday, September 17, 2021 10:15 AM > To: olivier.matz@6wind.com; stephen@networkplumber.org > Cc: dev@dpdk.org; Peng, ZhihongX ; > stable@dpdk.org > Subject: [PATCH v2 1/2] lib/cmdline: release cl when cmdline exit >=20 > From: Zhihong Peng >=20 > Malloc cl in the cmdline_stdin_new function, so release in the > cmdline_stdin_exit function is logical, so that cl will not be released a= lone. >=20 > Fixes: af75078fece3 (first public release) > Cc: stable@dpdk.org >=20 > Signed-off-by: Zhihong Peng > --- > lib/cmdline/cmdline_socket.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/lib/cmdline/cmdline_socket.c b/lib/cmdline/cmdline_socket.c > index 998e8ade25..ebd5343754 100644 > --- a/lib/cmdline/cmdline_socket.c > +++ b/lib/cmdline/cmdline_socket.c > @@ -53,4 +53,5 @@ cmdline_stdin_exit(struct cmdline *cl) > return; >=20 > terminal_restore(cl); > + cmdline_free(cl); > } > -- > 2.25.1 Tested-by: Zhihong Peng