From: "Pai G, Sunil" <sunil.pai.g@intel.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>,
"Hu, Jiayu" <jiayu.hu@intel.com>,
"Wang, YuanX" <yuanx.wang@intel.com>,
"Ding, Xuan" <xuan.ding@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Patrick Fu <patrick.fu@intel.com>
Subject: RE: [RFC PATCH v2 4/9] vhost: fix async access
Date: Mon, 4 Apr 2022 06:57:10 +0000 [thread overview]
Message-ID: <DM8PR11MB5605F0BC32AA1AB9E2E3C874BDE59@DM8PR11MB5605.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220330134956.18927-5-david.marchand@redhat.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, March 30, 2022 7:20 PM
> To: dev@dpdk.org
> Cc: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>; Hu,
> Jiayu <jiayu.hu@intel.com>; Wang, YuanX <yuanx.wang@intel.com>; Ding, Xuan
> <xuan.ding@intel.com>; stable@dpdk.org; Patrick Fu <patrick.fu@intel.com>
> Subject: [RFC PATCH v2 4/9] vhost: fix async access
>
> vq->async accesses must be protected with vq->access_lock.
>
> Fixes: eb666d24085f ("vhost: fix async unregister deadlock")
> Fixes: 0c0935c5f794 ("vhost: allow to check in-flight packets for async
> vhost")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/vhost/vhost.c | 25 ++++++++++---------------
> 1 file changed, 10 insertions(+), 15 deletions(-)
Thanks for the fix, David.
Tested the changes for rte_vhost_async_get_inflight, works as expected.
Although I couldn't test, the changes for rte_vhost_async_channel_unregister looks good to me .
Based on that,
Acked-by: Sunil Pai G <sunil.pai.g@intel.com>
next prev parent reply other threads:[~2022-04-04 6:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220328121758.26632-1-david.marchand@redhat.com>
2022-03-28 12:17 ` [RFC PATCH 1/5] vhost: fix missing virtqueue lock protection David Marchand
2022-03-28 12:17 ` [RFC PATCH 3/5] vhost: fix async access David Marchand
[not found] ` <20220330134956.18927-1-david.marchand@redhat.com>
2022-03-30 13:49 ` [RFC PATCH v2 1/9] vhost: fix missing virtqueue lock protection David Marchand
2022-03-30 13:49 ` [RFC PATCH v2 4/9] vhost: fix async access David Marchand
2022-03-31 8:00 ` Maxime Coquelin
2022-03-31 10:23 ` Hu, Jiayu
2022-04-04 6:57 ` Pai G, Sunil [this message]
[not found] ` <20220411110013.18624-1-david.marchand@redhat.com>
2022-04-11 11:00 ` [RFC PATCH v3 3/8] " David Marchand
2022-04-21 19:21 ` Maxime Coquelin
2022-05-17 13:24 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB5605F0BC32AA1AB9E2E3C874BDE59@DM8PR11MB5605.namprd11.prod.outlook.com \
--to=sunil.pai.g@intel.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=patrick.fu@intel.com \
--cc=stable@dpdk.org \
--cc=xuan.ding@intel.com \
--cc=yuanx.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).