please help backporting some patches to stable release 21.11.9

please help backporting some patches to stable release 21.11.9

[Kevin Traynor]

Hi commit authors (and maintainers),

Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh
I didn't apply following commits from DPDK main to 21.11
stable branch, as conflicts or build errors occur.

Can authors check your patches in the following list and either:
    - Backport your patches to the 21.11 branch, or
    - Indicate that the patch should not be backported

Please do either of the above by 12/02/24.

Note: 21.11.9 is the final planned release for the 21.11 LTS series, so I would
urge extra caution about any changes which may introduce regressions. I would
expect that most users will have moved or plan to move to a newer maintained
LTS release at this point.

I have sent the full list below, but I suggest authors to only rebase any
important fixes and ensure that they test there are no regressions.

You can find the a temporary work-in-progress branch of the coming 21.11.9
release at:
    https://github.com/kevintraynor/dpdk-stable
It is recommended to backport on top of that to minimize further conflicts or
misunderstandings.

Some notes on stable backports:

A backport should contain a reference to the DPDK main branch commit
in it's commit message in the following fashion:
    [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]

For example:
    https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb

When sending the backported patch, please indicate the target branch in the
subject line, as we have multiple branches, for example:
    [PATCH 21.11] foo/bar: fix baz

With git format-patch, this can be achieved by appending the parameter:
    --subject-prefix='PATCH 21.11'

Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".

FYI, branch 21.11 is located at tree:
   https://git.dpdk.org/dpdk-stable

Thanks.

Kevin

---
c5b531d6ee  Anoob Joseph     app/crypto-perf: fix session freeing
04dac73643  Ganapati Kundapura eventdev/crypto: fix enqueue count
4b04134cbb  Ganapati Kundapura eventdev/crypto: fix failed events
da73a2a0d1  Ganapati Kundapura eventdev/crypto: fix offset used while flushing events
f442c04001  Ganapati Kundapura eventdev/crypto: fix overflow in circular buffer
5a0f64d84b  Hanumanth Pothula net/cnxk: fix configuring large Rx/Tx queues
59ceaa72d5  Harman Kalra     common/cnxk: fix part number for CN10K
31a28a99fd  Jiawen Wu        net/ngbe: add spinlock protection on YT PHY
5781638519  Nithin Dabilpuram common/cnxk: fix RQ mask config for CN10KB chip
3fe71706ab  Pavan Nikhilesh  event/cnxk: fix stale data in workslot
927cb43fe9  Pavan Nikhilesh  examples/l3fwd: fix port group mask with AltiVec
0f044b6681  Steve Yang       net/iavf: fix refine protocol header
0b241667cc  Steve Yang       net/iavf: fix tainted scalar
b125c0e721  Steve Yang       net/iavf: fix tainted scalar
cedb44dc87  Suanming Mou     common/mlx5: improve AES-XTS tweak capability check
7be74edb90  Honnappa Nagarahalli common/mlx5: use just sufficient barrier for Arm
7bdf7a13ae  Michael Baum     app/testpmd: fix encap/decap size calculation
6df1bc6b3b  Ashwin Sekhar T K mempool/cnxk: avoid hang when counting batch allocs
772e30281a  Rahul Bhansali   common/cnxk: fix CPT backpressure disable on LBK
b37fe88a2c  Srujana Challa   event/cnxk: fix LMTST write for single event mode
92a16af450  Kaiwen Deng      net/iavf: fix virtchnl command called in interrupt
12011b11a3  Jiawen Wu        net/txgbe: adapt to MNG veto bit setting
21f702d556  Jiawen Wu        net/ngbe: fix link status in no LSC mode
659cfce01e  Jiawen Wu        net/ngbe: remove redundant codes
9749dffe23  Kaiwen Deng      net/ice: fix MAC type of E822 and E823
1c7a4d37e7  Harman Kalra     common/cnxk: fix mailbox timeout due to deadlock
5e170dd8b6  Jiawen Wu        net/txgbe: fix blocking system events
37ca457d3f  Bing Zhao        common/mlx5: fix obtaining IB device in LAG mode
9a518054b5  Mohammad Iqbal Ahmad examples/l3fwd: fix duplicate expression for default nexthop
61b52e7edb  Stephen Hemminger app/test: fix reference to master in bonding test
63bf81a617  Anatoly Burakov  test: fix named test macro
694e8e643d  Pavan Nikhilesh  event/cnxk: fix CASP usage for clang
a6f639e079  Sunil Kumar Kori common/cnxk: fix BP threshold calculation
95a955e3e0  Amit Prakash Shukla dma/cnxk: fix device reconfigure
3dd3115078  Amit Prakash Shukla dma/cnxk: fix chunk buffer failure return code
ba39a261a7  Vamsi Attunuru   dma/cnxk: fix completion ring tail wrap
b3ddd649ad  Ashwin Sekhar T K mempool/cnxk: fix alloc from non-EAL threads
56fa6f92e9  Kiran Kumar K    common/cnxk: fix RSS key configuration
7752f14026  Rahul Bhansali   net/cnxk: fix Rx flush on CN10k
5d8c1f6253  Nithin Dabilpuram common/cnxk: check error in MAC address set
a74c5001e9  Jiawen Wu        net/ngbe: add proper memory barriers in Rx
2ece3b7186  Bing Zhao        net/mlx5: fix flow workspace double free in Windows
9d91c3047d  Gowrishankar Muthukrishnan crypto/openssl: fix memory leaks in asym operations
166591931b  Stephen Hemminger pcapng: modify timestamp calculation
547f294357  Kumara Parameshwaran gro: fix reordering of packets
063cddfc74  Honnappa Nagarahalli rcu: use atomic operation on acked token
df33fb53e4  Honnappa Nagarahalli rcu: fix acked token in debug log
02a2accb5f  Mário Kuka       net/bonding: fix flow count query
44a8635459  Hanumanth Pothula net/thunderx: fix DMAC control register update
48adbc80ba  Michael Baum     net/mlx5: remove GENEVE options length limitation
461c287ab5  Kumara Parameshwaran app/testpmd: fix GRO packets flush on timeout
3232c95d2c  Nithin Dabilpuram net/cnxk: fix indirect mbuf handling in Tx
26a6bda9df  Rahul Bhansali   net/cnxk: add cookies check for multi-segment offload
8ed5ca4dda  Rahul Bhansali   net/cnxk: fix mbuf fields in multi-segment Tx
48054ca384  Harman Kalra     common/cnxk: fix link config for SDP
87e4384d26  Bing Zhao        net/mlx5: fix condition of LACP miss flow
1cfb78d2c4  Shun Hao         net/mlx5: fix meter policy priority
a78a1ed8ba  Gaoxiang Liu     net/bonding: fix failover time of LACP with mode 4
ecf408d2aa  Bing Zhao        app/testpmd: fix indirect action flush
b9a87346b0  Chengwen Feng    ethdev: fix strict aliasing in link up
e82b0fe097  Venkat Kumar Ande net/axgbe: disable RRC for yellow carp devices
ad12d08f05  Ganapati Kundapura eventdev/crypto: fix opaque field handling
4edbcc7b53  Luca Boccassi    bpf: disable on 32-bit x86
b1d7112602  Jack Bond-Preston crypto/openssl: make per-QP cipher context clones
17d5bc6135  Jack Bond-Preston crypto/openssl: make per-QP auth context clones
ee0fa7552a  Rohit Raj        net/dpaa: forbid MTU configuration for shared interface
e2072ba1b0  Fabio Pricoco    net/ice/base: fix resource leak
df44ba7a3c  Tomasz Wakula    net/ice/base: fix preparing PHY for timesync command
79be49dd2d  Jiawen Wu        net/ngbe: add special config for YT8531SH-CA PHY
2a3f42942a  Chengwen Feng    dma/hisilicon: remove support for HIP09 platform
b23c5bd71a  Sivaprasad Tummala examples: fix queue ID restriction
4b97893816  Sivaprasad Tummala examples: fix lcore ID restriction
548de9091c  Sivaprasad Tummala examples: fix port ID restriction
abdabad636  Ciara Loftus     net/af_xdp: remove unused local statistic
4c2f14bc6d  Sunil Kumar Kori net/cnxk: fix xstats reset
4ad17a1c8f  Akhil Goyal      test/crypto: fix enqueue/dequeue callback case
046341575b  Gagandeep Singh  crypto/dpaa_sec: fix IPsec descriptor
97039941b2  Frank Du         net/af_xdp: parse UMEM map info from mempool
4edbcc7b53  Luca Boccassi    bpf: disable on 32-bit x86
6db358536f  Oleksandr Nahnybida pcapng: fix handling of chained mbufs
5c0f970c0d  Stephen Hemminger app/dumpcap: fix handling of jumbo frames
2d4505dc6d  Sunil Kumar Kori common/cnxk: fix MAC address change with active VF
6c3de40af8  Nithin Dabilpuram common/cnxk: fix inline CTX write
6f96937dad  Robin Jarry      ethdev: fix race on ports in telemetry endpoints
b34fe66ea8  Bruce Richardson net/iavf: delay VF reset command
b04b06f4cb  Viacheslav Ovsiienko net/mlx5: fix flex item header length field translation
27918f0d53  Tim Martin       net/mlx5: fix real time counter reading from PCI BAR
ebab0e8b22  Konstantin Ananyev examples/l3fwd: fix read beyond boundaries
0c5709824b  Nicolas Chautru  baseband/acc: fix ring memory allocation
251fdc592d  Brian Dooley     test/crypto: fix synchronous API calls
78dcdb821c  Shahaji Bhosle   net/bnxt/tf_core: fix WC TCAM multi-slice delete
8782e4de3e  Kishore Padmanabha net/bnxt/tf_ulp: fix parent child DB counters
e6bf3256b9  Stephen Hemminger net/dpaa2: remove unnecessary check for null before free
3cddeba0ca  Alexander Kozyrev common/mlx5: fix error CQE handling for 128 bytes CQE
3c9a82fa6e  Bing Zhao        net/mlx5: fix Rx queue control management
a7ae9ba1f8  Alexander Kozyrev net/mlx5: fix miniCQEs number calculation
ffe827f38e  Andre Muezerie   rcu: fix implicit conversion in bit shift
f8f294c66b  Bing Zhao        net/mlx5: fix shared Rx queue control release
916aa13f4a  Jiawen Wu        net/txgbe: fix a mass of interrupts
0151b80786  Stephen Hemminger test/security: fix IPv6 extension loop
ebab0e8b22  Konstantin Ananyev examples/l3fwd: fix read beyond boundaries

Re: please help backporting some patches to stable release 21.11.9

[Robin Jarry]

Hi Kevin,

Kevin Traynor, Nov 27, 2024 at 18:33:
> 6f96937dad  Robin Jarry      ethdev: fix race on ports in telemetry endpoints

I don't think this can be backported in this release. It depends on 
5fa337858df6 ("ethdev: protect shared memory accesses under one lock") 
which is only present since v23.11

Re: please help backporting some patches to stable release 21.11.9

[Kevin Traynor]

On 28/11/2024 10:24, Robin Jarry wrote:
> Hi Kevin,
> 
> Kevin Traynor, Nov 27, 2024 at 18:33:
>> 6f96937dad  Robin Jarry      ethdev: fix race on ports in telemetry endpoints
> 
> I don't think this can be backported in this release. It depends on 
> 5fa337858df6 ("ethdev: protect shared memory accesses under one lock") 
> which is only present since v23.11
> 

ok, thanks Robin. Will remove it from list.

Kevin.

RE: please help backporting some patches to stable release 21.11.9

[Richardson, Bruce]

For commit b34fe66ea893 ("net/iavf: delay VF reset command"), I will do a backport for 21.11. 

This will actually be a combination of two commits:
	0f9ec0cbd2a9 ("net/iavf: fix VF reset when using DCF")
	b34fe66ea893 ("net/iavf: delay VF reset command")

Since the referenced commit below is actually a fix for the earlier fix - which was never actually backported to 21.11. Patch will arrive shortly, just build-testing it.

/Bruce

> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Wednesday, November 27, 2024 5:34 PM
> To: dpdk stable <stable@dpdk.org>
> Cc: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; Ajit Khaparde
> <ajit.khaparde@broadcom.com>; Akhil Goyal <gakhil@marvell.com>;
> Alexander Kozyrev <akozyrev@nvidia.com>; Amit Prakash Shukla
> <amitprakashs@marvell.com>; Burakov, Anatoly
> <anatoly.burakov@intel.com>; Andre Muezerie
> <andremue@linux.microsoft.com>; Anoob Joseph <anoobj@marvell.com>;
> Ashwin Sekhar T K <asekhar@marvell.com>; Bing Zhao <bingz@nvidia.com>;
> Dooley, Brian <brian.dooley@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Chengwen Feng
> <fengchengwen@huawei.com>; Loftus, Ciara <ciara.loftus@intel.com>; Ciara
> Power <ciara.power@intel.com>; Walsh, Conor <conor.walsh@intel.com>;
> Dariusz Sosnowski <dsosnowski@nvidia.com>; Marchand, David
> <david.marchand@redhat.com>; Dengdui Huang
> <huangdengdui@huawei.com>; Pricoco, Fabio <fabio.pricoco@intel.com>;
> Ferruh Yigit <ferruh.yigit@amd.com>; Du, Frank <frank.du@intel.com>;
> Gagandeep Singh <g.singh@nxp.com>; Kundapura, Ganapati
> <ganapati.kundapura@intel.com>; Gaoxiang Liu <liugaoxiang@huawei.com>;
> Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>; Hanumanth
> Pothula <hpothula@marvell.com>; Harman Kalra <hkalra@marvell.com>;
> Hemant Agrawal <hemant.agrawal@nxp.com>; Li, HongboX
> <hongbox.li@intel.com>; Nagarahalli, Honnappa
> <Honnappa.Nagarahalli@arm.com>; Stokes, Ian <ian.stokes@intel.com>; Jack
> Bond-Preston <jack.bond-preston@foss.arm.com>; Jerin Jacob
> <jerinj@marvell.com>; Jiawen Wu <jiawenwu@trustnetic.com>; Jiayu Hu
> <hujiayu.hu@foxmail.com>; Ji, Kai <kai.ji@intel.com>; Deng, KaiwenX
> <kaiwenx.deng@intel.com>; Kiran Kumar K <kirankumark@marvell.com>;
> Kishore Padmanabha <kishore.padmanabha@broadcom.com>; Konstantin
> Ananyev <konstantin.ananyev@huawei.com>; Kumara Parameshwaran
> <kumaraparamesh92@gmail.com>; Luca Boccassi <bluca@debian.org>; Kuka,
> Mario <kuka@cesnet.cz>; Matan Azrad <matan@nvidia.com>; Maxime
> Coquelin <maxime.coquelin@redhat.com>; Michael Baum
> <michaelba@nvidia.com>; Mike Baucom <michael.baucom@broadcom.com>;
> Mohammad Iqbal Ahmad <mahmad@marvell.com>; Morten Brørup
> <mb@smartsharesystems.com>; Nathan Brown <nathan.brown@arm.com>;
> Chautru, Nicolas <nicolas.chautru@intel.com>; Nithin Dabilpuram
> <ndabilpuram@marvell.com>; Ola Liljedahl <ola.liljedahl@arm.com>;
> Oleksandr Nahnybida <oleksandrn@interfacemasters.com>; Ori Kam
> <orika@nvidia.com>; Pavan Nikhilesh <pbhagavatula@marvell.com>; Zhang,
> Qi Z <qi.z.zhang@intel.com>; Rahul Bhansali <rbhansali@marvell.com>; Randy
> Schacher <stuart.schacher@broadcom.com>; Robin Jarry
> <rjarry@redhat.com>; Rohit Raj <rohit.raj@nxp.com>; Ruifeng Wang
> <ruifeng.wang@arm.com>; Selwin Sebastian <selwin.sebastian@amd.com>;
> Shahaji Bhosle <sbhosle@broadcom.com>; Shijith Thotton
> <sthotton@marvell.com>; Shuanglin Wang
> <shuanglin.wang@broadcom.com>; Shun Hao <shunh@nvidia.com>;
> Sivaprasad Tummala <sivaprasad.tummala@amd.com>; Sriharsha
> Basavapatna <sriharsha.basavapatna@broadcom.com>; Srujana Challa
> <schalla@marvell.com>; Stephen Hemminger
> <stephen@networkplumber.org>; Steve Yang <stevex.yang@intel.com>;
> Suanming Mou <suanmingm@nvidia.com>; Sunil Kumar Kori
> <skori@marvell.com>; Tianli Lai <laitianli@tom.com>; Tim Martin
> <timothym@nvidia.com>; Tomasz Wakula <tomaszx.wakula@intel.com>;
> Tyler Retzlaff <roretzla@linux.microsoft.com>; Vamsi Attunuru
> <vattunuru@marvell.com>; Vanshika Shukla <vanshika.shukla@nxp.com>;
> Venkat Kumar Ande <venkatkumar.ande@amd.com>; Viacheslav Ovsiienko
> <viacheslavo@nvidia.com>; Wathsala Vithanage
> <wathsala.vithanage@arm.com>
> Subject: please help backporting some patches to stable release 21.11.9
> 
> Hi commit authors (and maintainers),
> 
> Despite being selected by the DPDK maintenance tool ./devtools/git-log-
> fixes.sh
> I didn't apply following commits from DPDK main to 21.11
> stable branch, as conflicts or build errors occur.
> 
> Can authors check your patches in the following list and either:
>     - Backport your patches to the 21.11 branch, or
>     - Indicate that the patch should not be backported
> 
> Please do either of the above by 12/02/24.
> 
> Note: 21.11.9 is the final planned release for the 21.11 LTS series, so I would
> urge extra caution about any changes which may introduce regressions. I
> would
> expect that most users will have moved or plan to move to a newer
> maintained
> LTS release at this point.
> 
> I have sent the full list below, but I suggest authors to only rebase any
> important fixes and ensure that they test there are no regressions.
> 
> You can find the a temporary work-in-progress branch of the coming 21.11.9
> release at:
>     https://github.com/kevintraynor/dpdk-stable
> It is recommended to backport on top of that to minimize further conflicts or
> misunderstandings.
> 
> Some notes on stable backports:
> 
> A backport should contain a reference to the DPDK main branch commit
> in it's commit message in the following fashion:
>     [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
> 
> For example:
>     https://git.dpdk.org/dpdk-
> stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
> 
> When sending the backported patch, please indicate the target branch in the
> subject line, as we have multiple branches, for example:
>     [PATCH 21.11] foo/bar: fix baz
> 
> With git format-patch, this can be achieved by appending the parameter:
>     --subject-prefix='PATCH 21.11'
> 
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
> 
> FYI, branch 21.11 is located at tree:
>    https://git.dpdk.org/dpdk-stable
> 
> Thanks.
> 
> Kevin
> 
> ---
> c5b531d6ee  Anoob Joseph     app/crypto-perf: fix session freeing
> 04dac73643  Ganapati Kundapura eventdev/crypto: fix enqueue count
> 4b04134cbb  Ganapati Kundapura eventdev/crypto: fix failed events
> da73a2a0d1  Ganapati Kundapura eventdev/crypto: fix offset used while
> flushing events
> f442c04001  Ganapati Kundapura eventdev/crypto: fix overflow in circular
> buffer
> 5a0f64d84b  Hanumanth Pothula net/cnxk: fix configuring large Rx/Tx queues
> 59ceaa72d5  Harman Kalra     common/cnxk: fix part number for CN10K
> 31a28a99fd  Jiawen Wu        net/ngbe: add spinlock protection on YT PHY
> 5781638519  Nithin Dabilpuram common/cnxk: fix RQ mask config for
> CN10KB chip
> 3fe71706ab  Pavan Nikhilesh  event/cnxk: fix stale data in workslot
> 927cb43fe9  Pavan Nikhilesh  examples/l3fwd: fix port group mask with
> AltiVec
> 0f044b6681  Steve Yang       net/iavf: fix refine protocol header
> 0b241667cc  Steve Yang       net/iavf: fix tainted scalar
> b125c0e721  Steve Yang       net/iavf: fix tainted scalar
> cedb44dc87  Suanming Mou     common/mlx5: improve AES-XTS tweak
> capability check
> 7be74edb90  Honnappa Nagarahalli common/mlx5: use just sufficient barrier
> for Arm
> 7bdf7a13ae  Michael Baum     app/testpmd: fix encap/decap size calculation
> 6df1bc6b3b  Ashwin Sekhar T K mempool/cnxk: avoid hang when counting
> batch allocs
> 772e30281a  Rahul Bhansali   common/cnxk: fix CPT backpressure disable on
> LBK
> b37fe88a2c  Srujana Challa   event/cnxk: fix LMTST write for single event mode
> 92a16af450  Kaiwen Deng      net/iavf: fix virtchnl command called in interrupt
> 12011b11a3  Jiawen Wu        net/txgbe: adapt to MNG veto bit setting
> 21f702d556  Jiawen Wu        net/ngbe: fix link status in no LSC mode
> 659cfce01e  Jiawen Wu        net/ngbe: remove redundant codes
> 9749dffe23  Kaiwen Deng      net/ice: fix MAC type of E822 and E823
> 1c7a4d37e7  Harman Kalra     common/cnxk: fix mailbox timeout due to
> deadlock
> 5e170dd8b6  Jiawen Wu        net/txgbe: fix blocking system events
> 37ca457d3f  Bing Zhao        common/mlx5: fix obtaining IB device in LAG mode
> 9a518054b5  Mohammad Iqbal Ahmad examples/l3fwd: fix duplicate
> expression for default nexthop
> 61b52e7edb  Stephen Hemminger app/test: fix reference to master in bonding
> test
> 63bf81a617  Anatoly Burakov  test: fix named test macro
> 694e8e643d  Pavan Nikhilesh  event/cnxk: fix CASP usage for clang
> a6f639e079  Sunil Kumar Kori common/cnxk: fix BP threshold calculation
> 95a955e3e0  Amit Prakash Shukla dma/cnxk: fix device reconfigure
> 3dd3115078  Amit Prakash Shukla dma/cnxk: fix chunk buffer failure return
> code
> ba39a261a7  Vamsi Attunuru   dma/cnxk: fix completion ring tail wrap
> b3ddd649ad  Ashwin Sekhar T K mempool/cnxk: fix alloc from non-EAL
> threads
> 56fa6f92e9  Kiran Kumar K    common/cnxk: fix RSS key configuration
> 7752f14026  Rahul Bhansali   net/cnxk: fix Rx flush on CN10k
> 5d8c1f6253  Nithin Dabilpuram common/cnxk: check error in MAC address
> set
> a74c5001e9  Jiawen Wu        net/ngbe: add proper memory barriers in Rx
> 2ece3b7186  Bing Zhao        net/mlx5: fix flow workspace double free in
> Windows
> 9d91c3047d  Gowrishankar Muthukrishnan crypto/openssl: fix memory leaks
> in asym operations
> 166591931b  Stephen Hemminger pcapng: modify timestamp calculation
> 547f294357  Kumara Parameshwaran gro: fix reordering of packets
> 063cddfc74  Honnappa Nagarahalli rcu: use atomic operation on acked token
> df33fb53e4  Honnappa Nagarahalli rcu: fix acked token in debug log
> 02a2accb5f  Mário Kuka       net/bonding: fix flow count query
> 44a8635459  Hanumanth Pothula net/thunderx: fix DMAC control register
> update
> 48adbc80ba  Michael Baum     net/mlx5: remove GENEVE options length
> limitation
> 461c287ab5  Kumara Parameshwaran app/testpmd: fix GRO packets flush on
> timeout
> 3232c95d2c  Nithin Dabilpuram net/cnxk: fix indirect mbuf handling in Tx
> 26a6bda9df  Rahul Bhansali   net/cnxk: add cookies check for multi-segment
> offload
> 8ed5ca4dda  Rahul Bhansali   net/cnxk: fix mbuf fields in multi-segment Tx
> 48054ca384  Harman Kalra     common/cnxk: fix link config for SDP
> 87e4384d26  Bing Zhao        net/mlx5: fix condition of LACP miss flow
> 1cfb78d2c4  Shun Hao         net/mlx5: fix meter policy priority
> a78a1ed8ba  Gaoxiang Liu     net/bonding: fix failover time of LACP with mode
> 4
> ecf408d2aa  Bing Zhao        app/testpmd: fix indirect action flush
> b9a87346b0  Chengwen Feng    ethdev: fix strict aliasing in link up
> e82b0fe097  Venkat Kumar Ande net/axgbe: disable RRC for yellow carp
> devices
> ad12d08f05  Ganapati Kundapura eventdev/crypto: fix opaque field handling
> 4edbcc7b53  Luca Boccassi    bpf: disable on 32-bit x86
> b1d7112602  Jack Bond-Preston crypto/openssl: make per-QP cipher context
> clones
> 17d5bc6135  Jack Bond-Preston crypto/openssl: make per-QP auth context
> clones
> ee0fa7552a  Rohit Raj        net/dpaa: forbid MTU configuration for shared
> interface
> e2072ba1b0  Fabio Pricoco    net/ice/base: fix resource leak
> df44ba7a3c  Tomasz Wakula    net/ice/base: fix preparing PHY for timesync
> command
> 79be49dd2d  Jiawen Wu        net/ngbe: add special config for YT8531SH-CA
> PHY
> 2a3f42942a  Chengwen Feng    dma/hisilicon: remove support for HIP09
> platform
> b23c5bd71a  Sivaprasad Tummala examples: fix queue ID restriction
> 4b97893816  Sivaprasad Tummala examples: fix lcore ID restriction
> 548de9091c  Sivaprasad Tummala examples: fix port ID restriction
> abdabad636  Ciara Loftus     net/af_xdp: remove unused local statistic
> 4c2f14bc6d  Sunil Kumar Kori net/cnxk: fix xstats reset
> 4ad17a1c8f  Akhil Goyal      test/crypto: fix enqueue/dequeue callback case
> 046341575b  Gagandeep Singh  crypto/dpaa_sec: fix IPsec descriptor
> 97039941b2  Frank Du         net/af_xdp: parse UMEM map info from mempool
> 4edbcc7b53  Luca Boccassi    bpf: disable on 32-bit x86
> 6db358536f  Oleksandr Nahnybida pcapng: fix handling of chained mbufs
> 5c0f970c0d  Stephen Hemminger app/dumpcap: fix handling of jumbo
> frames
> 2d4505dc6d  Sunil Kumar Kori common/cnxk: fix MAC address change with
> active VF
> 6c3de40af8  Nithin Dabilpuram common/cnxk: fix inline CTX write
> 6f96937dad  Robin Jarry      ethdev: fix race on ports in telemetry endpoints
> b34fe66ea8  Bruce Richardson net/iavf: delay VF reset command
> b04b06f4cb  Viacheslav Ovsiienko net/mlx5: fix flex item header length field
> translation
> 27918f0d53  Tim Martin       net/mlx5: fix real time counter reading from PCI
> BAR
> ebab0e8b22  Konstantin Ananyev examples/l3fwd: fix read beyond
> boundaries
> 0c5709824b  Nicolas Chautru  baseband/acc: fix ring memory allocation
> 251fdc592d  Brian Dooley     test/crypto: fix synchronous API calls
> 78dcdb821c  Shahaji Bhosle   net/bnxt/tf_core: fix WC TCAM multi-slice delete
> 8782e4de3e  Kishore Padmanabha net/bnxt/tf_ulp: fix parent child DB
> counters
> e6bf3256b9  Stephen Hemminger net/dpaa2: remove unnecessary check for
> null before free
> 3cddeba0ca  Alexander Kozyrev common/mlx5: fix error CQE handling for 128
> bytes CQE
> 3c9a82fa6e  Bing Zhao        net/mlx5: fix Rx queue control management
> a7ae9ba1f8  Alexander Kozyrev net/mlx5: fix miniCQEs number calculation
> ffe827f38e  Andre Muezerie   rcu: fix implicit conversion in bit shift
> f8f294c66b  Bing Zhao        net/mlx5: fix shared Rx queue control release
> 916aa13f4a  Jiawen Wu        net/txgbe: fix a mass of interrupts
> 0151b80786  Stephen Hemminger test/security: fix IPv6 extension loop
> ebab0e8b22  Konstantin Ananyev examples/l3fwd: fix read beyond
> boundaries

Re: please help backporting some patches to stable release 21.11.9

[Kevin Traynor]

On 28/11/2024 12:48, Richardson, Bruce wrote:
> For commit b34fe66ea893 ("net/iavf: delay VF reset command"), I will do a backport for 21.11. 
> 
> This will actually be a combination of two commits:
> 	0f9ec0cbd2a9 ("net/iavf: fix VF reset when using DCF")
> 	b34fe66ea893 ("net/iavf: delay VF reset command")
> 
> Since the referenced commit below is actually a fix for the earlier fix - which was never actually backported to 21.11. Patch will arrive shortly, just build-testing it.
> 

Thanks Bruce. Yep, it wasn't backported as it was causing a build error.
My notes say:

../drivers/net/iavf/iavf_ethdev.c: In function ‘iavf_dev_reset’:
../drivers/net/iavf/iavf_ethdev.c:2784:16: error: ‘struct iavf_info’ has
no member named ‘in_reset_recovery’
 2784 |         if (!vf->in_reset_recovery) {
      |                ^~

In 23.11.2 LTS the initial fix caused an issue with reset which blocked
some validation of iavf, so it was considered a release blocking issue.
Your delay VF reset fix, fixed the issue.

I'm inclined to be extra cautious about a new patch because it is
involving reset of device, previous fix had issue so perhaps there is
lack of test coverage (especially for 21.11) and there is no planned
opportunity to fix in a later 21.11 LTS.

But, if you are confident about it and think the fix is a must have, I
can apply.

What do you think ?

> /Bruce
> 
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Wednesday, November 27, 2024 5:34 PM
>> To: dpdk stable <stable@dpdk.org>
>> Cc: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; Ajit Khaparde
>> <ajit.khaparde@broadcom.com>; Akhil Goyal <gakhil@marvell.com>;
>> Alexander Kozyrev <akozyrev@nvidia.com>; Amit Prakash Shukla
>> <amitprakashs@marvell.com>; Burakov, Anatoly
>> <anatoly.burakov@intel.com>; Andre Muezerie
>> <andremue@linux.microsoft.com>; Anoob Joseph <anoobj@marvell.com>;
>> Ashwin Sekhar T K <asekhar@marvell.com>; Bing Zhao <bingz@nvidia.com>;
>> Dooley, Brian <brian.dooley@intel.com>; Richardson, Bruce
>> <bruce.richardson@intel.com>; Chengwen Feng
>> <fengchengwen@huawei.com>; Loftus, Ciara <ciara.loftus@intel.com>; Ciara
>> Power <ciara.power@intel.com>; Walsh, Conor <conor.walsh@intel.com>;
>> Dariusz Sosnowski <dsosnowski@nvidia.com>; Marchand, David
>> <david.marchand@redhat.com>; Dengdui Huang
>> <huangdengdui@huawei.com>; Pricoco, Fabio <fabio.pricoco@intel.com>;
>> Ferruh Yigit <ferruh.yigit@amd.com>; Du, Frank <frank.du@intel.com>;
>> Gagandeep Singh <g.singh@nxp.com>; Kundapura, Ganapati
>> <ganapati.kundapura@intel.com>; Gaoxiang Liu <liugaoxiang@huawei.com>;
>> Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>; Hanumanth
>> Pothula <hpothula@marvell.com>; Harman Kalra <hkalra@marvell.com>;
>> Hemant Agrawal <hemant.agrawal@nxp.com>; Li, HongboX
>> <hongbox.li@intel.com>; Nagarahalli, Honnappa
>> <Honnappa.Nagarahalli@arm.com>; Stokes, Ian <ian.stokes@intel.com>; Jack
>> Bond-Preston <jack.bond-preston@foss.arm.com>; Jerin Jacob
>> <jerinj@marvell.com>; Jiawen Wu <jiawenwu@trustnetic.com>; Jiayu Hu
>> <hujiayu.hu@foxmail.com>; Ji, Kai <kai.ji@intel.com>; Deng, KaiwenX
>> <kaiwenx.deng@intel.com>; Kiran Kumar K <kirankumark@marvell.com>;
>> Kishore Padmanabha <kishore.padmanabha@broadcom.com>; Konstantin
>> Ananyev <konstantin.ananyev@huawei.com>; Kumara Parameshwaran
>> <kumaraparamesh92@gmail.com>; Luca Boccassi <bluca@debian.org>; Kuka,
>> Mario <kuka@cesnet.cz>; Matan Azrad <matan@nvidia.com>; Maxime
>> Coquelin <maxime.coquelin@redhat.com>; Michael Baum
>> <michaelba@nvidia.com>; Mike Baucom <michael.baucom@broadcom.com>;
>> Mohammad Iqbal Ahmad <mahmad@marvell.com>; Morten Brørup
>> <mb@smartsharesystems.com>; Nathan Brown <nathan.brown@arm.com>;
>> Chautru, Nicolas <nicolas.chautru@intel.com>; Nithin Dabilpuram
>> <ndabilpuram@marvell.com>; Ola Liljedahl <ola.liljedahl@arm.com>;
>> Oleksandr Nahnybida <oleksandrn@interfacemasters.com>; Ori Kam
>> <orika@nvidia.com>; Pavan Nikhilesh <pbhagavatula@marvell.com>; Zhang,
>> Qi Z <qi.z.zhang@intel.com>; Rahul Bhansali <rbhansali@marvell.com>; Randy
>> Schacher <stuart.schacher@broadcom.com>; Robin Jarry
>> <rjarry@redhat.com>; Rohit Raj <rohit.raj@nxp.com>; Ruifeng Wang
>> <ruifeng.wang@arm.com>; Selwin Sebastian <selwin.sebastian@amd.com>;
>> Shahaji Bhosle <sbhosle@broadcom.com>; Shijith Thotton
>> <sthotton@marvell.com>; Shuanglin Wang
>> <shuanglin.wang@broadcom.com>; Shun Hao <shunh@nvidia.com>;
>> Sivaprasad Tummala <sivaprasad.tummala@amd.com>; Sriharsha
>> Basavapatna <sriharsha.basavapatna@broadcom.com>; Srujana Challa
>> <schalla@marvell.com>; Stephen Hemminger
>> <stephen@networkplumber.org>; Steve Yang <stevex.yang@intel.com>;
>> Suanming Mou <suanmingm@nvidia.com>; Sunil Kumar Kori
>> <skori@marvell.com>; Tianli Lai <laitianli@tom.com>; Tim Martin
>> <timothym@nvidia.com>; Tomasz Wakula <tomaszx.wakula@intel.com>;
>> Tyler Retzlaff <roretzla@linux.microsoft.com>; Vamsi Attunuru
>> <vattunuru@marvell.com>; Vanshika Shukla <vanshika.shukla@nxp.com>;
>> Venkat Kumar Ande <venkatkumar.ande@amd.com>; Viacheslav Ovsiienko
>> <viacheslavo@nvidia.com>; Wathsala Vithanage
>> <wathsala.vithanage@arm.com>
>> Subject: please help backporting some patches to stable release 21.11.9
>>
>> Hi commit authors (and maintainers),
>>
>> Despite being selected by the DPDK maintenance tool ./devtools/git-log-
>> fixes.sh
>> I didn't apply following commits from DPDK main to 21.11
>> stable branch, as conflicts or build errors occur.
>>
>> Can authors check your patches in the following list and either:
>>     - Backport your patches to the 21.11 branch, or
>>     - Indicate that the patch should not be backported
>>
>> Please do either of the above by 12/02/24.
>>
>> Note: 21.11.9 is the final planned release for the 21.11 LTS series, so I would
>> urge extra caution about any changes which may introduce regressions. I
>> would
>> expect that most users will have moved or plan to move to a newer
>> maintained
>> LTS release at this point.
>>
>> I have sent the full list below, but I suggest authors to only rebase any
>> important fixes and ensure that they test there are no regressions.
>>
>> You can find the a temporary work-in-progress branch of the coming 21.11.9
>> release at:
>>     https://github.com/kevintraynor/dpdk-stable
>> It is recommended to backport on top of that to minimize further conflicts or
>> misunderstandings.
>>
>> Some notes on stable backports:
>>
>> A backport should contain a reference to the DPDK main branch commit
>> in it's commit message in the following fashion:
>>     [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
>>
>> For example:
>>     https://git.dpdk.org/dpdk-
>> stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
>>
>> When sending the backported patch, please indicate the target branch in the
>> subject line, as we have multiple branches, for example:
>>     [PATCH 21.11] foo/bar: fix baz
>>
>> With git format-patch, this can be achieved by appending the parameter:
>>     --subject-prefix='PATCH 21.11'
>>
>> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
>>
>> FYI, branch 21.11 is located at tree:
>>    https://git.dpdk.org/dpdk-stable
>>
>> Thanks.
>>
>> Kevin
>>
>> ---
>> c5b531d6ee  Anoob Joseph     app/crypto-perf: fix session freeing
>> 04dac73643  Ganapati Kundapura eventdev/crypto: fix enqueue count
>> 4b04134cbb  Ganapati Kundapura eventdev/crypto: fix failed events
>> da73a2a0d1  Ganapati Kundapura eventdev/crypto: fix offset used while
>> flushing events
>> f442c04001  Ganapati Kundapura eventdev/crypto: fix overflow in circular
>> buffer
>> 5a0f64d84b  Hanumanth Pothula net/cnxk: fix configuring large Rx/Tx queues
>> 59ceaa72d5  Harman Kalra     common/cnxk: fix part number for CN10K
>> 31a28a99fd  Jiawen Wu        net/ngbe: add spinlock protection on YT PHY
>> 5781638519  Nithin Dabilpuram common/cnxk: fix RQ mask config for
>> CN10KB chip
>> 3fe71706ab  Pavan Nikhilesh  event/cnxk: fix stale data in workslot
>> 927cb43fe9  Pavan Nikhilesh  examples/l3fwd: fix port group mask with
>> AltiVec
>> 0f044b6681  Steve Yang       net/iavf: fix refine protocol header
>> 0b241667cc  Steve Yang       net/iavf: fix tainted scalar
>> b125c0e721  Steve Yang       net/iavf: fix tainted scalar
>> cedb44dc87  Suanming Mou     common/mlx5: improve AES-XTS tweak
>> capability check
>> 7be74edb90  Honnappa Nagarahalli common/mlx5: use just sufficient barrier
>> for Arm
>> 7bdf7a13ae  Michael Baum     app/testpmd: fix encap/decap size calculation
>> 6df1bc6b3b  Ashwin Sekhar T K mempool/cnxk: avoid hang when counting
>> batch allocs
>> 772e30281a  Rahul Bhansali   common/cnxk: fix CPT backpressure disable on
>> LBK
>> b37fe88a2c  Srujana Challa   event/cnxk: fix LMTST write for single event mode
>> 92a16af450  Kaiwen Deng      net/iavf: fix virtchnl command called in interrupt
>> 12011b11a3  Jiawen Wu        net/txgbe: adapt to MNG veto bit setting
>> 21f702d556  Jiawen Wu        net/ngbe: fix link status in no LSC mode
>> 659cfce01e  Jiawen Wu        net/ngbe: remove redundant codes
>> 9749dffe23  Kaiwen Deng      net/ice: fix MAC type of E822 and E823
>> 1c7a4d37e7  Harman Kalra     common/cnxk: fix mailbox timeout due to
>> deadlock
>> 5e170dd8b6  Jiawen Wu        net/txgbe: fix blocking system events
>> 37ca457d3f  Bing Zhao        common/mlx5: fix obtaining IB device in LAG mode
>> 9a518054b5  Mohammad Iqbal Ahmad examples/l3fwd: fix duplicate
>> expression for default nexthop
>> 61b52e7edb  Stephen Hemminger app/test: fix reference to master in bonding
>> test
>> 63bf81a617  Anatoly Burakov  test: fix named test macro
>> 694e8e643d  Pavan Nikhilesh  event/cnxk: fix CASP usage for clang
>> a6f639e079  Sunil Kumar Kori common/cnxk: fix BP threshold calculation
>> 95a955e3e0  Amit Prakash Shukla dma/cnxk: fix device reconfigure
>> 3dd3115078  Amit Prakash Shukla dma/cnxk: fix chunk buffer failure return
>> code
>> ba39a261a7  Vamsi Attunuru   dma/cnxk: fix completion ring tail wrap
>> b3ddd649ad  Ashwin Sekhar T K mempool/cnxk: fix alloc from non-EAL
>> threads
>> 56fa6f92e9  Kiran Kumar K    common/cnxk: fix RSS key configuration
>> 7752f14026  Rahul Bhansali   net/cnxk: fix Rx flush on CN10k
>> 5d8c1f6253  Nithin Dabilpuram common/cnxk: check error in MAC address
>> set
>> a74c5001e9  Jiawen Wu        net/ngbe: add proper memory barriers in Rx
>> 2ece3b7186  Bing Zhao        net/mlx5: fix flow workspace double free in
>> Windows
>> 9d91c3047d  Gowrishankar Muthukrishnan crypto/openssl: fix memory leaks
>> in asym operations
>> 166591931b  Stephen Hemminger pcapng: modify timestamp calculation
>> 547f294357  Kumara Parameshwaran gro: fix reordering of packets
>> 063cddfc74  Honnappa Nagarahalli rcu: use atomic operation on acked token
>> df33fb53e4  Honnappa Nagarahalli rcu: fix acked token in debug log
>> 02a2accb5f  Mário Kuka       net/bonding: fix flow count query
>> 44a8635459  Hanumanth Pothula net/thunderx: fix DMAC control register
>> update
>> 48adbc80ba  Michael Baum     net/mlx5: remove GENEVE options length
>> limitation
>> 461c287ab5  Kumara Parameshwaran app/testpmd: fix GRO packets flush on
>> timeout
>> 3232c95d2c  Nithin Dabilpuram net/cnxk: fix indirect mbuf handling in Tx
>> 26a6bda9df  Rahul Bhansali   net/cnxk: add cookies check for multi-segment
>> offload
>> 8ed5ca4dda  Rahul Bhansali   net/cnxk: fix mbuf fields in multi-segment Tx
>> 48054ca384  Harman Kalra     common/cnxk: fix link config for SDP
>> 87e4384d26  Bing Zhao        net/mlx5: fix condition of LACP miss flow
>> 1cfb78d2c4  Shun Hao         net/mlx5: fix meter policy priority
>> a78a1ed8ba  Gaoxiang Liu     net/bonding: fix failover time of LACP with mode
>> 4
>> ecf408d2aa  Bing Zhao        app/testpmd: fix indirect action flush
>> b9a87346b0  Chengwen Feng    ethdev: fix strict aliasing in link up
>> e82b0fe097  Venkat Kumar Ande net/axgbe: disable RRC for yellow carp
>> devices
>> ad12d08f05  Ganapati Kundapura eventdev/crypto: fix opaque field handling
>> 4edbcc7b53  Luca Boccassi    bpf: disable on 32-bit x86
>> b1d7112602  Jack Bond-Preston crypto/openssl: make per-QP cipher context
>> clones
>> 17d5bc6135  Jack Bond-Preston crypto/openssl: make per-QP auth context
>> clones
>> ee0fa7552a  Rohit Raj        net/dpaa: forbid MTU configuration for shared
>> interface
>> e2072ba1b0  Fabio Pricoco    net/ice/base: fix resource leak
>> df44ba7a3c  Tomasz Wakula    net/ice/base: fix preparing PHY for timesync
>> command
>> 79be49dd2d  Jiawen Wu        net/ngbe: add special config for YT8531SH-CA
>> PHY
>> 2a3f42942a  Chengwen Feng    dma/hisilicon: remove support for HIP09
>> platform
>> b23c5bd71a  Sivaprasad Tummala examples: fix queue ID restriction
>> 4b97893816  Sivaprasad Tummala examples: fix lcore ID restriction
>> 548de9091c  Sivaprasad Tummala examples: fix port ID restriction
>> abdabad636  Ciara Loftus     net/af_xdp: remove unused local statistic
>> 4c2f14bc6d  Sunil Kumar Kori net/cnxk: fix xstats reset
>> 4ad17a1c8f  Akhil Goyal      test/crypto: fix enqueue/dequeue callback case
>> 046341575b  Gagandeep Singh  crypto/dpaa_sec: fix IPsec descriptor
>> 97039941b2  Frank Du         net/af_xdp: parse UMEM map info from mempool
>> 4edbcc7b53  Luca Boccassi    bpf: disable on 32-bit x86
>> 6db358536f  Oleksandr Nahnybida pcapng: fix handling of chained mbufs
>> 5c0f970c0d  Stephen Hemminger app/dumpcap: fix handling of jumbo
>> frames
>> 2d4505dc6d  Sunil Kumar Kori common/cnxk: fix MAC address change with
>> active VF
>> 6c3de40af8  Nithin Dabilpuram common/cnxk: fix inline CTX write
>> 6f96937dad  Robin Jarry      ethdev: fix race on ports in telemetry endpoints
>> b34fe66ea8  Bruce Richardson net/iavf: delay VF reset command
>> b04b06f4cb  Viacheslav Ovsiienko net/mlx5: fix flex item header length field
>> translation
>> 27918f0d53  Tim Martin       net/mlx5: fix real time counter reading from PCI
>> BAR
>> ebab0e8b22  Konstantin Ananyev examples/l3fwd: fix read beyond
>> boundaries
>> 0c5709824b  Nicolas Chautru  baseband/acc: fix ring memory allocation
>> 251fdc592d  Brian Dooley     test/crypto: fix synchronous API calls
>> 78dcdb821c  Shahaji Bhosle   net/bnxt/tf_core: fix WC TCAM multi-slice delete
>> 8782e4de3e  Kishore Padmanabha net/bnxt/tf_ulp: fix parent child DB
>> counters
>> e6bf3256b9  Stephen Hemminger net/dpaa2: remove unnecessary check for
>> null before free
>> 3cddeba0ca  Alexander Kozyrev common/mlx5: fix error CQE handling for 128
>> bytes CQE
>> 3c9a82fa6e  Bing Zhao        net/mlx5: fix Rx queue control management
>> a7ae9ba1f8  Alexander Kozyrev net/mlx5: fix miniCQEs number calculation
>> ffe827f38e  Andre Muezerie   rcu: fix implicit conversion in bit shift
>> f8f294c66b  Bing Zhao        net/mlx5: fix shared Rx queue control release
>> 916aa13f4a  Jiawen Wu        net/txgbe: fix a mass of interrupts
>> 0151b80786  Stephen Hemminger test/security: fix IPv6 extension loop
>> ebab0e8b22  Konstantin Ananyev examples/l3fwd: fix read beyond
>> boundaries
> 

RE: please help backporting some patches to stable release 21.11.9

[Richardson, Bruce]

> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Friday, November 29, 2024 10:23 AM
> To: Richardson, Bruce <bruce.richardson@intel.com>; dpdk stable
> <stable@dpdk.org>
> Cc: Marchand, David <david.marchand@redhat.com>; Luca Boccassi
> <bluca@debian.org>
> Subject: Re: please help backporting some patches to stable release 21.11.9
> 
> On 28/11/2024 12:48, Richardson, Bruce wrote:
> > For commit b34fe66ea893 ("net/iavf: delay VF reset command"), I will do a
> backport for 21.11.
> >
> > This will actually be a combination of two commits:
> > 	0f9ec0cbd2a9 ("net/iavf: fix VF reset when using DCF")
> > 	b34fe66ea893 ("net/iavf: delay VF reset command")
> >
> > Since the referenced commit below is actually a fix for the earlier fix - which
> was never actually backported to 21.11. Patch will arrive shortly, just build-
> testing it.
> >
> 
> Thanks Bruce. Yep, it wasn't backported as it was causing a build error.
> My notes say:
> 
> ../drivers/net/iavf/iavf_ethdev.c: In function ‘iavf_dev_reset’:
> ../drivers/net/iavf/iavf_ethdev.c:2784:16: error: ‘struct iavf_info’ has
> no member named ‘in_reset_recovery’
>  2784 |         if (!vf->in_reset_recovery) {
>       |                ^~
> 
> In 23.11.2 LTS the initial fix caused an issue with reset which blocked
> some validation of iavf, so it was considered a release blocking issue.
> Your delay VF reset fix, fixed the issue.
> 
> I'm inclined to be extra cautious about a new patch because it is
> involving reset of device, previous fix had issue so perhaps there is
> lack of test coverage (especially for 21.11) and there is no planned
> opportunity to fix in a later 21.11 LTS.
> 
> But, if you are confident about it and think the fix is a must have, I
> can apply.
> 
> What do you think ?
> 
I think it should be safe enough to take, and it's not really a new patch as-such.

The reason the original version of my patch from mainline didn't apply was that it essentially rolled back the original fix and applied a different one. The rollback part is the bit that failed, since the first fix wasn't applied. My "new" patch is therefore the fix that was applied to mainline, just without the lines deleted for rollback.

/Bruce

Re: please help backporting some patches to stable release 21.11.9

[Kevin Traynor]

On 29/11/2024 11:32, Richardson, Bruce wrote:
> 
> 
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Friday, November 29, 2024 10:23 AM
>> To: Richardson, Bruce <bruce.richardson@intel.com>; dpdk stable
>> <stable@dpdk.org>
>> Cc: Marchand, David <david.marchand@redhat.com>; Luca Boccassi
>> <bluca@debian.org>
>> Subject: Re: please help backporting some patches to stable release 21.11.9
>>
>> On 28/11/2024 12:48, Richardson, Bruce wrote:
>>> For commit b34fe66ea893 ("net/iavf: delay VF reset command"), I will do a
>> backport for 21.11.
>>>
>>> This will actually be a combination of two commits:
>>> 	0f9ec0cbd2a9 ("net/iavf: fix VF reset when using DCF")
>>> 	b34fe66ea893 ("net/iavf: delay VF reset command")
>>>
>>> Since the referenced commit below is actually a fix for the earlier fix - which
>> was never actually backported to 21.11. Patch will arrive shortly, just build-
>> testing it.
>>>
>>
>> Thanks Bruce. Yep, it wasn't backported as it was causing a build error.
>> My notes say:
>>
>> ../drivers/net/iavf/iavf_ethdev.c: In function ‘iavf_dev_reset’:
>> ../drivers/net/iavf/iavf_ethdev.c:2784:16: error: ‘struct iavf_info’ has
>> no member named ‘in_reset_recovery’
>>  2784 |         if (!vf->in_reset_recovery) {
>>       |                ^~
>>
>> In 23.11.2 LTS the initial fix caused an issue with reset which blocked
>> some validation of iavf, so it was considered a release blocking issue.
>> Your delay VF reset fix, fixed the issue.
>>
>> I'm inclined to be extra cautious about a new patch because it is
>> involving reset of device, previous fix had issue so perhaps there is
>> lack of test coverage (especially for 21.11) and there is no planned
>> opportunity to fix in a later 21.11 LTS.
>>
>> But, if you are confident about it and think the fix is a must have, I
>> can apply.
>>
>> What do you think ?
>>
> I think it should be safe enough to take, and it's not really a new patch as-such.
> 
> The reason the original version of my patch from mainline didn't apply was that it essentially rolled back the original fix and applied a different one. The rollback part is the bit that failed, since the first fix wasn't applied. My "new" patch is therefore the fix that was applied to mainline, just without the lines deleted for rollback.
> 

ok, thanks. I will add a small note to the commit log to note it is
effectively a squash of these commits.

> /Bruce

RE: please help backporting some patches to stable release 21.11.9

[Tummala, Sivaprasad]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Kevin,

The below patches are specific to example applications and do not affect core functionality or dependencies
that would require backporting to previous versions. There is no need to backport them.

b23c5bd71a  Sivaprasad Tummala examples: fix queue ID restriction
4b97893816  Sivaprasad Tummala examples: fix lcore ID restriction
548de9091c  Sivaprasad Tummala examples: fix port ID restriction

> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Wednesday, November 27, 2024 11:04 PM
> To: dpdk stable <stable@dpdk.org>
> Cc: Abhinandan Gujjar <abhinandan.gujjar@intel.com>; Ajit Khaparde
> <ajit.khaparde@broadcom.com>; Akhil Goyal <gakhil@marvell.com>; Alexander
> Kozyrev <akozyrev@nvidia.com>; Amit Prakash Shukla
> <amitprakashs@marvell.com>; Anatoly Burakov <anatoly.burakov@intel.com>;
> Andre Muezerie <andremue@linux.microsoft.com>; Anoob Joseph
> <anoobj@marvell.com>; Ashwin Sekhar T K <asekhar@marvell.com>; Bing Zhao
> <bingz@nvidia.com>; Brian Dooley <brian.dooley@intel.com>; Bruce Richardson
> <bruce.richardson@intel.com>; Chengwen Feng <fengchengwen@huawei.com>;
> Ciara Loftus <ciara.loftus@intel.com>; Ciara Power <ciara.power@intel.com>;
> Conor Walsh <conor.walsh@intel.com>; Dariusz Sosnowski
> <dsosnowski@nvidia.com>; David Marchand <david.marchand@redhat.com>;
> Dengdui Huang <huangdengdui@huawei.com>; Fabio Pricoco
> <fabio.pricoco@intel.com>; Yigit, Ferruh <Ferruh.Yigit@amd.com>; Frank Du
> <frank.du@intel.com>; Gagandeep Singh <g.singh@nxp.com>; Ganapati
> Kundapura <ganapati.kundapura@intel.com>; Gaoxiang Liu
> <liugaoxiang@huawei.com>; Gowrishankar Muthukrishnan
> <gmuthukrishn@marvell.com>; Hanumanth Pothula <hpothula@marvell.com>;
> Harman Kalra <hkalra@marvell.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Hongbo Li <hongbox.li@intel.com>; Honnappa
> Nagarahalli <honnappa.nagarahalli@arm.com>; Ian Stokes
> <ian.stokes@intel.com>; Jack Bond-Preston <jack.bond-preston@foss.arm.com>;
> Jerin Jacob <jerinj@marvell.com>; Jiawen Wu <jiawenwu@trustnetic.com>; Jiayu
> Hu <hujiayu.hu@foxmail.com>; Kai Ji <kai.ji@intel.com>; Kaiwen Deng
> <kaiwenx.deng@intel.com>; Kiran Kumar K <kirankumark@marvell.com>; Kishore
> Padmanabha <kishore.padmanabha@broadcom.com>; Konstantin Ananyev
> <konstantin.ananyev@huawei.com>; Kumara Parameshwaran
> <kumaraparamesh92@gmail.com>; Luca Boccassi <bluca@debian.org>; Mário
> Kuka <kuka@cesnet.cz>; Matan Azrad <matan@nvidia.com>; Maxime Coquelin
> <maxime.coquelin@redhat.com>; Michael Baum <michaelba@nvidia.com>; Mike
> Baucom <michael.baucom@broadcom.com>; Mohammad Iqbal Ahmad
> <mahmad@marvell.com>; Morten Brørup <mb@smartsharesystems.com>;
> Nathan Brown <nathan.brown@arm.com>; Nicolas Chautru
> <nicolas.chautru@intel.com>; Nithin Dabilpuram <ndabilpuram@marvell.com>; Ola
> Liljedahl <ola.liljedahl@arm.com>; Oleksandr Nahnybida
> <oleksandrn@interfacemasters.com>; Ori Kam <orika@nvidia.com>; Pavan
> Nikhilesh <pbhagavatula@marvell.com>; Qi Zhang <qi.z.zhang@intel.com>; Rahul
> Bhansali <rbhansali@marvell.com>; Randy Schacher
> <stuart.schacher@broadcom.com>; Robin Jarry <rjarry@redhat.com>; Rohit Raj
> <rohit.raj@nxp.com>; Ruifeng Wang <ruifeng.wang@arm.com>; Sebastian, Selwin
> <Selwin.Sebastian@amd.com>; Shahaji Bhosle <sbhosle@broadcom.com>; Shijith
> Thotton <sthotton@marvell.com>; Shuanglin Wang
> <shuanglin.wang@broadcom.com>; Shun Hao <shunh@nvidia.com>; Tummala,
> Sivaprasad <Sivaprasad.Tummala@amd.com>; Sriharsha Basavapatna
> <sriharsha.basavapatna@broadcom.com>; Srujana Challa
> <schalla@marvell.com>; Stephen Hemminger <stephen@networkplumber.org>;
> Steve Yang <stevex.yang@intel.com>; Suanming Mou <suanmingm@nvidia.com>;
> Sunil Kumar Kori <skori@marvell.com>; Tianli Lai <laitianli@tom.com>; Tim Martin
> <timothym@nvidia.com>; Tomasz Wakula <tomaszx.wakula@intel.com>; Tyler
> Retzlaff <roretzla@linux.microsoft.com>; Vamsi Attunuru
> <vattunuru@marvell.com>; Vanshika Shukla <vanshika.shukla@nxp.com>; Ande,
> Venkat Kumar <VenkatKumar.Ande@amd.com>; Viacheslav Ovsiienko
> <viacheslavo@nvidia.com>; Wathsala Vithanage <wathsala.vithanage@arm.com>
> Subject: please help backporting some patches to stable release 21.11.9
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Hi commit authors (and maintainers),
>
> Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh I
> didn't apply following commits from DPDK main to 21.11 stable branch, as conflicts
> or build errors occur.
>
> Can authors check your patches in the following list and either:
>     - Backport your patches to the 21.11 branch, or
>     - Indicate that the patch should not be backported
>
> Please do either of the above by 12/02/24.
>
> Note: 21.11.9 is the final planned release for the 21.11 LTS series, so I would urge
> extra caution about any changes which may introduce regressions. I would expect
> that most users will have moved or plan to move to a newer maintained LTS release
> at this point.
>
> I have sent the full list below, but I suggest authors to only rebase any important
> fixes and ensure that they test there are no regressions.
>
> You can find the a temporary work-in-progress branch of the coming 21.11.9
> release at:
>     https://github.com/kevintraynor/dpdk-stable
> It is recommended to backport on top of that to minimize further conflicts or
> misunderstandings.
>
> Some notes on stable backports:
>
> A backport should contain a reference to the DPDK main branch commit in it's
> commit message in the following fashion:
>     [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
>
> For example:
>     https://git.dpdk.org/dpdk-
> stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
>
> When sending the backported patch, please indicate the target branch in the subject
> line, as we have multiple branches, for example:
>     [PATCH 21.11] foo/bar: fix baz
>
> With git format-patch, this can be achieved by appending the parameter:
>     --subject-prefix='PATCH 21.11'
>
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
>
> FYI, branch 21.11 is located at tree:
>    https://git.dpdk.org/dpdk-stable
>
> Thanks.
>
> Kevin
>
> ---
> c5b531d6ee  Anoob Joseph     app/crypto-perf: fix session freeing
> 04dac73643  Ganapati Kundapura eventdev/crypto: fix enqueue count 4b04134cbb
> Ganapati Kundapura eventdev/crypto: fix failed events
> da73a2a0d1  Ganapati Kundapura eventdev/crypto: fix offset used while flushing
> events
> f442c04001  Ganapati Kundapura eventdev/crypto: fix overflow in circular buffer
> 5a0f64d84b  Hanumanth Pothula net/cnxk: fix configuring large Rx/Tx queues
> 59ceaa72d5  Harman Kalra     common/cnxk: fix part number for CN10K
> 31a28a99fd  Jiawen Wu        net/ngbe: add spinlock protection on YT PHY
> 5781638519  Nithin Dabilpuram common/cnxk: fix RQ mask config for CN10KB
> chip 3fe71706ab  Pavan Nikhilesh  event/cnxk: fix stale data in workslot
> 927cb43fe9  Pavan Nikhilesh  examples/l3fwd: fix port group mask with AltiVec
> 0f044b6681  Steve Yang       net/iavf: fix refine protocol header
> 0b241667cc  Steve Yang       net/iavf: fix tainted scalar
> b125c0e721  Steve Yang       net/iavf: fix tainted scalar
> cedb44dc87  Suanming Mou     common/mlx5: improve AES-XTS tweak capability
> check
> 7be74edb90  Honnappa Nagarahalli common/mlx5: use just sufficient barrier for
> Arm
> 7bdf7a13ae  Michael Baum     app/testpmd: fix encap/decap size calculation
> 6df1bc6b3b  Ashwin Sekhar T K mempool/cnxk: avoid hang when counting batch
> allocs
> 772e30281a  Rahul Bhansali   common/cnxk: fix CPT backpressure disable on LBK
> b37fe88a2c  Srujana Challa   event/cnxk: fix LMTST write for single event mode
> 92a16af450  Kaiwen Deng      net/iavf: fix virtchnl command called in interrupt
> 12011b11a3  Jiawen Wu        net/txgbe: adapt to MNG veto bit setting
> 21f702d556  Jiawen Wu        net/ngbe: fix link status in no LSC mode
> 659cfce01e  Jiawen Wu        net/ngbe: remove redundant codes
> 9749dffe23  Kaiwen Deng      net/ice: fix MAC type of E822 and E823
> 1c7a4d37e7  Harman Kalra     common/cnxk: fix mailbox timeout due to deadlock
> 5e170dd8b6  Jiawen Wu        net/txgbe: fix blocking system events
> 37ca457d3f  Bing Zhao        common/mlx5: fix obtaining IB device in LAG mode
> 9a518054b5  Mohammad Iqbal Ahmad examples/l3fwd: fix duplicate expression for
> default nexthop 61b52e7edb  Stephen Hemminger app/test: fix reference to master
> in bonding test
> 63bf81a617  Anatoly Burakov  test: fix named test macro 694e8e643d  Pavan
> Nikhilesh  event/cnxk: fix CASP usage for clang
> a6f639e079  Sunil Kumar Kori common/cnxk: fix BP threshold calculation
> 95a955e3e0  Amit Prakash Shukla dma/cnxk: fix device reconfigure
> 3dd3115078  Amit Prakash Shukla dma/cnxk: fix chunk buffer failure return code
> ba39a261a7  Vamsi Attunuru   dma/cnxk: fix completion ring tail wrap
> b3ddd649ad  Ashwin Sekhar T K mempool/cnxk: fix alloc from non-EAL threads
> 56fa6f92e9  Kiran Kumar K    common/cnxk: fix RSS key configuration
> 7752f14026  Rahul Bhansali   net/cnxk: fix Rx flush on CN10k
> 5d8c1f6253  Nithin Dabilpuram common/cnxk: check error in MAC address set
> a74c5001e9  Jiawen Wu        net/ngbe: add proper memory barriers in Rx
> 2ece3b7186  Bing Zhao        net/mlx5: fix flow workspace double free in Windows
> 9d91c3047d  Gowrishankar Muthukrishnan crypto/openssl: fix memory leaks in
> asym operations 166591931b  Stephen Hemminger pcapng: modify timestamp
> calculation
> 547f294357  Kumara Parameshwaran gro: fix reordering of packets
> 063cddfc74  Honnappa Nagarahalli rcu: use atomic operation on acked token
> df33fb53e4  Honnappa Nagarahalli rcu: fix acked token in debug log
> 02a2accb5f  Mário Kuka       net/bonding: fix flow count query
> 44a8635459  Hanumanth Pothula net/thunderx: fix DMAC control register update
> 48adbc80ba  Michael Baum     net/mlx5: remove GENEVE options length limitation
> 461c287ab5  Kumara Parameshwaran app/testpmd: fix GRO packets flush on
> timeout 3232c95d2c  Nithin Dabilpuram net/cnxk: fix indirect mbuf handling in Tx
> 26a6bda9df  Rahul Bhansali   net/cnxk: add cookies check for multi-segment
> offload
> 8ed5ca4dda  Rahul Bhansali   net/cnxk: fix mbuf fields in multi-segment Tx
> 48054ca384  Harman Kalra     common/cnxk: fix link config for SDP
> 87e4384d26  Bing Zhao        net/mlx5: fix condition of LACP miss flow
> 1cfb78d2c4  Shun Hao         net/mlx5: fix meter policy priority
> a78a1ed8ba  Gaoxiang Liu     net/bonding: fix failover time of LACP with mode 4
> ecf408d2aa  Bing Zhao        app/testpmd: fix indirect action flush
> b9a87346b0  Chengwen Feng    ethdev: fix strict aliasing in link up
> e82b0fe097  Venkat Kumar Ande net/axgbe: disable RRC for yellow carp devices
> ad12d08f05  Ganapati Kundapura eventdev/crypto: fix opaque field handling
> 4edbcc7b53  Luca Boccassi    bpf: disable on 32-bit x86
> b1d7112602  Jack Bond-Preston crypto/openssl: make per-QP cipher context
> clones
> 17d5bc6135  Jack Bond-Preston crypto/openssl: make per-QP auth context clones
> ee0fa7552a  Rohit Raj        net/dpaa: forbid MTU configuration for shared interface
> e2072ba1b0  Fabio Pricoco    net/ice/base: fix resource leak
> df44ba7a3c  Tomasz Wakula    net/ice/base: fix preparing PHY for timesync
> command
> 79be49dd2d  Jiawen Wu        net/ngbe: add special config for YT8531SH-CA PHY
> 2a3f42942a  Chengwen Feng    dma/hisilicon: remove support for HIP09 platform
> b23c5bd71a  Sivaprasad Tummala examples: fix queue ID restriction
> 4b97893816  Sivaprasad Tummala examples: fix lcore ID restriction 548de9091c
> Sivaprasad Tummala examples: fix port ID restriction
> abdabad636  Ciara Loftus     net/af_xdp: remove unused local statistic
> 4c2f14bc6d  Sunil Kumar Kori net/cnxk: fix xstats reset
> 4ad17a1c8f  Akhil Goyal      test/crypto: fix enqueue/dequeue callback case
> 046341575b  Gagandeep Singh  crypto/dpaa_sec: fix IPsec descriptor
> 97039941b2  Frank Du         net/af_xdp: parse UMEM map info from mempool
> 4edbcc7b53  Luca Boccassi    bpf: disable on 32-bit x86
> 6db358536f  Oleksandr Nahnybida pcapng: fix handling of chained mbufs
> 5c0f970c0d  Stephen Hemminger app/dumpcap: fix handling of jumbo frames
> 2d4505dc6d  Sunil Kumar Kori common/cnxk: fix MAC address change with active
> VF
> 6c3de40af8  Nithin Dabilpuram common/cnxk: fix inline CTX write
> 6f96937dad  Robin Jarry      ethdev: fix race on ports in telemetry endpoints
> b34fe66ea8  Bruce Richardson net/iavf: delay VF reset command b04b06f4cb
> Viacheslav Ovsiienko net/mlx5: fix flex item header length field translation
> 27918f0d53  Tim Martin       net/mlx5: fix real time counter reading from PCI BAR
> ebab0e8b22  Konstantin Ananyev examples/l3fwd: fix read beyond boundaries
> 0c5709824b  Nicolas Chautru  baseband/acc: fix ring memory allocation
> 251fdc592d  Brian Dooley     test/crypto: fix synchronous API calls
> 78dcdb821c  Shahaji Bhosle   net/bnxt/tf_core: fix WC TCAM multi-slice delete
> 8782e4de3e  Kishore Padmanabha net/bnxt/tf_ulp: fix parent child DB counters
> e6bf3256b9  Stephen Hemminger net/dpaa2: remove unnecessary check for null
> before free 3cddeba0ca  Alexander Kozyrev common/mlx5: fix error CQE handling
> for 128 bytes CQE
> 3c9a82fa6e  Bing Zhao        net/mlx5: fix Rx queue control management
> a7ae9ba1f8  Alexander Kozyrev net/mlx5: fix miniCQEs number calculation
> ffe827f38e  Andre Muezerie   rcu: fix implicit conversion in bit shift
> f8f294c66b  Bing Zhao        net/mlx5: fix shared Rx queue control release
> 916aa13f4a  Jiawen Wu        net/txgbe: fix a mass of interrupts
> 0151b80786  Stephen Hemminger test/security: fix IPv6 extension loop
> ebab0e8b22  Konstantin Ananyev examples/l3fwd: fix read beyond boundaries

RE: [EXTERNAL] please help backporting some patches to stable release 21.11.9

[Gowrishankar Muthukrishnan]

Hi Kevin,
> 9d91c3047d  Gowrishankar Muthukrishnan crypto/openssl: fix memory leaks

This is not applicable due to newer changes that were added later and not available in 21.11.

Thanks,
Gowrishankar

[PATCH 0/1] rcu: fix implicit conversion in bit shift

[Andre Muezerie]

Patch for 21.11

This is the backport of dev commit
https://github.com/DPDK/dpdk/commit/ffe827f38e6e0be8a307d7ef9c0e1347874f0af7

Andre Muezerie (1):
  rcu: fix implicit conversion in bit shift

 lib/rcu/rte_rcu_qsbr.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

-- 
2.47.0.vfs.0.3

[PATCH 1/1] rcu: fix implicit conversion in bit shift

[Andre Muezerie]

[ upstream commit ffe827f38e6e0be8a307d7ef9c0e1347874f0af7 ]

../lib/rcu/rte_rcu_qsbr.c(101): warning C4334: '<<': result of 32-bit
 shift implicitly converted to 64 bits (was 64-bit shift intended?)
../lib/rcu/rte_rcu_qsbr.c(107): warning C4334: '<<': result of 32-bit
 shift implicitly converted to 64 bits (was 64-bit shift intended?)
../lib/rcu/rte_rcu_qsbr.c(145): warning C4334: '<<': result of 32-bit
 shift implicitly converted to 64 bits (was 64-bit shift intended?)

These warnings are being issued by the MSVC compiler. Since the result is
being stored in a variable of type uint64_t, it makes sense to shift a
64-bit number instead of shifting a 32-bit number and then having the
compiler to convert the result implicitly to 64 bits.
UINT64_C was used in the fix as it is the portable way to define a 64-bit
constant (ULL suffix is architecture dependent).

From reading the code this is also a bugfix:
(1 << id), where id = thread_id & 0x3f, was wrong when thread_id > 0x1f.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
 lib/rcu/rte_rcu_qsbr.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/lib/rcu/rte_rcu_qsbr.c b/lib/rcu/rte_rcu_qsbr.c
index 7510db2f81..3f05ba0949 100644
--- a/lib/rcu/rte_rcu_qsbr.c
+++ b/lib/rcu/rte_rcu_qsbr.c
@@ -9,6 +9,7 @@
 #include <inttypes.h>
 #include <errno.h>
 
+#include <rte_bitops.h>
 #include <rte_common.h>
 #include <rte_log.h>
 #include <rte_memory.h>
@@ -108,11 +109,11 @@ rte_rcu_qsbr_thread_register(struct rte_rcu_qsbr *v, unsigned int thread_id)
 	/* Check if the thread is already registered */
 	old_bmap = __atomic_load_n(__RTE_QSBR_THRID_ARRAY_ELM(v, i),
 					__ATOMIC_RELAXED);
-	if (old_bmap & 1UL << id)
+	if (old_bmap & RTE_BIT64(id))
 		return 0;
 
 	do {
-		new_bmap = old_bmap | (1UL << id);
+		new_bmap = old_bmap | RTE_BIT64(id);
 		success = __atomic_compare_exchange(
 					__RTE_QSBR_THRID_ARRAY_ELM(v, i),
 					&old_bmap, &new_bmap, 0,
@@ -121,7 +122,7 @@ rte_rcu_qsbr_thread_register(struct rte_rcu_qsbr *v, unsigned int thread_id)
 		if (success)
 			__atomic_fetch_add(&v->num_threads,
 						1, __ATOMIC_RELAXED);
-		else if (old_bmap & (1UL << id))
+		else if (old_bmap & RTE_BIT64(id))
 			/* Someone else registered this thread.
 			 * Counter should not be incremented.
 			 */
@@ -160,11 +161,11 @@ rte_rcu_qsbr_thread_unregister(struct rte_rcu_qsbr *v, unsigned int thread_id)
 	/* Check if the thread is already unregistered */
 	old_bmap = __atomic_load_n(__RTE_QSBR_THRID_ARRAY_ELM(v, i),
 					__ATOMIC_RELAXED);
-	if (!(old_bmap & (1UL << id)))
+	if (!(old_bmap & RTE_BIT64(id)))
 		return 0;
 
 	do {
-		new_bmap = old_bmap & ~(1UL << id);
+		new_bmap = old_bmap & ~RTE_BIT64(id);
 		/* Make sure any loads of the shared data structure are
 		 * completed before removal of the thread from the list of
 		 * reporting threads.
@@ -177,7 +178,7 @@ rte_rcu_qsbr_thread_unregister(struct rte_rcu_qsbr *v, unsigned int thread_id)
 		if (success)
 			__atomic_fetch_sub(&v->num_threads,
 						1, __ATOMIC_RELAXED);
-		else if (!(old_bmap & (1UL << id)))
+		else if (!(old_bmap & RTE_BIT64(id)))
 			/* Someone else unregistered this thread.
 			 * Counter should not be incremented.
 			 */
@@ -238,7 +239,7 @@ rte_rcu_qsbr_dump(FILE *f, struct rte_rcu_qsbr *v)
 			t = __builtin_ctzl(bmap);
 			fprintf(f, "%u ", id + t);
 
-			bmap &= ~(1UL << t);
+			bmap &= ~RTE_BIT64(t);
 		}
 	}
 
@@ -265,7 +266,7 @@ rte_rcu_qsbr_dump(FILE *f, struct rte_rcu_qsbr *v)
 				__atomic_load_n(
 					&v->qsbr_cnt[id + t].lock_cnt,
 					__ATOMIC_RELAXED));
-			bmap &= ~(1UL << t);
+			bmap &= ~RTE_BIT64(t);
 		}
 	}
 
-- 
2.47.0.vfs.0.3

Re: please help backporting some patches to stable release 21.11.9

[Andre Muezerie]

On Wed, Nov 27, 2024 at 05:33:51PM +0000, Kevin Traynor wrote:
> Hi commit authors (and maintainers),
> 
> Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh
> I didn't apply following commits from DPDK main to 21.11
> stable branch, as conflicts or build errors occur.
> 
> Can authors check your patches in the following list and either:
>     - Backport your patches to the 21.11 branch, or
>     - Indicate that the patch should not be backported
> 
> Please do either of the above by 12/02/24.
> 
> Note: 21.11.9 is the final planned release for the 21.11 LTS series, so I would
> urge extra caution about any changes which may introduce regressions. I would
> expect that most users will have moved or plan to move to a newer maintained
> LTS release at this point.
> 
> I have sent the full list below, but I suggest authors to only rebase any
> important fixes and ensure that they test there are no regressions.
> 
> You can find the a temporary work-in-progress branch of the coming 21.11.9
> release at:
>     https://github.com/kevintraynor/dpdk-stable
> It is recommended to backport on top of that to minimize further conflicts or
> misunderstandings.
> 
> Some notes on stable backports:
> 
> A backport should contain a reference to the DPDK main branch commit
> in it's commit message in the following fashion:
>     [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
> 
> For example:
>     https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
> 
> When sending the backported patch, please indicate the target branch in the
> subject line, as we have multiple branches, for example:
>     [PATCH 21.11] foo/bar: fix baz
> 
> With git format-patch, this can be achieved by appending the parameter:
>     --subject-prefix='PATCH 21.11'
> 
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
> 
> FYI, branch 21.11 is located at tree:
>    https://git.dpdk.org/dpdk-stable
> 
> Thanks.
> 
> Kevin
> 
> ---
> c5b531d6ee  Anoob Joseph     app/crypto-perf: fix session freeing
> 04dac73643  Ganapati Kundapura eventdev/crypto: fix enqueue count
> 4b04134cbb  Ganapati Kundapura eventdev/crypto: fix failed events
> da73a2a0d1  Ganapati Kundapura eventdev/crypto: fix offset used while flushing events
> f442c04001  Ganapati Kundapura eventdev/crypto: fix overflow in circular buffer
> 5a0f64d84b  Hanumanth Pothula net/cnxk: fix configuring large Rx/Tx queues
> 59ceaa72d5  Harman Kalra     common/cnxk: fix part number for CN10K
> 31a28a99fd  Jiawen Wu        net/ngbe: add spinlock protection on YT PHY
> 5781638519  Nithin Dabilpuram common/cnxk: fix RQ mask config for CN10KB chip
> 3fe71706ab  Pavan Nikhilesh  event/cnxk: fix stale data in workslot
> 927cb43fe9  Pavan Nikhilesh  examples/l3fwd: fix port group mask with AltiVec
> 0f044b6681  Steve Yang       net/iavf: fix refine protocol header
> 0b241667cc  Steve Yang       net/iavf: fix tainted scalar
> b125c0e721  Steve Yang       net/iavf: fix tainted scalar
> cedb44dc87  Suanming Mou     common/mlx5: improve AES-XTS tweak capability check
> 7be74edb90  Honnappa Nagarahalli common/mlx5: use just sufficient barrier for Arm
> 7bdf7a13ae  Michael Baum     app/testpmd: fix encap/decap size calculation
> 6df1bc6b3b  Ashwin Sekhar T K mempool/cnxk: avoid hang when counting batch allocs
> 772e30281a  Rahul Bhansali   common/cnxk: fix CPT backpressure disable on LBK
> b37fe88a2c  Srujana Challa   event/cnxk: fix LMTST write for single event mode
> 92a16af450  Kaiwen Deng      net/iavf: fix virtchnl command called in interrupt
> 12011b11a3  Jiawen Wu        net/txgbe: adapt to MNG veto bit setting
> 21f702d556  Jiawen Wu        net/ngbe: fix link status in no LSC mode
> 659cfce01e  Jiawen Wu        net/ngbe: remove redundant codes
> 9749dffe23  Kaiwen Deng      net/ice: fix MAC type of E822 and E823
> 1c7a4d37e7  Harman Kalra     common/cnxk: fix mailbox timeout due to deadlock
> 5e170dd8b6  Jiawen Wu        net/txgbe: fix blocking system events
> 37ca457d3f  Bing Zhao        common/mlx5: fix obtaining IB device in LAG mode
> 9a518054b5  Mohammad Iqbal Ahmad examples/l3fwd: fix duplicate expression for default nexthop
> 61b52e7edb  Stephen Hemminger app/test: fix reference to master in bonding test
> 63bf81a617  Anatoly Burakov  test: fix named test macro
> 694e8e643d  Pavan Nikhilesh  event/cnxk: fix CASP usage for clang
> a6f639e079  Sunil Kumar Kori common/cnxk: fix BP threshold calculation
> 95a955e3e0  Amit Prakash Shukla dma/cnxk: fix device reconfigure
> 3dd3115078  Amit Prakash Shukla dma/cnxk: fix chunk buffer failure return code
> ba39a261a7  Vamsi Attunuru   dma/cnxk: fix completion ring tail wrap
> b3ddd649ad  Ashwin Sekhar T K mempool/cnxk: fix alloc from non-EAL threads
> 56fa6f92e9  Kiran Kumar K    common/cnxk: fix RSS key configuration
> 7752f14026  Rahul Bhansali   net/cnxk: fix Rx flush on CN10k
> 5d8c1f6253  Nithin Dabilpuram common/cnxk: check error in MAC address set
> a74c5001e9  Jiawen Wu        net/ngbe: add proper memory barriers in Rx
> 2ece3b7186  Bing Zhao        net/mlx5: fix flow workspace double free in Windows
> 9d91c3047d  Gowrishankar Muthukrishnan crypto/openssl: fix memory leaks in asym operations
> 166591931b  Stephen Hemminger pcapng: modify timestamp calculation
> 547f294357  Kumara Parameshwaran gro: fix reordering of packets
> 063cddfc74  Honnappa Nagarahalli rcu: use atomic operation on acked token
> df33fb53e4  Honnappa Nagarahalli rcu: fix acked token in debug log
> 02a2accb5f  Mário Kuka       net/bonding: fix flow count query
> 44a8635459  Hanumanth Pothula net/thunderx: fix DMAC control register update
> 48adbc80ba  Michael Baum     net/mlx5: remove GENEVE options length limitation
> 461c287ab5  Kumara Parameshwaran app/testpmd: fix GRO packets flush on timeout
> 3232c95d2c  Nithin Dabilpuram net/cnxk: fix indirect mbuf handling in Tx
> 26a6bda9df  Rahul Bhansali   net/cnxk: add cookies check for multi-segment offload
> 8ed5ca4dda  Rahul Bhansali   net/cnxk: fix mbuf fields in multi-segment Tx
> 48054ca384  Harman Kalra     common/cnxk: fix link config for SDP
> 87e4384d26  Bing Zhao        net/mlx5: fix condition of LACP miss flow
> 1cfb78d2c4  Shun Hao         net/mlx5: fix meter policy priority
> a78a1ed8ba  Gaoxiang Liu     net/bonding: fix failover time of LACP with mode 4
> ecf408d2aa  Bing Zhao        app/testpmd: fix indirect action flush
> b9a87346b0  Chengwen Feng    ethdev: fix strict aliasing in link up
> e82b0fe097  Venkat Kumar Ande net/axgbe: disable RRC for yellow carp devices
> ad12d08f05  Ganapati Kundapura eventdev/crypto: fix opaque field handling
> 4edbcc7b53  Luca Boccassi    bpf: disable on 32-bit x86
> b1d7112602  Jack Bond-Preston crypto/openssl: make per-QP cipher context clones
> 17d5bc6135  Jack Bond-Preston crypto/openssl: make per-QP auth context clones
> ee0fa7552a  Rohit Raj        net/dpaa: forbid MTU configuration for shared interface
> e2072ba1b0  Fabio Pricoco    net/ice/base: fix resource leak
> df44ba7a3c  Tomasz Wakula    net/ice/base: fix preparing PHY for timesync command
> 79be49dd2d  Jiawen Wu        net/ngbe: add special config for YT8531SH-CA PHY
> 2a3f42942a  Chengwen Feng    dma/hisilicon: remove support for HIP09 platform
> b23c5bd71a  Sivaprasad Tummala examples: fix queue ID restriction
> 4b97893816  Sivaprasad Tummala examples: fix lcore ID restriction
> 548de9091c  Sivaprasad Tummala examples: fix port ID restriction
> abdabad636  Ciara Loftus     net/af_xdp: remove unused local statistic
> 4c2f14bc6d  Sunil Kumar Kori net/cnxk: fix xstats reset
> 4ad17a1c8f  Akhil Goyal      test/crypto: fix enqueue/dequeue callback case
> 046341575b  Gagandeep Singh  crypto/dpaa_sec: fix IPsec descriptor
> 97039941b2  Frank Du         net/af_xdp: parse UMEM map info from mempool
> 4edbcc7b53  Luca Boccassi    bpf: disable on 32-bit x86
> 6db358536f  Oleksandr Nahnybida pcapng: fix handling of chained mbufs
> 5c0f970c0d  Stephen Hemminger app/dumpcap: fix handling of jumbo frames
> 2d4505dc6d  Sunil Kumar Kori common/cnxk: fix MAC address change with active VF
> 6c3de40af8  Nithin Dabilpuram common/cnxk: fix inline CTX write
> 6f96937dad  Robin Jarry      ethdev: fix race on ports in telemetry endpoints
> b34fe66ea8  Bruce Richardson net/iavf: delay VF reset command
> b04b06f4cb  Viacheslav Ovsiienko net/mlx5: fix flex item header length field translation
> 27918f0d53  Tim Martin       net/mlx5: fix real time counter reading from PCI BAR
> ebab0e8b22  Konstantin Ananyev examples/l3fwd: fix read beyond boundaries
> 0c5709824b  Nicolas Chautru  baseband/acc: fix ring memory allocation
> 251fdc592d  Brian Dooley     test/crypto: fix synchronous API calls
> 78dcdb821c  Shahaji Bhosle   net/bnxt/tf_core: fix WC TCAM multi-slice delete
> 8782e4de3e  Kishore Padmanabha net/bnxt/tf_ulp: fix parent child DB counters
> e6bf3256b9  Stephen Hemminger net/dpaa2: remove unnecessary check for null before free
> 3cddeba0ca  Alexander Kozyrev common/mlx5: fix error CQE handling for 128 bytes CQE
> 3c9a82fa6e  Bing Zhao        net/mlx5: fix Rx queue control management
> a7ae9ba1f8  Alexander Kozyrev net/mlx5: fix miniCQEs number calculation
> ffe827f38e  Andre Muezerie   rcu: fix implicit conversion in bit shift
> f8f294c66b  Bing Zhao        net/mlx5: fix shared Rx queue control release
> 916aa13f4a  Jiawen Wu        net/txgbe: fix a mass of interrupts
> 0151b80786  Stephen Hemminger test/security: fix IPv6 extension loop
> ebab0e8b22  Konstantin Ananyev examples/l3fwd: fix read beyond boundaries

Hi Kevin,

I just sent the updated 21.11 patch for

ffe827f38e  Andre Muezerie   rcu: fix implicit conversion in bit shift

to stable@dpdk.org. Let me know if anything else is needed for it.
Regards,

Andre

Re: please help backporting some patches to stable release 21.11.9

[Kevin Traynor]

On 02/12/2024 07:03, Tummala, Sivaprasad wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
> 
> Hi Kevin,
> 
> The below patches are specific to example applications and do not affect core functionality or dependencies
> that would require backporting to previous versions. There is no need to backport them.
> 
> b23c5bd71a  Sivaprasad Tummala examples: fix queue ID restriction
> 4b97893816  Sivaprasad Tummala examples: fix lcore ID restriction
> 548de9091c  Sivaprasad Tummala examples: fix port ID restriction
> 

Thanks for your analysis. Dropped them from the failed to backport list.
Kevin.

>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Wednesday, November 27, 2024 11:04 PM
>> To: dpdk stable <stable@dpdk.org>
>> Cc: Abhinandan Gujjar <abhinandan.gujjar@intel.com>; Ajit Khaparde
>> <ajit.khaparde@broadcom.com>; Akhil Goyal <gakhil@marvell.com>; Alexander
>> Kozyrev <akozyrev@nvidia.com>; Amit Prakash Shukla
>> <amitprakashs@marvell.com>; Anatoly Burakov <anatoly.burakov@intel.com>;
>> Andre Muezerie <andremue@linux.microsoft.com>; Anoob Joseph
>> <anoobj@marvell.com>; Ashwin Sekhar T K <asekhar@marvell.com>; Bing Zhao
>> <bingz@nvidia.com>; Brian Dooley <brian.dooley@intel.com>; Bruce Richardson
>> <bruce.richardson@intel.com>; Chengwen Feng <fengchengwen@huawei.com>;
>> Ciara Loftus <ciara.loftus@intel.com>; Ciara Power <ciara.power@intel.com>;
>> Conor Walsh <conor.walsh@intel.com>; Dariusz Sosnowski
>> <dsosnowski@nvidia.com>; David Marchand <david.marchand@redhat.com>;
>> Dengdui Huang <huangdengdui@huawei.com>; Fabio Pricoco
>> <fabio.pricoco@intel.com>; Yigit, Ferruh <Ferruh.Yigit@amd.com>; Frank Du
>> <frank.du@intel.com>; Gagandeep Singh <g.singh@nxp.com>; Ganapati
>> Kundapura <ganapati.kundapura@intel.com>; Gaoxiang Liu
>> <liugaoxiang@huawei.com>; Gowrishankar Muthukrishnan
>> <gmuthukrishn@marvell.com>; Hanumanth Pothula <hpothula@marvell.com>;
>> Harman Kalra <hkalra@marvell.com>; Hemant Agrawal
>> <hemant.agrawal@nxp.com>; Hongbo Li <hongbox.li@intel.com>; Honnappa
>> Nagarahalli <honnappa.nagarahalli@arm.com>; Ian Stokes
>> <ian.stokes@intel.com>; Jack Bond-Preston <jack.bond-preston@foss.arm.com>;
>> Jerin Jacob <jerinj@marvell.com>; Jiawen Wu <jiawenwu@trustnetic.com>; Jiayu
>> Hu <hujiayu.hu@foxmail.com>; Kai Ji <kai.ji@intel.com>; Kaiwen Deng
>> <kaiwenx.deng@intel.com>; Kiran Kumar K <kirankumark@marvell.com>; Kishore
>> Padmanabha <kishore.padmanabha@broadcom.com>; Konstantin Ananyev
>> <konstantin.ananyev@huawei.com>; Kumara Parameshwaran
>> <kumaraparamesh92@gmail.com>; Luca Boccassi <bluca@debian.org>; Mário
>> Kuka <kuka@cesnet.cz>; Matan Azrad <matan@nvidia.com>; Maxime Coquelin
>> <maxime.coquelin@redhat.com>; Michael Baum <michaelba@nvidia.com>; Mike
>> Baucom <michael.baucom@broadcom.com>; Mohammad Iqbal Ahmad
>> <mahmad@marvell.com>; Morten Brørup <mb@smartsharesystems.com>;
>> Nathan Brown <nathan.brown@arm.com>; Nicolas Chautru
>> <nicolas.chautru@intel.com>; Nithin Dabilpuram <ndabilpuram@marvell.com>; Ola
>> Liljedahl <ola.liljedahl@arm.com>; Oleksandr Nahnybida
>> <oleksandrn@interfacemasters.com>; Ori Kam <orika@nvidia.com>; Pavan
>> Nikhilesh <pbhagavatula@marvell.com>; Qi Zhang <qi.z.zhang@intel.com>; Rahul
>> Bhansali <rbhansali@marvell.com>; Randy Schacher
>> <stuart.schacher@broadcom.com>; Robin Jarry <rjarry@redhat.com>; Rohit Raj
>> <rohit.raj@nxp.com>; Ruifeng Wang <ruifeng.wang@arm.com>; Sebastian, Selwin
>> <Selwin.Sebastian@amd.com>; Shahaji Bhosle <sbhosle@broadcom.com>; Shijith
>> Thotton <sthotton@marvell.com>; Shuanglin Wang
>> <shuanglin.wang@broadcom.com>; Shun Hao <shunh@nvidia.com>; Tummala,
>> Sivaprasad <Sivaprasad.Tummala@amd.com>; Sriharsha Basavapatna
>> <sriharsha.basavapatna@broadcom.com>; Srujana Challa
>> <schalla@marvell.com>; Stephen Hemminger <stephen@networkplumber.org>;
>> Steve Yang <stevex.yang@intel.com>; Suanming Mou <suanmingm@nvidia.com>;
>> Sunil Kumar Kori <skori@marvell.com>; Tianli Lai <laitianli@tom.com>; Tim Martin
>> <timothym@nvidia.com>; Tomasz Wakula <tomaszx.wakula@intel.com>; Tyler
>> Retzlaff <roretzla@linux.microsoft.com>; Vamsi Attunuru
>> <vattunuru@marvell.com>; Vanshika Shukla <vanshika.shukla@nxp.com>; Ande,
>> Venkat Kumar <VenkatKumar.Ande@amd.com>; Viacheslav Ovsiienko
>> <viacheslavo@nvidia.com>; Wathsala Vithanage <wathsala.vithanage@arm.com>
>> Subject: please help backporting some patches to stable release 21.11.9
>>
>> Caution: This message originated from an External Source. Use proper caution
>> when opening attachments, clicking links, or responding.
>>
>>
>> Hi commit authors (and maintainers),
>>
>> Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh I
>> didn't apply following commits from DPDK main to 21.11 stable branch, as conflicts
>> or build errors occur.
>>
>> Can authors check your patches in the following list and either:
>>     - Backport your patches to the 21.11 branch, or
>>     - Indicate that the patch should not be backported
>>
>> Please do either of the above by 12/02/24.
>>
>> Note: 21.11.9 is the final planned release for the 21.11 LTS series, so I would urge
>> extra caution about any changes which may introduce regressions. I would expect
>> that most users will have moved or plan to move to a newer maintained LTS release
>> at this point.
>>
>> I have sent the full list below, but I suggest authors to only rebase any important
>> fixes and ensure that they test there are no regressions.
>>
>> You can find the a temporary work-in-progress branch of the coming 21.11.9
>> release at:
>>     https://github.com/kevintraynor/dpdk-stable
>> It is recommended to backport on top of that to minimize further conflicts or
>> misunderstandings.
>>
>> Some notes on stable backports:
>>
>> A backport should contain a reference to the DPDK main branch commit in it's
>> commit message in the following fashion:
>>     [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
>>
>> For example:
>>     https://git.dpdk.org/dpdk-
>> stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
>>
>> When sending the backported patch, please indicate the target branch in the subject
>> line, as we have multiple branches, for example:
>>     [PATCH 21.11] foo/bar: fix baz
>>
>> With git format-patch, this can be achieved by appending the parameter:
>>     --subject-prefix='PATCH 21.11'
>>
>> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
>>
>> FYI, branch 21.11 is located at tree:
>>    https://git.dpdk.org/dpdk-stable
>>
>> Thanks.
>>
>> Kevin
>>
>> ---
>> c5b531d6ee  Anoob Joseph     app/crypto-perf: fix session freeing
>> 04dac73643  Ganapati Kundapura eventdev/crypto: fix enqueue count 4b04134cbb
>> Ganapati Kundapura eventdev/crypto: fix failed events
>> da73a2a0d1  Ganapati Kundapura eventdev/crypto: fix offset used while flushing
>> events
>> f442c04001  Ganapati Kundapura eventdev/crypto: fix overflow in circular buffer
>> 5a0f64d84b  Hanumanth Pothula net/cnxk: fix configuring large Rx/Tx queues
>> 59ceaa72d5  Harman Kalra     common/cnxk: fix part number for CN10K
>> 31a28a99fd  Jiawen Wu        net/ngbe: add spinlock protection on YT PHY
>> 5781638519  Nithin Dabilpuram common/cnxk: fix RQ mask config for CN10KB
>> chip 3fe71706ab  Pavan Nikhilesh  event/cnxk: fix stale data in workslot
>> 927cb43fe9  Pavan Nikhilesh  examples/l3fwd: fix port group mask with AltiVec
>> 0f044b6681  Steve Yang       net/iavf: fix refine protocol header
>> 0b241667cc  Steve Yang       net/iavf: fix tainted scalar
>> b125c0e721  Steve Yang       net/iavf: fix tainted scalar
>> cedb44dc87  Suanming Mou     common/mlx5: improve AES-XTS tweak capability
>> check
>> 7be74edb90  Honnappa Nagarahalli common/mlx5: use just sufficient barrier for
>> Arm
>> 7bdf7a13ae  Michael Baum     app/testpmd: fix encap/decap size calculation
>> 6df1bc6b3b  Ashwin Sekhar T K mempool/cnxk: avoid hang when counting batch
>> allocs
>> 772e30281a  Rahul Bhansali   common/cnxk: fix CPT backpressure disable on LBK
>> b37fe88a2c  Srujana Challa   event/cnxk: fix LMTST write for single event mode
>> 92a16af450  Kaiwen Deng      net/iavf: fix virtchnl command called in interrupt
>> 12011b11a3  Jiawen Wu        net/txgbe: adapt to MNG veto bit setting
>> 21f702d556  Jiawen Wu        net/ngbe: fix link status in no LSC mode
>> 659cfce01e  Jiawen Wu        net/ngbe: remove redundant codes
>> 9749dffe23  Kaiwen Deng      net/ice: fix MAC type of E822 and E823
>> 1c7a4d37e7  Harman Kalra     common/cnxk: fix mailbox timeout due to deadlock
>> 5e170dd8b6  Jiawen Wu        net/txgbe: fix blocking system events
>> 37ca457d3f  Bing Zhao        common/mlx5: fix obtaining IB device in LAG mode
>> 9a518054b5  Mohammad Iqbal Ahmad examples/l3fwd: fix duplicate expression for
>> default nexthop 61b52e7edb  Stephen Hemminger app/test: fix reference to master
>> in bonding test
>> 63bf81a617  Anatoly Burakov  test: fix named test macro 694e8e643d  Pavan
>> Nikhilesh  event/cnxk: fix CASP usage for clang
>> a6f639e079  Sunil Kumar Kori common/cnxk: fix BP threshold calculation
>> 95a955e3e0  Amit Prakash Shukla dma/cnxk: fix device reconfigure
>> 3dd3115078  Amit Prakash Shukla dma/cnxk: fix chunk buffer failure return code
>> ba39a261a7  Vamsi Attunuru   dma/cnxk: fix completion ring tail wrap
>> b3ddd649ad  Ashwin Sekhar T K mempool/cnxk: fix alloc from non-EAL threads
>> 56fa6f92e9  Kiran Kumar K    common/cnxk: fix RSS key configuration
>> 7752f14026  Rahul Bhansali   net/cnxk: fix Rx flush on CN10k
>> 5d8c1f6253  Nithin Dabilpuram common/cnxk: check error in MAC address set
>> a74c5001e9  Jiawen Wu        net/ngbe: add proper memory barriers in Rx
>> 2ece3b7186  Bing Zhao        net/mlx5: fix flow workspace double free in Windows
>> 9d91c3047d  Gowrishankar Muthukrishnan crypto/openssl: fix memory leaks in
>> asym operations 166591931b  Stephen Hemminger pcapng: modify timestamp
>> calculation
>> 547f294357  Kumara Parameshwaran gro: fix reordering of packets
>> 063cddfc74  Honnappa Nagarahalli rcu: use atomic operation on acked token
>> df33fb53e4  Honnappa Nagarahalli rcu: fix acked token in debug log
>> 02a2accb5f  Mário Kuka       net/bonding: fix flow count query
>> 44a8635459  Hanumanth Pothula net/thunderx: fix DMAC control register update
>> 48adbc80ba  Michael Baum     net/mlx5: remove GENEVE options length limitation
>> 461c287ab5  Kumara Parameshwaran app/testpmd: fix GRO packets flush on
>> timeout 3232c95d2c  Nithin Dabilpuram net/cnxk: fix indirect mbuf handling in Tx
>> 26a6bda9df  Rahul Bhansali   net/cnxk: add cookies check for multi-segment
>> offload
>> 8ed5ca4dda  Rahul Bhansali   net/cnxk: fix mbuf fields in multi-segment Tx
>> 48054ca384  Harman Kalra     common/cnxk: fix link config for SDP
>> 87e4384d26  Bing Zhao        net/mlx5: fix condition of LACP miss flow
>> 1cfb78d2c4  Shun Hao         net/mlx5: fix meter policy priority
>> a78a1ed8ba  Gaoxiang Liu     net/bonding: fix failover time of LACP with mode 4
>> ecf408d2aa  Bing Zhao        app/testpmd: fix indirect action flush
>> b9a87346b0  Chengwen Feng    ethdev: fix strict aliasing in link up
>> e82b0fe097  Venkat Kumar Ande net/axgbe: disable RRC for yellow carp devices
>> ad12d08f05  Ganapati Kundapura eventdev/crypto: fix opaque field handling
>> 4edbcc7b53  Luca Boccassi    bpf: disable on 32-bit x86
>> b1d7112602  Jack Bond-Preston crypto/openssl: make per-QP cipher context
>> clones
>> 17d5bc6135  Jack Bond-Preston crypto/openssl: make per-QP auth context clones
>> ee0fa7552a  Rohit Raj        net/dpaa: forbid MTU configuration for shared interface
>> e2072ba1b0  Fabio Pricoco    net/ice/base: fix resource leak
>> df44ba7a3c  Tomasz Wakula    net/ice/base: fix preparing PHY for timesync
>> command
>> 79be49dd2d  Jiawen Wu        net/ngbe: add special config for YT8531SH-CA PHY
>> 2a3f42942a  Chengwen Feng    dma/hisilicon: remove support for HIP09 platform
>> b23c5bd71a  Sivaprasad Tummala examples: fix queue ID restriction
>> 4b97893816  Sivaprasad Tummala examples: fix lcore ID restriction 548de9091c
>> Sivaprasad Tummala examples: fix port ID restriction
>> abdabad636  Ciara Loftus     net/af_xdp: remove unused local statistic
>> 4c2f14bc6d  Sunil Kumar Kori net/cnxk: fix xstats reset
>> 4ad17a1c8f  Akhil Goyal      test/crypto: fix enqueue/dequeue callback case
>> 046341575b  Gagandeep Singh  crypto/dpaa_sec: fix IPsec descriptor
>> 97039941b2  Frank Du         net/af_xdp: parse UMEM map info from mempool
>> 4edbcc7b53  Luca Boccassi    bpf: disable on 32-bit x86
>> 6db358536f  Oleksandr Nahnybida pcapng: fix handling of chained mbufs
>> 5c0f970c0d  Stephen Hemminger app/dumpcap: fix handling of jumbo frames
>> 2d4505dc6d  Sunil Kumar Kori common/cnxk: fix MAC address change with active
>> VF
>> 6c3de40af8  Nithin Dabilpuram common/cnxk: fix inline CTX write
>> 6f96937dad  Robin Jarry      ethdev: fix race on ports in telemetry endpoints
>> b34fe66ea8  Bruce Richardson net/iavf: delay VF reset command b04b06f4cb
>> Viacheslav Ovsiienko net/mlx5: fix flex item header length field translation
>> 27918f0d53  Tim Martin       net/mlx5: fix real time counter reading from PCI BAR
>> ebab0e8b22  Konstantin Ananyev examples/l3fwd: fix read beyond boundaries
>> 0c5709824b  Nicolas Chautru  baseband/acc: fix ring memory allocation
>> 251fdc592d  Brian Dooley     test/crypto: fix synchronous API calls
>> 78dcdb821c  Shahaji Bhosle   net/bnxt/tf_core: fix WC TCAM multi-slice delete
>> 8782e4de3e  Kishore Padmanabha net/bnxt/tf_ulp: fix parent child DB counters
>> e6bf3256b9  Stephen Hemminger net/dpaa2: remove unnecessary check for null
>> before free 3cddeba0ca  Alexander Kozyrev common/mlx5: fix error CQE handling
>> for 128 bytes CQE
>> 3c9a82fa6e  Bing Zhao        net/mlx5: fix Rx queue control management
>> a7ae9ba1f8  Alexander Kozyrev net/mlx5: fix miniCQEs number calculation
>> ffe827f38e  Andre Muezerie   rcu: fix implicit conversion in bit shift
>> f8f294c66b  Bing Zhao        net/mlx5: fix shared Rx queue control release
>> 916aa13f4a  Jiawen Wu        net/txgbe: fix a mass of interrupts
>> 0151b80786  Stephen Hemminger test/security: fix IPv6 extension loop
>> ebab0e8b22  Konstantin Ananyev examples/l3fwd: fix read beyond boundaries
> 

Re: [EXTERNAL] please help backporting some patches to stable release 21.11.9

[Kevin Traynor]

On 02/12/2024 08:30, Gowrishankar Muthukrishnan wrote:
> Hi Kevin,
>> 9d91c3047d  Gowrishankar Muthukrishnan crypto/openssl: fix memory leaks
> 
> This is not applicable due to newer changes that were added later and not available in 21.11.
> 

Thanks Gowri. Dropped from failed to backport list.
Kevin.

> Thanks,
> Gowrishankar

Re: [PATCH 1/1] rcu: fix implicit conversion in bit shift

[Kevin Traynor]

On 02/12/2024 18:46, Andre Muezerie wrote:
> [ upstream commit ffe827f38e6e0be8a307d7ef9c0e1347874f0af7 ]
> 
> ../lib/rcu/rte_rcu_qsbr.c(101): warning C4334: '<<': result of 32-bit
>  shift implicitly converted to 64 bits (was 64-bit shift intended?)
> ../lib/rcu/rte_rcu_qsbr.c(107): warning C4334: '<<': result of 32-bit
>  shift implicitly converted to 64 bits (was 64-bit shift intended?)
> ../lib/rcu/rte_rcu_qsbr.c(145): warning C4334: '<<': result of 32-bit
>  shift implicitly converted to 64 bits (was 64-bit shift intended?)
> 
> These warnings are being issued by the MSVC compiler. Since the result is
> being stored in a variable of type uint64_t, it makes sense to shift a
> 64-bit number instead of shifting a 32-bit number and then having the
> compiler to convert the result implicitly to 64 bits.
> UINT64_C was used in the fix as it is the portable way to define a 64-bit
> constant (ULL suffix is architecture dependent).
> 
> From reading the code this is also a bugfix:
> (1 << id), where id = thread_id & 0x3f, was wrong when thread_id > 0x1f.
> 
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> ---
>  lib/rcu/rte_rcu_qsbr.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 

Hi Andre, thanks for rebasing. This is now applied and pushed to 21.11
branch.
Kevin.