From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47A1643351 for ; Fri, 17 Nov 2023 10:00:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED7B240648; Fri, 17 Nov 2023 10:00:58 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 2C17B40273 for ; Fri, 17 Nov 2023 10:00:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700211657; x=1731747657; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=yHx2Mo2EukK1rlhjzmJKuwERFyKi3z5N3uC1u+ICEMY=; b=bgfka8vvThKXS8RGfnQ9UWhEAF+X8RAuKpvgTvUMwzDfrrHxMF98+3Eh b8a1eTu4ozhg6gpf7aoO+Yr04mOYnT4i/J0vMtKA8NK5s0TmQ+6Ksyy/F ktfFSTgUk10s6wMSEswfMqSbU6HD+1cPQrEe3VJi3/rVTydC8i2K+V2cf fJsS840lqKOIuL8JB1ife8VCBaKSCKJt94aWRr+qRTtL94u/04/YVqQR5 NDS9JwxkpFfJjjVph63HqbPnl/NmzOqt7VeRLGCcsQcGBH+eOuPWmoHxf 2auNNuyuQ3lj/MR56LOwy9KCzxNl3i2NWKicKnLqniFaLIcIvsg3a48++ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10896"; a="395191053" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="395191053" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 01:00:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="13853787" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Nov 2023 01:00:53 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 17 Nov 2023 01:00:50 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 17 Nov 2023 01:00:50 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Fri, 17 Nov 2023 01:00:50 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Fri, 17 Nov 2023 01:00:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iAwNTLT64JMmz6I9qYm6JHd2e6VHHiDLi0CcX7wuazJU8CFGJIiX+eQi+kzQ6qlCUh4n+Uxx1Bpygdozv07bPnAcNpi5EIzFjExEQofk/i1ebAyVnTrJsSlKfra5J4IXG/HLrfkCDbUavBlIl3smO2L2si6rVMBmXM9kGwgygL2M7b22eQlkpUfI/hJw4vmu4QFrt/y07DjT2dy+bja2wzgDCxjeB9ppLy5RmIKwaXZ39g6V5Rn20QjczZ+cFukF2Pbt6KnuqI3wmpBGj7XNg46rZltwLku9Kpw6As7gsOESvuu9RfVDVOXsvZpfKUMlPKTku2WDOzXelE938rCb3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=83a7ADocyXAtUI6n2JtY8rNGiLfUlIUtOEnLmiMGl6A=; b=D6hCM6wHxEfzT+lJSPxVtsXKCjsI+l2uO8hY53g7zqRsP4PV3T6yzy66vv93X+lclivEqJ1ItS3C27tRCqZg1NuZJDRSQkLr98s2CN5NVXTi6etp/5SMNdFfA315ReA653E2smKnQLPEgVQqzBQb1lf9/ijaG5eYu3JlUWt6aVqEsD877CcoEim5LZudc9/U0h7+C73dFUo2jWchZptNUarJ0nzx8D7bQlv7vkt02jdacfdGdu8Of8zBk/Ub4J/MayKKNxjKP+GJGLGF+sgQzW++dfGeIt/xIGW1+k6/W5IZsecr4qFhJOeacDVeMpS8r5SVZCf2szY3TnG0ZGANBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BL1PR11MB5554.namprd11.prod.outlook.com (2603:10b6:208:31d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.23; Fri, 17 Nov 2023 09:00:42 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7002.021; Fri, 17 Nov 2023 09:00:42 +0000 From: "Richardson, Bruce" To: Kevin Traynor , Srikanth Yalavarthi CC: dpdk stable Subject: RE: patch 'build: add libarchive to optional external dependencies' has been queued to stable release 21.11.6 Thread-Topic: patch 'build: add libarchive to optional external dependencies' has been queued to stable release 21.11.6 Thread-Index: AQHaGJBRSN4PkcrK9k6qolTG90HIB7B+NyKA Date: Fri, 17 Nov 2023 09:00:42 +0000 Message-ID: References: <20231116132348.557257-1-ktraynor@redhat.com> <20231116132348.557257-43-ktraynor@redhat.com> In-Reply-To: <20231116132348.557257-43-ktraynor@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS0PR11MB7309:EE_|BL1PR11MB5554:EE_ x-ms-office365-filtering-correlation-id: bb4c297d-9f14-45e5-a5e2-08dbe74bada9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5vBK9JlgxIrTpT4kL92BAi+x9h8qQByUyHcRmJVV4LAU7Mb70nLm72fggXwzI3m7vDqPmf6k+89fntNMsEiNbeJrQYkTPdeP3Bsw/GKKW/HRCkZq96IkCCw2U4YZbha2IADQN4LKWBeHSSEQfgl4q3YmLnovnXzxBSdebs80oNjzJ+4mNBUp61iNQxq/AA2dXmewJu3ua7YyIM4c/jFbalihJPGlSs+4V63E+Sz3SvT+eGOgEkCGn+cwwyks0UxHKiEBniSKVDOcGF2wOGOnmZkGt3fxiJvmOoRIZT4Cw5BdpJjid7RLvSQPFZ+hWWjwW0s++izGH+plmpNJmIaN4D297XHhOJWbgjW8k0BZQwtXFnaXgE/i5uG9OsLerPbC+pc1wkuZeTJ4HOwgjfPRIFJrreip6se/9uW1RHRZnM9Ffr6I4jRA3r1qDo13lDpwbpiCayuJqJTpFk9GuB15fCuahnqh20RQZqg6jDFJx25lp/BG2qu3BOIw9aFuCt2mNwUxvDppVia1rd5gbmfiYTxmtWZa+ornxa+tl7hVRhWfJ/66++vuSt7MKUYj2uZHkVMSLugJZflRJcTbJYetotpwWpoXzYXzCaOMc86PFW+NN81JoB7/Px/sU7KlecpTOBzAC4p/pT4uxWYCvYOlD90Xi1zmQZNqbSuTAz/PAI2uoTQwx3UmKPn3qnLzi/Oy x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39860400002)(366004)(346002)(376002)(136003)(230173577357003)(230273577357003)(230922051799003)(1800799009)(451199024)(186009)(64100799003)(9686003)(966005)(478600001)(38070700009)(4001150100001)(2906002)(82960400001)(122000001)(41300700001)(38100700002)(76116006)(33656002)(83380400001)(66946007)(110136005)(66556008)(66476007)(66446008)(64756008)(86362001)(26005)(316002)(5660300002)(8936002)(52536014)(8676002)(4326008)(7696005)(53546011)(6506007)(55016003)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nnD+ybUYz3LnbCOBZ1cLALjxfV4Z7Vfq0KNGLE8qBFY+/Ecy66l7JkxO6Dht?= =?us-ascii?Q?UdODvhj8uoQOGjAc4l7LY9+9oy71kdCa9PUwSHZ33wA1nuPbMxqZH1KMZ26J?= =?us-ascii?Q?N5U2gT5sQgYF3QpP+j6+E8JTEaImrfWLoCDSXIRESNi+CkYLTNGWIXyhlDim?= =?us-ascii?Q?KULQfE03TYo8nfjn3HPKC9UX5+952XTQ6aSP38vlcBgXlypgY0ksA2pInqoy?= =?us-ascii?Q?6/zA8sKqjPLcE251eia8qUA0SbmNmweEyQ8L0nz1GneNBvdtTdo9U5uqyyPb?= =?us-ascii?Q?GQJMii1BopUVTNslLMhDpCNim26zG/vP4b4pGY+G7FM10z2YEGWobbHvALRE?= =?us-ascii?Q?qfmjX0vmaWdzDRCui6ZqB2Dj1rX2lbm6Z9i/P6nNhjQV9qroZ96hwv0j1Nhu?= =?us-ascii?Q?3X+3X/a5fUxpcQN2H+Gxa4RUwCFGH4GTizTaoRSLQYtOIm4rAkKU0/qTPDt0?= =?us-ascii?Q?LHy3NDRnOJX43mFiYXA6LUafY8jh7NUMRdLlnaUtUWP8AvOibaY4lJmvsz7m?= =?us-ascii?Q?In4FcDKrujV54cwGO+3hSvsgHcBTjUdo50Itoc4k38WG9UnaUynOLvQQLPDK?= =?us-ascii?Q?f5dyzzUkFckMjZ37R2vsNuPYJKOyhaVMOIHjeSCAKO1PeFhKXElXGYu3lv3p?= =?us-ascii?Q?Puz7lTc9gSjnBcOvrrxzgyZ3+ZBwTuUawcuoah6szNXSHfmaTsASU1ZCD1LH?= =?us-ascii?Q?obM5+TwrDHCYll0z5YHvXan6XfScY1J1dO2BikwrpFJcnnlOg1YCB0jvkgoY?= =?us-ascii?Q?eU8YIRMpQhZZI8nK5xLvDGEcDAROh85Hbf39CNWAwSEchFMRhvvBz5wGNgJ2?= =?us-ascii?Q?bOSlBoqhDFX9jjqM3IAee6gdhjKLaOGhawl29E2YcmC7WMlT/J5sZnKUukrm?= =?us-ascii?Q?/MSizcUpA3e2PuU3IZsgONhsXXkr93kagqFsO6k67LVQqX5AmL++FDFFL0nV?= =?us-ascii?Q?Y5i3f2yxm8hJkxWKKQO5lIeLEu9ml0HZNwVRakBWY5E+zzBhWzZCVhfZaI7R?= =?us-ascii?Q?LkiW/zxuR3eEl/zVCsJvt4CFxhzMwRNb03/ZNbmXmCX4sBGqtRgb1eJXMiQ+?= =?us-ascii?Q?nWdshlKkkpLiDVzsbj6KuvAJZtgo45NKFq4inImcgEF9cgM0PZkxOpv24Ssq?= =?us-ascii?Q?rXktiVvUb2lCFXcHlJkxs1wRw3qT00aAtid+QAdqfxdPP87eU4+UMmbO5m2q?= =?us-ascii?Q?yuT+115pC0na1Hv1/uOz7IWsmzlyvsVG+oi3ESKWgWMnkKcTLz2i5N9ztXcd?= =?us-ascii?Q?tBlM6Otoci4UVqDOHyeUs7Od4JtXiehyMpv0Cqs7SfgXCQrdR87raTSNAcCy?= =?us-ascii?Q?flBl+gjNnkEzsYQdIS4tXxXzoduRpfJp0YYCqyf02StKqJ+aLELVGmmW1fQO?= =?us-ascii?Q?vwi5dJymL6d8NV8lCQeubW/VLKt5WgSUXmUwsmGJov698fcbGQ5AMD0vxYnu?= =?us-ascii?Q?U73yVGW+5ErV01FmO42n/O10XUFEE25+yLnY2WdehPNDmbHMawTcT/otr691?= =?us-ascii?Q?nqSZtw/woRuS86SiFPI5qOzQHSlZg/nqna2I/fsElkq4XS08iOYfnuJHHp1s?= =?us-ascii?Q?HHs2r88WLZSL5smlkTsBmExIC88mBdJK286EArSS?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb4c297d-9f14-45e5-a5e2-08dbe74bada9 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2023 09:00:42.4842 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PhVpSSva1nRJdDIHtJM+NrWWLY04DQUwQ9b6LjmEZ7J7BblaEez1VuLsLMTapTLf3iIa1OXJDikXI9m7HFE3g7canCCdYPX+lraTpc+EbWo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5554 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org After applying this patch, the link of DPDK may fail if all dependencies of= libarchive are not installed. For some reason the install of the libarchiv= e-dev package on many distros does not install all correct dependencies and= the user needs to install a few other dev packages manually. (To me, this = looks like something that could do with being fixed in the packages - it's = not something we can really control) Srikanth, do you think this patch needs to be backported? If there is no co= mpelling need, I'd maybe avoid doing so to avoid possible unexpected build = issues for users. /Bruce > -----Original Message----- > From: Kevin Traynor > Sent: Thursday, November 16, 2023 1:23 PM > To: Srikanth Yalavarthi > Cc: Richardson, Bruce ; dpdk stable > > Subject: patch 'build: add libarchive to optional external dependencies' > has been queued to stable release 21.11.6 >=20 > Hi, >=20 > FYI, your patch has been queued to stable release 21.11.6 >=20 > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 11/21/23. So please > shout if anyone has objections. >=20 > Also note that after the patch there's a diff of the upstream commit vs > the > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for > rebasing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. >=20 > Queued patches are on a temporary branch at: > https://github.com/kevintraynor/dpdk-stable >=20 > This queued commit can be viewed at: > https://github.com/kevintraynor/dpdk- > stable/commit/aa40722948ac2dc15f93b8598f560029c757b645 >=20 > Thanks. >=20 > Kevin >=20 > --- > From aa40722948ac2dc15f93b8598f560029c757b645 Mon Sep 17 00:00:00 2001 > From: Srikanth Yalavarthi > Date: Sun, 5 Nov 2023 20:12:43 -0800 > Subject: [PATCH] build: add libarchive to optional external dependencies >=20 > [ upstream commit 22f7184e8b5f1b546ac26dd0bde8c3c6038a7e03 ] >=20 > In order to avoid linking with Libs.private, libarchive > is not added to ext_deps during the meson setup stage. >=20 > Since libarchive is not added to ext_deps, cross-compilation > or native compilation with libarchive installed in non-standard > location fails with errors related to "cannot find -larchive" > or "archive.h: No such file or directory". In order to fix the > build failures, user is required to define the 'c_args' and > 'c_link_args' with '-I' and '-L'. >=20 > This patch adds libarchive to ext_deps and further would not > require setting c_args and c_link_args externally. >=20 > Fixes: 40edb9c0d36b ("eal: handle compressed firmware") >=20 > Signed-off-by: Srikanth Yalavarthi > Acked-by: Bruce Richardson > --- > config/meson.build | 5 ----- > lib/eal/meson.build | 3 +++ > 2 files changed, 3 insertions(+), 5 deletions(-) >=20 > diff --git a/config/meson.build b/config/meson.build > index a79a3ed39c..b40302da02 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -208,9 +208,4 @@ libarchive =3D dependency('libarchive', required: fal= se, > method: 'pkg-config') > if libarchive.found() > dpdk_conf.set('RTE_HAS_LIBARCHIVE', 1) > - # Push libarchive link dependency at the project level to support > - # statically linking dpdk apps. Details at: > - # https://inbox.dpdk.org/dev/20210605004024.660267a1@sovereign/ > - add_project_link_arguments('-larchive', language: 'c') > - dpdk_extra_ldflags +=3D '-larchive' > endif >=20 > diff --git a/lib/eal/meson.build b/lib/eal/meson.build > index 1722924f67..f223c6d7a5 100644 > --- a/lib/eal/meson.build > +++ b/lib/eal/meson.build > @@ -23,4 +23,7 @@ if dpdk_conf.has('RTE_USE_LIBBSD') > ext_deps +=3D libbsd > endif > +if dpdk_conf.has('RTE_HAS_LIBARCHIVE') > + ext_deps +=3D libarchive > +endif > if cc.has_function('getentropy', prefix : '#include ') > cflags +=3D '-DRTE_LIBEAL_USE_GETENTROPY' > -- > 2.41.0 >=20 > --- > Diff of the applied patch vs upstream commit (please double-check if > non-empty: > --- > --- - 2023-11-16 13:21:53.587627939 +0000 > +++ 0043-build-add-libarchive-to-optional-external-dependenci.patch > 2023-11-16 13:21:52.506946538 +0000 > @@ -1 +1 @@ > -From 22f7184e8b5f1b546ac26dd0bde8c3c6038a7e03 Mon Sep 17 00:00:00 2001 > +From aa40722948ac2dc15f93b8598f560029c757b645 Mon Sep 17 00:00:00 2001 > @@ -5,0 +6,2 @@ > +[ upstream commit 22f7184e8b5f1b546ac26dd0bde8c3c6038a7e03 ] > + > @@ -20 +21,0 @@ > -Cc: stable@dpdk.org > @@ -30 +31 @@ > -index 39ed4ba7d3..d732154731 100644 > +index a79a3ed39c..b40302da02 100644 > @@ -33 +34 @@ > -@@ -252,9 +252,4 @@ libarchive =3D dependency('libarchive', required: > false, method: 'pkg-config') > +@@ -208,9 +208,4 @@ libarchive =3D dependency('libarchive', required: > false, method: 'pkg-config') > @@ -44 +45 @@ > -index 9942104386..e1d6c4cf17 100644 > +index 1722924f67..f223c6d7a5 100644 > @@ -47 +48 @@ > -@@ -22,4 +22,7 @@ if dpdk_conf.has('RTE_USE_LIBBSD') > +@@ -23,4 +23,7 @@ if dpdk_conf.has('RTE_USE_LIBBSD')