Re: [PATCH] app/crypto-perf: fix plaintext size exceeds buffer size

["Ji, Kai" <kai.ji@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2067 bytes --]

Acked-by: Kai Ji <kai.ji@intel.com>

________________________________
From: Shani Peretz <shperetz@nvidia.com>
Sent: 05 August 2025 07:38
To: dev@dpdk.org <dev@dpdk.org>
Cc: suanmingm@nvidia.com <suanmingm@nvidia.com>; Shani Peretz <shperetz@nvidia.com>; stable@dpdk.org <stable@dpdk.org>; Ji, Kai <kai.ji@intel.com>; Kobylinski, Michal <michal.kobylinski@intel.com>; Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>; Marcin Kerlin <marcinx.kerlin@intel.com>; Piotr Azarewicz <piotr.azarewicz@intel.com>; Doherty, Declan <declan.doherty@intel.com>
Subject: [PATCH] app/crypto-perf: fix plaintext size exceeds buffer size

When test vector plaintext exceeds buffer size, only the first
max_buffer_size bytes are processed, causing incorrect digest
verification (computed vs expected mismatch).

This patch fixes this issue by checking that the plaintext size is
larger than the buffer size and returns an error with a log.

Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")
Cc: stable@dpdk.org

Signed-off-by: Shani Peretz <shperetz@nvidia.com>
---
 app/test-crypto-perf/cperf_test_vector_parsing.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/app/test-crypto-perf/cperf_test_vector_parsing.c b/app/test-crypto-perf/cperf_test_vector_parsing.c
index 737d61d4af..04ca9cf019 100644
--- a/app/test-crypto-perf/cperf_test_vector_parsing.c
+++ b/app/test-crypto-perf/cperf_test_vector_parsing.c
@@ -308,6 +308,12 @@ parse_entry(char *entry, struct cperf_test_vector *vector,
         if (strstr(key_token, "plaintext")) {
                 rte_free(vector->plaintext.data);
                 vector->plaintext.data = data;
+
+               if (opts->test == CPERF_TEST_TYPE_VERIFY && data_length > opts->max_buffer_size) {
+                       printf("Global plaintext larger than buffer_sz\n");
+                       return -1;
+               }
+
                 if (tc_found)
                         vector->plaintext.length = data_length;
                 else {
--
2.34.1


[-- Attachment #2: Type: text/html, Size: 4038 bytes --]