From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id CBCCA28F3; Tue, 10 Jan 2017 14:53:20 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 10 Jan 2017 05:53:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,344,1477983600"; d="scan'208";a="1110540408" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 10 Jan 2017 05:53:18 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 10 Jan 2017 13:53:18 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by irsmsx111.ger.corp.intel.com ([169.254.2.109]) with mapi id 14.03.0248.002; Tue, 10 Jan 2017 13:53:17 +0000 From: "De Lara Guarch, Pablo" To: "Doherty, Declan" , "Azarewicz, PiotrX T" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] crypto/openssl: fix that remove unneeded check Thread-Index: AQHSaocVC4C1NYqTzUm6sMU3nullwaExcqqAgABJ+sA= Date: Tue, 10 Jan 2017 13:53:17 +0000 Message-ID: References: <1483973136-154458-1-git-send-email-piotrx.t.azarewicz@intel.com> <0df6fc09-6d6e-f9fd-40e4-caae605469ff@intel.com> In-Reply-To: <0df6fc09-6d6e-f9fd-40e4-caae605469ff@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODhjMTQ1MWYtODEyYS00YTQ4LWE0OTYtMjhhZDk0NjVhMTRjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik9sYzVzT3gzSWRqTFNTUWlPXC9obUFvaTRKZFwveE1iYUtaaUpZTmhFQkw0OD0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] crypto/openssl: fix that remove unneeded check X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2017 13:53:21 -0000 > -----Original Message----- > From: Doherty, Declan > Sent: Tuesday, January 10, 2017 9:28 AM > To: Azarewicz, PiotrX T; De Lara Guarch, Pablo; dev@dpdk.org > Cc: stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] crypto/openssl: fix that remove unneeded > check >=20 > On 09/01/17 14:45, Piotr Azarewicz wrote: > > EVP_CIPHER_CTX_set_padding() function always returns 1, so the check is > > unneeded. > > > > Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library"= ) > > > > Signed-off-by: Piotr Azarewicz > > --- > > drivers/crypto/openssl/rte_openssl_pmd.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c > b/drivers/crypto/openssl/rte_openssl_pmd.c > > index 832ea1d..312154a 100644 > > --- a/drivers/crypto/openssl/rte_openssl_pmd.c > > +++ b/drivers/crypto/openssl/rte_openssl_pmd.c > > @@ -522,8 +522,7 @@ > > if (EVP_DecryptInit_ex(ctx, algo, NULL, key, iv) <=3D 0) > > goto process_cipher_decrypt_err; > > > > - if (EVP_CIPHER_CTX_set_padding(ctx, 0) <=3D 0) > > - goto process_cipher_decrypt_err; > > + EVP_CIPHER_CTX_set_padding(ctx, 0); > > > > if (EVP_DecryptUpdate(ctx, dst, &dstlen, src, srclen) <=3D 0) > > goto process_cipher_decrypt_err; > > >=20 > Acked-by: Declan Doherty Applied to dpdk-next-crypto. Thanks, Pablo