From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1C000FB6E; Thu, 30 Mar 2017 13:54:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490874869; x=1522410869; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=UCuwJJ8Ba0yZcbAPLikGWfD6Lzs+AAdjG+DW4anT9rc=; b=u1DOKRVaYGOo69gYeZ6kuujMFJ1c3aNhMrpxi+8RpQk7oFf62JZaizgD 0WyZi7/0E8Vxx8VkzPcFTsZX69IT1w==; Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Mar 2017 04:54:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,246,1486454400"; d="scan'208";a="82681887" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga006.fm.intel.com with ESMTP; 30 Mar 2017 04:54:27 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 30 Mar 2017 12:54:26 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.239]) by irsmsx111.ger.corp.intel.com ([169.254.2.58]) with mapi id 14.03.0319.002; Thu, 30 Mar 2017 12:54:26 +0100 From: "De Lara Guarch, Pablo" To: "Doherty, Declan" , "Gonzalez Monroy, Sergio" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH] crypto/aesni_gcm: do crypto op in dequeue function Thread-Index: AQHSqJJlcKJcgPVZz06SCxxkLUpnQ6GtNDGAgAATKjA= Date: Thu, 30 Mar 2017 11:54:25 +0000 Message-ID: References: <20170329134253.31909-1-sergio.gonzalez.monroy@intel.com> <7923ff78-ba53-4573-5c83-efc699ff53c1@intel.com> In-Reply-To: <7923ff78-ba53-4573-5c83-efc699ff53c1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjgxMzBlODItZmZlNS00YjVkLWIwZDUtN2U5OTM0ZDE2MzRkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjZVMmZOeVZQN3RqWUdEXC9WTlNNNnNwSWJ2UDNYejlpd1pReXozOElhc3BjPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] crypto/aesni_gcm: do crypto op in dequeue function X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 11:54:29 -0000 > -----Original Message----- > From: Doherty, Declan > Sent: Thursday, March 30, 2017 12:45 PM > To: Gonzalez Monroy, Sergio; dev@dpdk.org > Cc: De Lara Guarch, Pablo; stable@dpdk.org > Subject: Re: [PATCH] crypto/aesni_gcm: do crypto op in dequeue function >=20 > On 29/03/17 14:42, Sergio Gonzalez Monroy wrote: > > There is bug when more crypto ops are enqueued than dequeued. > > The return value is not checked when trying to enqueue the > > processed crypto op into the internal ring, which in the case of being > > full will results in crypto ops and mbufs being leaked. > > The issue is more obvious with different cores doing enqueue/dequeue. > > > > This patch moves the crypto operation to the dequeue function which > > fixes the above issue without having to check for the number of free > > entries in the ring. > > > > Fixes: eec136f3c54f ("aesni_gcm: add driver for AES-GCM crypto > operations") > > > > Signed-off-by: Sergio Gonzalez Monroy > > > --- > ... > > > Hi Declan, > Hey Sergio, this looks good but it needs to be rebased for the rte_ring > API change. I also see a marginally performance increase with this > change using the crypto-perf app which wasn't expected. Unless there is other change necessary, I can make that change when merging= . Thanks, Pablo >=20 >=20 > Acked-by: Declan Doherty