From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E10816D45 for ; Thu, 21 Sep 2017 22:45:25 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Sep 2017 13:45:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,426,1500966000"; d="scan'208";a="138057363" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga002.jf.intel.com with ESMTP; 21 Sep 2017 13:45:24 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX152.ger.corp.intel.com ([169.254.6.87]) with mapi id 14.03.0319.002; Thu, 21 Sep 2017 21:45:23 +0100 From: "De Lara Guarch, Pablo" To: "stable@dpdk.org" Thread-Topic: [PATCH] hash: fix incorrect eviction counter Thread-Index: AQHTMt7FE5+BiQzEp0q24KnMjMtIJKK/zxGQ Date: Thu, 21 Sep 2017 20:45:22 +0000 Message-ID: References: <20170921053749.72749-1-pablo.de.lara.guarch@intel.com> In-Reply-To: <20170921053749.72749-1-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTU4OTgyNDUtMmFlMy00MTllLTllZmUtZTg2ZjNhZTg0NjhiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IldlMWJLUlhYTjArSTcxME5ycEF2b0ZxOVVTcnd5eGxmVkxCeW9qVmlYXC9NPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] hash: fix incorrect eviction counter X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 20:45:27 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Thursday, September 21, 2017 6:38 AM > To: De Lara Guarch, Pablo > Cc: stable@dpdk.org > Subject: [PATCH] hash: fix incorrect eviction counter >=20 > When adding a new entry in a hash table, there is a maximum number of > evictions that can be performed. When the counter of these evictions > reaches this maximum, the entry cannot be added, as it is considered that > the algorithm has encountered an infinite loop. >=20 > The problem with the current implementation, is that this counter was > declared as a static variable. > If there are multiple threads adding entries in the same table or in diff= erent > tables, there should have different counters, one per core and per table. >=20 > Therefore, an array of counter has been added to the hash table structure= . >=20 > Fixes: 243e93a5046f ("hash: fix unlimited cuckoo path") > Cc: stable@dpdk.org >=20 > Signed-off-by: Pablo de Lara Self-NACK. Did not send the patch to dev@dpdk.org, plus the commit message had a typo.