From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 998F61AEEE; Thu, 5 Oct 2017 10:19:55 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP; 05 Oct 2017 01:19:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,480,1500966000"; d="scan'208";a="135438728" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga004.jf.intel.com with ESMTP; 05 Oct 2017 01:19:53 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by irsmsx110.ger.corp.intel.com ([163.33.3.25]) with mapi id 14.03.0319.002; Thu, 5 Oct 2017 09:19:52 +0100 From: "De Lara Guarch, Pablo" To: Akhil Goyal , "dev@dpdk.org" CC: "Doherty, Declan" , "hemant.agrawal@nxp.com" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] test/crypto: fix dpaa2_sec macros and definitions Thread-Index: AQHTPCp7yNMDv6VFyUuP9z9GnUYgyKLU6/DQ Date: Thu, 5 Oct 2017 08:19:51 +0000 Message-ID: References: <20171003092911.32447-1-akhil.goyal@nxp.com> In-Reply-To: <20171003092911.32447-1-akhil.goyal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDFhNjYyMzktODhkMC00YTdjLWFiM2QtY2JhZTcwZTNkMjZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IndKWVA5ZzNFcTlqMFlJbVU1Mnl1UlJXWDBCK0lETjBRMDBIbFRcL2RwbXZVPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] test/crypto: fix dpaa2_sec macros and definitions X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 08:19:56 -0000 Hi Akhil, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal > Sent: Tuesday, October 3, 2017 10:29 AM > To: dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agrawal@nxp.com; > stable@dpdk.org; Akhil Goyal > Subject: [dpdk-dev] [PATCH] test/crypto: fix dpaa2_sec macros and > definitions >=20 > Fixes: 7a364faef185 ("cryptodev: remove crypto device type enumeration") >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Akhil Goyal > --- > test/test/test_cryptodev.c | 2 +- > test/test/test_cryptodev_perf.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c inde= x > a4116c6..132f99c 100644 > --- a/test/test/test_cryptodev.c > +++ b/test/test/test_cryptodev.c > @@ -1816,7 +1816,7 @@ test_authonly_dpaa2_sec_all(void) > ts_params->session_mpool, > ts_params->valid_devs[0], > rte_cryptodev_driver_id_get( > - RTE_STR(RTE_CRYPTODEV_DPAA2_SEC_PMD)), > + RTE_STR(CRYPTODEV_NAME_DPAA2_SEC_PMD)), > BLKCIPHER_AUTHONLY_TYPE); >=20 > TEST_ASSERT_EQUAL(status, 0, "Test failed"); diff --git > a/test/test/test_cryptodev_perf.c b/test/test/test_cryptodev_perf.c index > 3b57e6d..5df2e6e 100644 > --- a/test/test/test_cryptodev_perf.c > +++ b/test/test/test_cryptodev_perf.c > @@ -211,7 +211,7 @@ static const char *pmd_name(uint8_t driver_id) { > uint8_t null_pmd =3D rte_cryptodev_driver_id_get( > RTE_STR(CRYPTODEV_NAME_NULL_PMD)); > - uint8_t dpaa2_pmd =3D rte_cryptodev_driver_id_get( > + uint8_t dpaa2_sec_pmd =3D rte_cryptodev_driver_id_get( I think, in order to keep consistency, you should make this change also in = test_cryptodev.c: test/test/test_cryptodev_blockcipher.c 580: int dpaa2_pmd =3D rte_cryptodev_driver_id_get( 646: else if (driver_id =3D=3D dpaa2_pmd) Also, I submitted a patch to remove test_cryptodev_perf.c. I will apply this patch first, so it is easier to integrate in the stable v= ersion, but could you ack my patch if you are OK with it? The sooner we remove it, the better, as we are investing a lot of time in the crypto-perf app, and there is no need to maintain a duplicate, in my= opinion. Thanks, Pablo