From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5B15D29D2; Tue, 24 Apr 2018 15:21:10 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2018 06:21:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,323,1520924400"; d="scan'208";a="45656460" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga003.jf.intel.com with ESMTP; 24 Apr 2018 06:21:08 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by IRSMSX109.ger.corp.intel.com ([169.254.13.170]) with mapi id 14.03.0319.002; Tue, 24 Apr 2018 14:21:07 +0100 From: "De Lara Guarch, Pablo" To: "Yigit, Ferruh" , Pascal Mazon CC: "dev@dpdk.org" , "Yigit, Ferruh" , "stable@dpdk.org" Thread-Topic: [dpdk-stable] [PATCH] net/tap: fix icc build Thread-Index: AQHTujjHWAZvUwIYoUyHDbnm3dUwtaQQKacg Date: Tue, 24 Apr 2018 13:21:06 +0000 Message-ID: References: <20180312193134.219899-1-ferruh.yigit@intel.com> In-Reply-To: <20180312193134.219899-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTc2MjY0OTktODRiNC00ZTFiLWFlNDQtZDc4OTU5MjUzODhlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImlxNFRCd0hhbURnSzN4ZVNkK3pKNHorMjRTMW0rSk0xUUg4SllPcFpYems9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] net/tap: fix icc build X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 13:21:12 -0000 > -----Original Message----- > From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Monday, March 12, 2018 7:32 PM > To: Pascal Mazon > Cc: dev@dpdk.org; Yigit, Ferruh ; stable@dpdk.org > Subject: [dpdk-stable] [PATCH] net/tap: fix icc build >=20 > build error: > .../dpdk/drivers/net/tap/rte_eth_tap.c(598): > error #279: controlling expression is constant > RTE_ASSERT(!"unsupported request type: must not happen"); >=20 > Although RTE_ASSERT helps debugging this issue when assert enabled, const= ant > expression in assert means this path can be taken during runtime and ther= e is no > protection against it when assert is disabled. >=20 > Adding error log and error return back, replacing RTE_ASSERT. >=20 > Fixes: 7748a4b44196 ("net/tap: add debug messages") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ferruh Yigit Acked-by: Pablo de Lara