* Re: [dpdk-stable] [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for fle address
[not found] ` <ca1fb35f-cdae-58b0-f566-aac579509377@nxp.com>
@ 2018-05-09 10:24 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2018-05-09 10:24 UTC (permalink / raw)
To: Akhil Goyal, Shreyansh Jain; +Cc: dev, Hemant Agrawal, stable
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Wednesday, May 9, 2018 10:14 AM
> To: Shreyansh Jain <shreyansh.jain@nxp.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: akhil.goyal@nxp.com; dev@dpdk.org; Hemant Agrawal
> <hemant.agrawal@nxp.com>
> Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for
> fle address
>
> On 5/9/2018 2:56 PM, Shreyansh Jain wrote:
> > From: Hemant Agrawal <hemant.agrawal@nxp.com>
> >
> > fle is already in virtual addressing mode - no need to perform address
> > conversion for it.
> >
> > Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation")
> > Cc: akhil.goyal@nxp.com
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
...
> >
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Added Cc: stable@dpdk.org (try remembering this for next time, please).
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-stable] [PATCH v2] crypto/dpaa2_sec: remove iova conversion for fle address
[not found] <20180509092642.9092-1-shreyansh.jain@nxp.com>
[not found] ` <ca1fb35f-cdae-58b0-f566-aac579509377@nxp.com>
@ 2018-05-09 12:43 ` Shreyansh Jain
2018-05-09 14:35 ` De Lara Guarch, Pablo
1 sibling, 1 reply; 3+ messages in thread
From: Shreyansh Jain @ 2018-05-09 12:43 UTC (permalink / raw)
To: pablo.de.lara.guarch; +Cc: dev, akhil.goyal, stable, hemant.agrawal
From: Hemant Agrawal <hemant.agrawal@nxp.com>
fle is already in virtual addressing mode - no need to perform
address conversion for it.
Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation")
Cc: akhil.goyal@nxp.com
Cc: stable@dpdk.org
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
---
v2:
- fix 32 bit compilation issue
drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 2 +-
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
index b09218f27..820759360 100644
--- a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
+++ b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
@@ -199,7 +199,7 @@ enum qbman_fd_format {
} while (0)
#define DPAA2_SET_FLE_INTERNAL_JD(fle, len) ((fle)->frc = (0x80000000 | (len)))
#define DPAA2_GET_FLE_ADDR(fle) \
- (uint64_t)((((uint64_t)((fle)->addr_hi)) << 32) + (fle)->addr_lo)
+ (size_t)((((uint64_t)((fle)->addr_hi)) << 32) + (fle)->addr_lo)
#define DPAA2_SET_FLE_ADDR(fle, addr) do { \
(fle)->addr_lo = lower_32_bits((size_t)addr); \
(fle)->addr_hi = upper_32_bits((uint64_t)addr); \
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index 58cbce868..56fa969d3 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
@@ -1261,8 +1261,7 @@ sec_fd_to_mbuf(const struct qbman_fd *fd, uint8_t driver_id)
DPAA2_SEC_ERR("error: non inline buffer");
return NULL;
}
- op = (struct rte_crypto_op *)DPAA2_IOVA_TO_VADDR(
- DPAA2_GET_FLE_ADDR((fle - 1)));
+ op = (struct rte_crypto_op *)DPAA2_GET_FLE_ADDR((fle - 1));
/* Prefeth op */
src = op->sym->m_src;
--
2.17.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [PATCH v2] crypto/dpaa2_sec: remove iova conversion for fle address
2018-05-09 12:43 ` [dpdk-stable] [PATCH v2] " Shreyansh Jain
@ 2018-05-09 14:35 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2018-05-09 14:35 UTC (permalink / raw)
To: Shreyansh Jain; +Cc: dev, akhil.goyal, stable, hemant.agrawal
> -----Original Message-----
> From: Shreyansh Jain [mailto:shreyansh.jain@nxp.com]
> Sent: Wednesday, May 9, 2018 1:43 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; akhil.goyal@nxp.com; stable@dpdk.org;
> hemant.agrawal@nxp.com
> Subject: [PATCH v2] crypto/dpaa2_sec: remove iova conversion for fle address
>
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
>
> fle is already in virtual addressing mode - no need to perform address conversion
> for it.
>
> Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation")
> Cc: akhil.goyal@nxp.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-09 14:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180509092642.9092-1-shreyansh.jain@nxp.com>
[not found] ` <ca1fb35f-cdae-58b0-f566-aac579509377@nxp.com>
2018-05-09 10:24 ` [dpdk-stable] [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for fle address De Lara Guarch, Pablo
2018-05-09 12:43 ` [dpdk-stable] [PATCH v2] " Shreyansh Jain
2018-05-09 14:35 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).