From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1ECFF1B2AA; Fri, 26 Jan 2018 16:44:30 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jan 2018 07:44:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,417,1511856000"; d="scan'208";a="22536976" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga003.jf.intel.com with ESMTP; 26 Jan 2018 07:44:29 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.95]) by irsmsx105.ger.corp.intel.com ([169.254.7.221]) with mapi id 14.03.0319.002; Fri, 26 Jan 2018 15:44:28 +0000 From: "Van Haaren, Harry" To: "Varghese, Vipin" , "dev@dpdk.org" CC: "Jain, Deepak K" , "Mcnamara, John" , "stable@dpdk.org" , "Patel, Amol" Thread-Topic: [PATCH] app/pdump: fix the memory leak by rte_service_init Thread-Index: AQHTlRbVy2ObGio37U2vcDb9p6JMI6OGTeeA Date: Fri, 26 Jan 2018 15:44:27 +0000 Message-ID: References: <1516780491-4554-1-git-send-email-vipin.varghese@intel.com> In-Reply-To: <1516780491-4554-1-git-send-email-vipin.varghese@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmJmZDk5ZjUtNjRiZi00NTE0LWJmZTMtMGM4MTI4Zjk1MjExIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJSRFliRnRLTjkxR2ZNMzY1WGZUMXlxdk1cL0l2QnJwcXZuQUtPSjI1SnJsN0pLeXdsMDllaEFXWXhvQ2xSR2J1ZCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] app/pdump: fix the memory leak by rte_service_init X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 15:44:31 -0000 > From: Varghese, Vipin > Sent: Wednesday, January 24, 2018 7:55 AM > To: Van Haaren, Harry ; dev@dpdk.org > Cc: Jain, Deepak K ; Mcnamara, John > ; stable@dpdk.org; Patel, Amol > ; Varghese, Vipin > Subject: [PATCH] app/pdump: fix the memory leak by rte_service_init >=20 > When pdump is run multiple times against any primary application, > it consumes huge page memory by rte_service_init. This is not freed > at exit of application. >=20 > Invoking rte_service_finalize to free memory and prevent memory leak. >=20 > Signed-off-by: Vipin Varghese Thanks Vipin. Note that this fixes a hugepages memory leak that would otherwise occur when a secondary process initializes EAL and then quits. Note that this patch depends on the patch adding rte_service_finalize() http://dpdk.org/dev/patchwork/patch/34555/ Acked-by: Harry van Haaren