patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "Sirvys, Andrius" <andrius.sirvys@intel.com>,
	"Laatz, Kevin" <kevin.laatz@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"Ferriter, Cian" <cian.ferriter@intel.com>,
	"Lipiec, Herakliusz" <herakliusz.lipiec@intel.com>
Subject: Re: [dpdk-stable] [PATCH v3] usertools: fix input handling in telemetry script
Date: Thu, 8 Aug 2019 15:32:04 +0000	[thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA6758B80D8@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <20190808143753.16788-1-andrius.sirvys@intel.com>

> -----Original Message-----
> From: Sirvys, Andrius
> Sent: Thursday, August 8, 2019 3:38 PM
> To: Laatz, Kevin <kevin.laatz@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Van Haaren, Harry
> <harry.van.haaren@intel.com>; Ferriter, Cian <cian.ferriter@intel.com>;
> Lipiec, Herakliusz <herakliusz.lipiec@intel.com>; Sirvys, Andrius
> <andrius.sirvys@intel.com>
> Subject: [PATCH v3] usertools: fix input handling in telemetry script
> 
> This commit removes the unnecesarry ast.literal_eval() function call
> from the input handling, which now relies just on raw_input() to get
> its input.
> 
> Fixes: 53f293c9a783 ("usertools: replace unsafe input function")
> Cc: andrius.sirvys@intel.com
> 
> Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
> ---
> v2: Removed unnecessary comments
> v3: Reduced scope of changes only to required Python 2 fix
> 
> Please note that the dpdk-telemetry-client.py script has a number of
> issues with Python3 support. Fixing Python3 support is being deferred
> to DPDK 19.11 release.

Thanks for the patch re-spin Andrius. This is the smallest change possible
to fix the current issue, and I recommend including in 19.08 release.

Agree the Python3 support requires larger refactoring, which should be
undertaken for 19.11.

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

  reply	other threads:[~2019-08-08 15:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07 13:04 [dpdk-stable] [PATCH v2] usertools: dpdk-telemetry-client.py run into looping status Andrius Sirvys
2019-08-08  7:17 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-08-08 14:37 ` [dpdk-stable] [PATCH v3] usertools: fix input handling in telemetry script Andrius Sirvys
2019-08-08 15:32   ` Van Haaren, Harry [this message]
2019-08-08 15:32   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E923DB57A917B54B9182A2E928D00FA6758B80D8@IRSMSX102.ger.corp.intel.com \
    --to=harry.van.haaren@intel.com \
    --cc=andrius.sirvys@intel.com \
    --cc=cian.ferriter@intel.com \
    --cc=dev@dpdk.org \
    --cc=herakliusz.lipiec@intel.com \
    --cc=kevin.laatz@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).