From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Eads, Gage" <gage.eads@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] event/sw: fix xstats reset value assignment bug
Date: Fri, 13 Sep 2019 10:31:35 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA6758F9B20@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <CALBAE1MJHs=cKadgG+Gke0QxgvOYAe=p9tYvwuwHepK3+hfi=w@mail.gmail.com>
> -----Original Message-----
> From: Jerin Jacob [mailto:jerinjacobk@gmail.com]
> Sent: Friday, September 13, 2019 11:30 AM
> To: Eads, Gage <gage.eads@intel.com>
> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>; Van Haaren,
> Harry <harry.van.haaren@intel.com>; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] event/sw: fix xstats reset value assignment
> bug
>
> On Wed, Aug 28, 2019 at 3:06 AM Gage Eads <gage.eads@intel.com> wrote:
> >
> > The sw PMD implements xstats reset by having the xstat get operations
> > return a value to the statistic's value at the last reset. The value at the
> > last reset is maintained in the per-xstat reset_value field, but the PMD
> > was setting reset_value = current - reset_value instead of reset_value =
> > current.
> >
> > Fixes: c1ad03df7ad5 ("event/sw: support xstats")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Gage Eads <gage.eads@intel.com>
>
> Harry,
>
> Could you review this patch?
Yes - thanks for the ping. It's on my TODO, will prioritize.
next prev parent reply other threads:[~2019-09-13 10:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 21:34 [dpdk-stable] " Gage Eads
2019-09-13 10:30 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2019-09-13 10:31 ` Van Haaren, Harry [this message]
2019-09-23 14:17 ` Van Haaren, Harry
2019-09-23 15:51 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA6758F9B20@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).