From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: "Yang, Zhiyong" <zhiyong.yang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-stable] [PATCH] net/virtio: fix read isr as MSI is enabled
Date: Thu, 6 Apr 2017 05:30:10 +0000 [thread overview]
Message-ID: <ED26CBA2FAD1BF48A8719AEF02201E3651195B81@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20170406051925.GN18844@yliu-dev.sh.intel.com>
Sorry, please just NACK this patch. (I'll do that in patchwork)
I was sharing this half-baked patch with Zhiyong and forget to remove "CC".
Zhiyong and I are still working on this bug. Will send it out later.
Thanks,
Jianfeng
> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Thursday, April 6, 2017 1:19 PM
> To: Tan, Jianfeng
> Cc: Yang, Zhiyong; stable@dpdk.org; Stephen Hemminger
> Subject: Re: [dpdk-stable] [PATCH] net/virtio: fix read isr as MSI is enabled
>
> On Tue, Mar 28, 2017 at 06:46:51AM +0000, Jianfeng Tan wrote:
> > We should not always check isr to know if link status is changed.
>
> Did this patch fix a real issue?
>
> > Here is how driver should handle interrupt quoted from virtio spec,
> >
> > If MSI-X capability is disabled:
> > – Read the ISR Status field, which will reset it to zero.
> > – If the lower bit is set: look through the used rings of all
> > virtqueues for the device, to see if any progress has been made
> > by the device which requires servicing.
> > – If the second lower bit is set: re-examine the configuration
> > space to see what changed.
> > If MSI-X capability is enabled:
> > – Look through the used rings of all virtqueues mapped to that
> > MSI-X vector for the device, to see if any progress has been
> > made by the device which requires servicing.
> > – If the MSI-X vector is equal to config_msix_vector, re-examine
> > the configuration space to see what changed
> >
> > Fixes: 8d6d7e5cb3b1 ("virtio: support link state interrupt")
> > CC: stable@dpdk.org
> >
> > CC: Stephen Hemminger <stephen@networkplumber.org>
> > Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> > ---
> > drivers/net/virtio/virtio_ethdev.c | 22 +++++++++++++---------
> > 1 file changed, 13 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/net/virtio/virtio_ethdev.c
> b/drivers/net/virtio/virtio_ethdev.c
> > index 3cf4102..cb30d11 100644
> > --- a/drivers/net/virtio/virtio_ethdev.c
> > +++ b/drivers/net/virtio/virtio_ethdev.c
> > @@ -36,6 +36,7 @@
> > #include <stdio.h>
> > #include <errno.h>
> > #include <unistd.h>
> > +#include <stdbool.h>
> >
> > #include <rte_ethdev.h>
> > #include <rte_memcpy.h>
> > @@ -1197,20 +1198,23 @@ virtio_interrupt_handler(struct rte_intr_handle
> *handle,
> > struct rte_eth_dev *dev = param;
> > struct virtio_hw *hw = dev->data->dev_private;
> > uint8_t isr;
> > + bool check_config;
> >
> > - /* Read interrupt status which clears interrupt */
> > - isr = vtpci_isr(hw);
> > - PMD_DRV_LOG(INFO, "interrupt status = %#x", isr);
> > + /* isr is used only when msix is not enabled */
> > + if (!hw->modern && !hw->use_msix) {
>
> The comment doesn't quite match the code: the hw->modern part is missing.
>
> > + isr = vtpci_isr(hw); /* Read to clears interrupt */
> > + PMD_DRV_LOG(INFO, "interrupt status = %#x", isr);
> > + check_config = (isr & VIRTIO_PCI_ISR_CONFIG) ? true : false;
>
> The "? :" is unnecessary.
>
> --yliu
>
> > + } else {
> > + check_config = true;
> > + }
> >
> > if (rte_intr_enable(handle) < 0)
> > PMD_DRV_LOG(ERR, "interrupt enable failed");
> >
> > - if (isr & VIRTIO_PCI_ISR_CONFIG) {
> > - if (virtio_dev_link_update(dev, 0) == 0)
> > - _rte_eth_dev_callback_process(dev,
> > -
> RTE_ETH_EVENT_INTR_LSC, NULL);
> > - }
> > -
> > + if (check_config && virtio_dev_link_update(dev, 0) == 0)
> > + _rte_eth_dev_callback_process(dev,
> > + RTE_ETH_EVENT_INTR_LSC, NULL);
> > }
> >
> > static void
> > --
> > 2.7.4
next prev parent reply other threads:[~2017-04-06 5:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 6:46 Jianfeng Tan
2017-04-06 5:19 ` Yuanhan Liu
2017-04-06 5:30 ` Tan, Jianfeng [this message]
2017-04-06 5:36 ` Yuanhan Liu
2017-04-06 5:40 ` Tan, Jianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED26CBA2FAD1BF48A8719AEF02201E3651195B81@SHSMSX103.ccr.corp.intel.com \
--to=jianfeng.tan@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=yuanhan.liu@linux.intel.com \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).