patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] vhost: fix MTU device feature check
@ 2017-06-29  7:58 Maxime Coquelin
  2017-06-29  8:01 ` Tan, Jianfeng
  0 siblings, 1 reply; 3+ messages in thread
From: Maxime Coquelin @ 2017-06-29  7:58 UTC (permalink / raw)
  To: dev, yliu; +Cc: i.dyukov, jianfeng.tan, stable, Maxime Coquelin

The MTU feature support check has to be done against MTU
feature bit mask, and not bit position.

Cc: stable@dpdk.org
Fixes: 72e8543093df ("vhost: add API to get MTU value")

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---

This is a follow-up of Ivan's patch, which made me check I didn't
introduced same bug elsewhere.

 lib/librte_vhost/vhost.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c
index 19c5a43..653152f 100644
--- a/lib/librte_vhost/vhost.c
+++ b/lib/librte_vhost/vhost.c
@@ -272,7 +272,7 @@ rte_vhost_get_mtu(int vid, uint16_t *mtu)
 	if (!(dev->flags & VIRTIO_DEV_READY))
 		return -EAGAIN;
 
-	if (!(dev->features & VIRTIO_NET_F_MTU))
+	if (!(dev->features & (1ULL << VIRTIO_NET_F_MTU)))
 		return -ENOTSUP;
 
 	*mtu = dev->mtu;
-- 
2.9.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-07-01 23:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-29  7:58 [dpdk-stable] [PATCH] vhost: fix MTU device feature check Maxime Coquelin
2017-06-29  8:01 ` Tan, Jianfeng
2017-07-01 23:36   ` Yuanhan Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).