From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 4ABCC1B2C8; Sun, 11 Feb 2018 02:48:01 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Feb 2018 17:48:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,493,1511856000"; d="scan'208";a="16776504" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga007.jf.intel.com with ESMTP; 10 Feb 2018 17:48:00 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 10 Feb 2018 17:48:00 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 10 Feb 2018 17:48:00 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.130]) with mapi id 14.03.0319.002; Sun, 11 Feb 2018 09:47:58 +0800 From: "Tan, Jianfeng" To: "Kulasek, TomaszX" , "yliu@fridaylinux.org" CC: "dev@dpdk.org" , "Xie, Huawei" , "stable@dpdk.org" , "Stojaczyk, DariuszX" Thread-Topic: [dpdk-dev] [PATCH] vhost: fix close callfd on get vring base Thread-Index: AQHTock1MtlsGRdlrUSAWgav7cKLUKOecNgA Date: Sun, 11 Feb 2018 01:47:57 +0000 Message-ID: References: <20180209171049.7132-1-tomaszx.kulasek@intel.com> In-Reply-To: <20180209171049.7132-1-tomaszx.kulasek@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] vhost: fix close callfd on get vring base X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Feb 2018 01:48:02 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Kulasek > Sent: Saturday, February 10, 2018 1:11 AM > To: yliu@fridaylinux.org > Cc: dev@dpdk.org; Xie, Huawei; stable@dpdk.org; Stojaczyk, DariuszX > Subject: [dpdk-dev] [PATCH] vhost: fix close callfd on get vring base >=20 > This prevents from destroying & recreating user device in "incomplete" > vring state. virtio_is_ready() was returning true for devices with > vrings which did not have valid callfd (their VHOST_USER_SET_VRING_CALL > hasn't arrived yet) >=20 > Fixes: 8f972312b8f4 ("vhost: support vhost-user") > Cc: huawei.xie@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Dariusz Stojaczyk > Signed-off-by: Tomasz Kulasek Reviewed-by: Jianfeng Tan Thanks for fixing this.