* [dpdk-stable] [PATCH 17.11] net/qede/base: fix to clear HW indication
@ 2018-08-15 18:57 Rasesh Mody
2018-08-16 0:15 ` Yongseok Koh
0 siblings, 1 reply; 2+ messages in thread
From: Rasesh Mody @ 2018-08-15 18:57 UTC (permalink / raw)
To: stable; +Cc: Rasesh Mody, yskoh, Dept-EngDPDKDev
[ backported from upstream commit c8dbf6814312f12cd7fef7203ea9b40255ea1f76 ]
VDMs may cause the was_error indication to be set after the driver
clears it. Clear the indication after the internal FID_enable for
the PF is set.
Fixes: 60c78a5e258a ("net/qede/base: fix recovery from previous ungraceful exit")
Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
---
drivers/net/qede/base/ecore_dev.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c
index 9affcbc..092606b 100644
--- a/drivers/net/qede/base/ecore_dev.c
+++ b/drivers/net/qede/base/ecore_dev.c
@@ -2423,9 +2423,8 @@ enum _ecore_status_t ecore_hw_init(struct ecore_dev *p_dev,
}
}
- /* Log and clean previous pglue_b errors if such exist */
+ /* Log and clear previous pglue_b errors if such exist */
ecore_pglueb_rbc_attn_handler(p_hwfn, p_hwfn->p_main_ptt);
- ecore_pglueb_clear_err(p_hwfn, p_hwfn->p_main_ptt);
/* Enable the PF's internal FID_enable in the PXP */
rc = ecore_pglueb_set_pfid_enable(p_hwfn, p_hwfn->p_main_ptt,
@@ -2433,6 +2432,13 @@ enum _ecore_status_t ecore_hw_init(struct ecore_dev *p_dev,
if (rc != ECORE_SUCCESS)
goto load_err;
+ /* Clear the pglue_b was_error indication.
+ * In E4 it must be done after the BME and the internal
+ * FID_enable for the PF are set, since VDMs may cause the
+ * indication to be set again.
+ */
+ ecore_pglueb_clear_err(p_hwfn, p_hwfn->p_main_ptt);
+
switch (load_code) {
case FW_MSG_CODE_DRV_LOAD_ENGINE:
rc = ecore_hw_init_common(p_hwfn, p_hwfn->p_main_ptt,
--
1.7.10.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH 17.11] net/qede/base: fix to clear HW indication
2018-08-15 18:57 [dpdk-stable] [PATCH 17.11] net/qede/base: fix to clear HW indication Rasesh Mody
@ 2018-08-16 0:15 ` Yongseok Koh
0 siblings, 0 replies; 2+ messages in thread
From: Yongseok Koh @ 2018-08-16 0:15 UTC (permalink / raw)
To: Rasesh Mody; +Cc: stable, Dept-EngDPDKDev
> On Aug 15, 2018, at 11:57 AM, Rasesh Mody <rasesh.mody@cavium.com> wrote:
>
> [ backported from upstream commit c8dbf6814312f12cd7fef7203ea9b40255ea1f76 ]
>
> VDMs may cause the was_error indication to be set after the driver
> clears it. Clear the indication after the internal FID_enable for
> the PF is set.
>
> Fixes: 60c78a5e258a ("net/qede/base: fix recovery from previous ungraceful exit")
>
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
> ---
Applied to stable/17.11
Thanks,
Yongseok
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-16 0:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-15 18:57 [dpdk-stable] [PATCH 17.11] net/qede/base: fix to clear HW indication Rasesh Mody
2018-08-16 0:15 ` Yongseok Koh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).