patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] igbvf: fix MAC address set problem
@ 2017-04-27  9:02 Qiming Yang
  2017-04-28  0:39 ` Lu, Wenzhuo
  2017-05-03  5:52 ` [dpdk-stable] [PATCH v2] net/e1000: fix VF " Qiming Yang
  0 siblings, 2 replies; 7+ messages in thread
From: Qiming Yang @ 2017-04-27  9:02 UTC (permalink / raw)
  To: dev; +Cc: wenzhuo.lu, stable, Qiming Yang

We find that VF receive address register is not set
if MAC address is assigned by PF. This patch fixes it.

Signed-off-by: Qiming Yang <qiming.yang@intel.com>

Fixes: 2a3cf07108b4 ("igbvf: fix MAC address if none assigned by PF")
---
 drivers/net/e1000/igb_ethdev.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index ca9f98c..967805b 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -1031,12 +1031,6 @@ eth_igbvf_dev_init(struct rte_eth_dev *eth_dev)
 	/* Generate a random MAC address, if none was assigned by PF. */
 	if (is_zero_ether_addr(perm_addr)) {
 		eth_random_addr(perm_addr->addr_bytes);
-		diag = e1000_rar_set(hw, perm_addr->addr_bytes, 0);
-		if (diag) {
-			rte_free(eth_dev->data->mac_addrs);
-			eth_dev->data->mac_addrs = NULL;
-			return diag;
-		}
 		PMD_INIT_LOG(INFO, "\tVF MAC address not assigned by Host PF");
 		PMD_INIT_LOG(INFO, "\tAssign randomly generated MAC address "
 			     "%02x:%02x:%02x:%02x:%02x:%02x",
@@ -1048,6 +1042,12 @@ eth_igbvf_dev_init(struct rte_eth_dev *eth_dev)
 			     perm_addr->addr_bytes[5]);
 	}
 
+	diag = e1000_rar_set(hw, perm_addr->addr_bytes, 0);
+	if (diag) {
+		rte_free(eth_dev->data->mac_addrs);
+		eth_dev->data->mac_addrs = NULL;
+		return diag;
+	}
 	/* Copy the permanent MAC address */
 	ether_addr_copy((struct ether_addr *) hw->mac.perm_addr,
 			&eth_dev->data->mac_addrs[0]);
-- 
2.7.4

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2017-05-05 14:45 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-27  9:02 [dpdk-stable] [PATCH] igbvf: fix MAC address set problem Qiming Yang
2017-04-28  0:39 ` Lu, Wenzhuo
2017-04-28  6:53   ` Yang, Qiming
2017-04-28  7:20     ` Lu, Wenzhuo
2017-05-03  5:52 ` [dpdk-stable] [PATCH v2] net/e1000: fix VF " Qiming Yang
2017-05-03  7:13   ` Lu, Wenzhuo
2017-05-05 14:45     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).