From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D46B71396; Fri, 15 Sep 2017 11:18:05 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Sep 2017 02:18:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,396,1500966000"; d="scan'208";a="1172492222" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 15 Sep 2017 02:18:03 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 15 Sep 2017 02:18:03 -0700 Received: from shsmsx151.ccr.corp.intel.com ([169.254.3.98]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.117]) with mapi id 14.03.0319.002; Fri, 15 Sep 2017 17:18:01 +0800 From: "Yang, Qiming" To: Thomas Monjalon CC: "dev@dpdk.org" , "Tan, Jianfeng" , "Thotton, Shijith" , "Hu, Xuekun" , "Yigit, Ferruh" , "Patil, Harish" , Gregory Etelson , "stable@dpdk.org" Thread-Topic: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file Thread-Index: AdMsY+cDtYlICV1TTJyXdLDau5GdIP//rc+AgAAERID//0HEEIABI2YAgAAsTID//TxVwIAFL2wA//91N2A= Date: Fri, 15 Sep 2017 09:18:00 +0000 Message-ID: References: <1836615.UbEDzhAzGh@xps> In-Reply-To: <1836615.UbEDzhAzGh@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDgxOTVhZDItNzk3MC00ODk1LTllMmEtNzI0ZWIwZTFlNTI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImI2RzBMM0xqaHROYTVLUDV4MHM2dVljWWE4ek5pSnFnR2IwdDRqS1JOVzA9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Sep 2017 09:18:06 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, September 15, 2017 4:43 PM > To: Yang, Qiming > Cc: dev@dpdk.org; Tan, Jianfeng ; Thotton, Shijit= h > ; Hu, Xuekun ; Yigit, > Ferruh ; Patil, Harish ; > Gregory Etelson ; stable@dpdk.org > Subject: Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR durin= g open > and release of device file >=20 > Hi >=20 > 15/09/2017 10:04, Yang, Qiming: > > Hi, Thomas > > We meet a urgent issue because of Shijith's patch. > > When use DPDK version 17.08, DPDK VF driver and kernel PF driver, i40e,= ixgbe > and qede(Harish said) VF all meet initial failure. >=20 > This patch has been integrated in DPDK 17.08-rc2 (2 months ago). > Why a so obvious issue is discovered only now? >=20 > > This issue only occurred when use 17.08 igb_uio, vfio-pci and 17.05 igb= _uio all > works well. > > Considering this issue will block our vf driver develop and test work, = could we > revert this patch first and find another appropriate way? >=20 > We need to be sure the revert is the right solution because it will be ba= ckported > to the stable 17.08 release. >=20 > Shijith suggests to "try removing pci_reset_function from igbuio_pci_open= ." > Can we try this first? > Are we sure the bug is not in new firmwares? I have tried to remove pci_reset_function, it works in my environment, but = it doesn't work in someone's enviroment. And removing this function won't it changes the original purpose of his pat= ch? So I'm not sure it is a good solution. This bug is not a firmware version related issue, we can reproduce stably w= ith older firmware. Qiming