From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id CBD691B320; Tue, 3 Oct 2017 13:39:48 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2017 04:39:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,474,1500966000"; d="scan'208";a="1178116320" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 03 Oct 2017 04:39:47 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 3 Oct 2017 04:39:47 -0700 Received: from hasmsx108.ger.corp.intel.com (10.184.198.18) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 3 Oct 2017 04:39:46 -0700 Received: from hasmsx106.ger.corp.intel.com ([169.254.10.144]) by hasmsx108.ger.corp.intel.com ([169.254.9.167]) with mapi id 14.03.0319.002; Tue, 3 Oct 2017 14:39:44 +0300 From: "Kozak, KubaX" To: "Ananyev, Konstantin" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] acl: fix unchecked return value Thread-Index: AQHTMffRChS6yvnuZkms/FPhdVISTqLQfVmAgAGWrFA= Date: Tue, 3 Oct 2017 11:39:43 +0000 Message-ID: References: <1505901708-526-1-git-send-email-kubax.kozak@intel.com> <2601191342CEEE43887BDE71AB9772585FAA2E99@IRSMSX103.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772585FAA2E99@IRSMSX103.ger.corp.intel.com> Accept-Language: pl-PL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.103.102.53] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] acl: fix unchecked return value X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Oct 2017 11:39:49 -0000 Thanks Konstantin, I'll fix subject name and resend patch to dpdk witch Your ACK. >-----Original Message----- >From: Ananyev, Konstantin >Sent: Monday, October 2, 2017 16:22 >To: Kozak, KubaX >Cc: dev@dpdk.org; stable@dpdk.org >Subject: RE: [PATCH] acl: fix unchecked return value > > > >> -----Original Message----- >> From: Kozak, KubaX >> Sent: Wednesday, September 20, 2017 11:02 AM >> To: Ananyev, Konstantin >> Cc: dev@dpdk.org; Kozak, KubaX ; >> stable@dpdk.org >> Subject: [PATCH] acl: fix unchecked return value >> >> Add return value check and error handling for fseek call. >> >> Coverity issue: 143435 >> Fixes: 361b2e9559fc ("acl: new sample l3fwd-acl") >> Cc: konstantin.ananyev@intel.com >> Cc: stable@dpdk.org >> >> Signed-off-by: Kuba Kozak >> --- >> examples/l3fwd-acl/main.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c >> index 8eff4de..708e9eb 100644 >> --- a/examples/l3fwd-acl/main.c >> +++ b/examples/l3fwd-acl/main.c >> @@ -1026,6 +1026,7 @@ add_rules(const char *rule_path, >> char buff[LINE_MAX]; >> FILE *fh =3D fopen(rule_path, "rb"); >> unsigned int i =3D 0; >> + int val; >> >> if (fh =3D=3D NULL) >> rte_exit(EXIT_FAILURE, "%s: Open %s failed\n", __func__, @@ -1042,7 >> +1043,11 @@ add_rules(const char *rule_path, >> rte_exit(EXIT_FAILURE, "Not find any route entries in %s!\n", >> rule_path); >> >> - fseek(fh, 0, SEEK_SET); >> + val =3D fseek(fh, 0, SEEK_SET); >> + if (val < 0) { >> + rte_exit(EXIT_FAILURE, "%s: File seek operation failed\n", >> + __func__); >> + } >> >> acl_rules =3D calloc(acl_num, rule_size); >> >> -- >> 2.7.4 > >Acked-by: Konstantin Ananyev > >BTW, I think it should be l3fwd-acl inside the subject line.