patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Yongseok Koh <yskoh@mellanox.com>
To: Luca Boccassi <bluca@debian.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix handling link status event
Date: Mon, 12 Feb 2018 23:39:27 +0000	[thread overview]
Message-ID: <F78F6434-D167-41A4-BD2F-6303CE68DB02@mellanox.com> (raw)
In-Reply-To: <1518460310.17920.32.camel@debian.org>

> On Feb 12, 2018, at 10:31 AM, Luca Boccassi <bluca@debian.org> wrote:
> 
> On Mon, 2018-02-12 at 10:20 -0800, Yongseok Koh wrote:
>> [ backported from upstream commit c7bf62255edf ]
>> 
>> Even though link of a port gets down, device still can receive
>> traffic.
>> That is the reason why mlx5_set_link_up/down() switches
>> rx/tx_pkt_burst().
>> However, if link gets down by an external command (e.g. ifconfig), it
>> isn't
>> effective. It is better to change burst functions when link status
>> change
>> is detected.
>> 
>> Fixes: 62072098b54e ("mlx5: support setting link up or down")
>> Cc: stable@dpdk.org
>> 
>> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
>> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>> ---
>>  drivers/net/mlx5/mlx5.c         |   1 -
>>  drivers/net/mlx5/mlx5.h         |   1 +
>>  drivers/net/mlx5/mlx5_ethdev.c  | 118
>> ++++++++++++++++++++++++++++++----------
>>  drivers/net/mlx5/mlx5_trigger.c |  23 ++------
>>  4 files changed, 95 insertions(+), 48 deletions(-)
> 
> Hi,
> 
> 62072098b54e ("mlx5: support setting link up or down") is in 16.11, but
> this patch does not apply cleanly. Should it be backported to 16.11? If
> so, could you please take care of it?

Thank you for the email.
But, like I answered in the other email to you, you can drop this patch
because there're some missing APIs in 16.11. And it isn't a critical bug.

Yongseok

  reply	other threads:[~2018-02-12 23:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 18:20 Yongseok Koh
2018-02-12 18:31 ` Luca Boccassi
2018-02-12 23:39   ` Yongseok Koh [this message]
2018-02-12 23:49     ` Luca Boccassi
2018-02-13 11:53 ` Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F78F6434-D167-41A4-BD2F-6303CE68DB02@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=bluca@debian.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).