From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40088.outbound.protection.outlook.com [40.107.4.88]) by dpdk.org (Postfix) with ESMTP id AF888A491 for ; Tue, 13 Feb 2018 00:39:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=40iASbLanlbTdswDRM7kPUaEdzS+Fpylp/kXYE3trMk=; b=If0yB+YhU3IJJpYBMYFZBHRWzzjU/2hpOb4WyezmWH7OfjSSsxLXOE8EZDubap7YBBedi4v/j0ABs4hV8V8lYd7TfgNzpWB72H0J1zvGAICq1RObZKTAT8ue1A1E+Fgqx4oT7cxhOmKWDzdgruQQpdXnx5YXs5J474wzLxVCuuw= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2589.eurprd05.prod.outlook.com (10.168.137.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10; Mon, 12 Feb 2018 23:39:27 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::5ccf:86b:106c:a93a]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::5ccf:86b:106c:a93a%14]) with mapi id 15.20.0485.013; Mon, 12 Feb 2018 23:39:27 +0000 From: Yongseok Koh To: Luca Boccassi CC: "stable@dpdk.org" Thread-Topic: [dpdk-stable] [PATCH] net/mlx5: fix handling link status event Thread-Index: AQHTpC46/xCPgS/NFE6lZbME+lRQyaOhFyEAgABV8QA= Date: Mon, 12 Feb 2018 23:39:27 +0000 Message-ID: References: <20180212182022.36466-1-yskoh@mellanox.com> <1518460310.17920.32.camel@debian.org> In-Reply-To: <1518460310.17920.32.camel@debian.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2589; 7:w3v1fUBOw4Hgvt2JILHsnoougAdzmfpvg2AjSz0+NTnQimCGyflI1GqFiIEk1cjd/m7NDyLio5kc477UIeNTf9AfinTO0H8CpmdErEtSa3zGwjSLQd3EiKv1dcF9gITSNqO+Qx5VJZMk9XFtjyFINqdl+UODZCkFAip+hvduoQJtxf3U6M8upX/GMGDgz4olcaIIa/ZDU4lAL3HP95AmKXXF8+puWTiVtsiGUdA+gKoTuse56iC02wl972Akcc/n x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 73bd21a7-2a80-450f-31db-08d57271db2d x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:VI1PR0501MB2589; x-ms-traffictypediagnostic: VI1PR0501MB2589: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231101)(2400082)(944501161)(10201501046)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(6072148)(201708071742011); SRVR:VI1PR0501MB2589; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2589; x-forefront-prvs: 0581B5AB35 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(376002)(39380400002)(346002)(39860400002)(377424004)(189003)(199004)(43544003)(68736007)(2950100002)(5250100002)(6916009)(2906002)(33656002)(66066001)(229853002)(14454004)(82746002)(6486002)(5660300001)(97736004)(53936002)(345774005)(6246003)(25786009)(3280700002)(3660700001)(7736002)(305945005)(26005)(4326008)(478600001)(186003)(99286004)(76176011)(6506007)(53546011)(102836004)(316002)(106356001)(2900100001)(105586002)(8936002)(86362001)(6436002)(6512007)(83716003)(81166006)(8676002)(36756003)(3846002)(6116002)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2589; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: KBwvUSV3TP+jD3YTtCKULKFkeYQGqJrcTc8qUf1+/HiN6uuNOOqu0TeAdIz4csnYsdBXsaEeg12joTBfq31T/A== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <8FED929DD0CADD43B1D34E759D8C8E85@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73bd21a7-2a80-450f-31db-08d57271db2d X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2018 23:39:27.5586 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2589 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix handling link status event X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2018 23:39:28 -0000 > On Feb 12, 2018, at 10:31 AM, Luca Boccassi wrote: >=20 > On Mon, 2018-02-12 at 10:20 -0800, Yongseok Koh wrote: >> [ backported from upstream commit c7bf62255edf ] >>=20 >> Even though link of a port gets down, device still can receive >> traffic. >> That is the reason why mlx5_set_link_up/down() switches >> rx/tx_pkt_burst(). >> However, if link gets down by an external command (e.g. ifconfig), it >> isn't >> effective. It is better to change burst functions when link status >> change >> is detected. >>=20 >> Fixes: 62072098b54e ("mlx5: support setting link up or down") >> Cc: stable@dpdk.org >>=20 >> Signed-off-by: Yongseok Koh >> Acked-by: Nelio Laranjeiro >> --- >> drivers/net/mlx5/mlx5.c | 1 - >> drivers/net/mlx5/mlx5.h | 1 + >> drivers/net/mlx5/mlx5_ethdev.c | 118 >> ++++++++++++++++++++++++++++++---------- >> drivers/net/mlx5/mlx5_trigger.c | 23 ++------ >> 4 files changed, 95 insertions(+), 48 deletions(-) >=20 > Hi, >=20 > 62072098b54e ("mlx5: support setting link up or down") is in 16.11, but > this patch does not apply cleanly. Should it be backported to 16.11? If > so, could you please take care of it? Thank you for the email. But, like I answered in the other email to you, you can drop this patch because there're some missing APIs in 16.11. And it isn't a critical bug. Yongseok