From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30083.outbound.protection.outlook.com [40.107.3.83]) by dpdk.org (Postfix) with ESMTP id DB13D1B5B5 for ; Fri, 3 Aug 2018 19:32:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9NO6djgI57d/MUzIoIHTHIw3rY4sdbraTNJGnxC0FFk=; b=b/tEr9sRdMoIBac+kaF7+Y1r0AppH61/z/xxbBG8cbkap3MaJ0djHAnJxoKF/lrmx0YPazW24i7xj3eKqJVWmbt6bktnc4Y0EBkXQOLHs0ZMxkhJrQnuRA+Ho5gM+u2J7Opqb///C5JN/5EB53V0ggnLml8+GbOwtwFVyKLm+yM= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2157.eurprd05.prod.outlook.com (10.167.196.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.15; Fri, 3 Aug 2018 17:32:55 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::882c:f01c:dfb2:175]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::882c:f01c:dfb2:175%2]) with mapi id 15.20.1017.010; Fri, 3 Aug 2018 17:32:54 +0000 From: Yongseok Koh To: Hyong Youb Kim CC: dpdk stable , "johndale@cisco.com" Thread-Topic: [PATCH 17.11] net/enic: do not overwrite admin Tx queue limit Thread-Index: AQHUKuNuhkw+0FlLN0epaWMmE7w3sqSuSjyA Date: Fri, 3 Aug 2018 17:32:54 +0000 Message-ID: References: <20180803043526.21563-1-hyonkim@cisco.com> In-Reply-To: <20180803043526.21563-1-hyonkim@cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2157; 6:0FH9UGTcS4yshy4hhUfkry72/9dQ/GsUijgj3lf+JwxqBWK8JGLRY2h+0YORdIc4AT4S6RinREmZGXQuiHbT0H9rx/m28bFrbGUl+wjuUin8D3mtF5Uy5nsTacMquFu2dufqL6Y0O3gUh5rkQuNxhwyhRauxmll/Zq//cmAbKSH/SkKqDybTrhDg4xF/cx0a5xZDRMzH1oiyGpHXmBrW4ttLSzdwOFGYdw4/N38iJ3/rd8zDbh2noVvSh23BQuB1zqJqoaqcQQ08GnQ8/4VZzs20rnOuOrKHkto7w3HUPPWGisvKDShkcFX9vegnTjOiyQB5p7xFJe5WQknn0UBnJeoFxUZ5I6Jx/4/EGLuPLGaX3Dp9Xz6iU8tyXH7ku456uhNDQLiJofKMmaw0x8fzVUbBRmDx6Xr0cgZO9s7f9COnn6YRSmBkKtY3UvaA/KSoOpnaS4Loxg9Da11iC4QMog==; 5:xdfgX8NOo1PGZnw/5+XTra0yJeN84amIVJlWLxzeyI4oC514uZTB55686Hu7Dq0vyH51+RxnZHrLmBqVHzSl0v+ql+Zgk55YmwHrA5L25fHWXA7rCHNt9+IbsvmWHneKMTDKk0E1ffXRl4Tz91JqGF+FjlBHvq5eMfNSpm9G+AE=; 7:aJ0ydyUdFsjshftyryAfdahz+t5cl/jrqOf1cUyyIsOIdlXgAzucDeMsDFENmZkuzx1h8GcGHcGorrHYvoxB16Hq0AmMf6YG7kCJrwIrf4qOSSTcZ5gcNrveaT3mMPvc6aXfRtvIqin9KkBtgEa+znub0pWnxhGNy/BXIWR8hJPkvWpvirWhxxPK4jApnw0Gjg7bZZ3V5cTs8D5BQKdtuCZ7X3zwvAzM0iqhOnNutAkbZCFbR6mn6U30+3PcNIql x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: e0bdc8c0-29c0-46a1-d855-08d5f967256c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2157; x-ms-traffictypediagnostic: VI1PR0501MB2157: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(95692535739014); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(10201501046)(3002001)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123562045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:VI1PR0501MB2157; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2157; x-forefront-prvs: 0753EA505A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(39860400002)(396003)(366004)(346002)(376002)(189003)(199004)(25786009)(14454004)(486006)(14444005)(11346002)(446003)(6512007)(83716003)(53936002)(256004)(106356001)(7736002)(105586002)(2616005)(478600001)(476003)(186003)(97736004)(229853002)(26005)(81156014)(81166006)(4326008)(68736007)(8676002)(86362001)(5250100002)(3846002)(8936002)(5660300001)(2900100001)(6916009)(36756003)(54906003)(6116002)(6436002)(53546011)(82746002)(6506007)(102836004)(316002)(33656002)(6246003)(6486002)(305945005)(66066001)(2906002)(76176011)(99286004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2157; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: pCCViBp6rEVws+YRJwKufJRiBVhOPpRAuGB34kJ0zsFHNakKYrYoBdoE5xKLZPxHMiLypUPx0zR492TJMPLVHuvdq1zWwlcdYhNg3HbQeiEEwUoUwlxri3Yd9c1Yiz1UMDwAuvpNBQArQ+hTvErK+FmNfvG67Tm/3x5aBQIC0LBAr++5iK88vJX+4JzSKf4w4ce4ak6Us38kX7YK8BEjwNg1U+jjtlufK7FH4g5ljGRonTCV2fADhj5Oe6fUvYWz91pqDdjpOYVdrfTXMcFJJeyGt6hykZhcgbiVuiTLSdJ+pKOy1mF+p7c+m5Ez1isFsSGb6LO4iqpbJugrA9tW39HX4N3esbo5NI5VBebhJ3I= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <941F47BA2047A14D9B8CD90E4C01A1FF@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0bdc8c0-29c0-46a1-d855-08d5f967256c X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2018 17:32:54.6190 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2157 Subject: Re: [dpdk-stable] [PATCH 17.11] net/enic: do not overwrite admin Tx queue limit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2018 17:32:56 -0000 > On Aug 2, 2018, at 9:35 PM, Hyong Youb Kim wrote: >=20 > [ backported from upstream commit 2a7e3d54659cd12d337ad816dcf202eec1af136= 7 ] >=20 > Currently, enic_alloc_wq (via rte_eth_tx_queue_setup) may overwrite > the admin limit with a lower value. This is wrong as seen in the > following sequence. >=20 > 1. UCS admin-set Tx queue limit (config.wq_desc_count) =3D 4096 > 2. Set up tx queue with 512 descriptors > The admin limit (config.wq_desc_count) becomes 512. > 3. Stop ports and now set up Tx queue with 1024 descriptors. > This fails because 1024 is greater than the admin limit (512). >=20 > Do not modify the admin limit, and when queried, report the current > number of descriptors instead of the admin limit. The rx queue setup > (enic_alloc_rq) does not this problem. >=20 > Fixes: fefed3d1e62c ("enic: new driver") >=20 > Signed-off-by: Hyong Youb Kim > Reviewed-by: John Daley > --- Applied to stable/17.11 Thanks, Yongseok=