From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0066.outbound.protection.outlook.com [104.47.1.66]) by dpdk.org (Postfix) with ESMTP id BC8BF1DBE; Tue, 24 Apr 2018 15:53:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gYcEb/c4GQDUWXCTRj5g3GLygJRgRYR06iP+HtYDOjQ=; b=WuhbjSSCX5OGqh0BM5n6hLEz8CikKotlDXH1vL9aWuIzj3UtbFzVfeF7rF3UY7t1DvCXfWVE6t7QO33UCAvTzJXAnfnL92NTGzv5wsNsPp8LO5egjhI5/9LcVqP0MYbpC2SJoO1Pf8Yx0kXXtaO8xiDLpgVYFseyHCjDJ+ldEdY= Received: from HE1PR0501MB2314.eurprd05.prod.outlook.com (10.168.34.19) by HE1PR0501MB2204.eurprd05.prod.outlook.com (10.168.33.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.13; Tue, 24 Apr 2018 13:53:22 +0000 Received: from HE1PR0501MB2314.eurprd05.prod.outlook.com ([fe80::d405:aec8:cd2f:85cc]) by HE1PR0501MB2314.eurprd05.prod.outlook.com ([fe80::d405:aec8:cd2f:85cc%18]) with mapi id 15.20.0675.018; Tue, 24 Apr 2018 13:53:22 +0000 From: Ophir Munk To: "Hu, Jiayu" , "Ananyev, Konstantin" , "dev@dpdk.org" CC: Thomas Monjalon , Olga Shern , Pascal Mazon , "stable@dpdk.org" Thread-Topic: [PATCH v1] gso: fix marking TCP checksum flag in TCP segments Thread-Index: AQHT2kUpp26DE2UvPU2Ou46q1OX+56QNvmoAgAHdJECAACWbgIAABehwgAAUuICAAAa5AIAADdJA Date: Tue, 24 Apr 2018 13:53:22 +0000 Message-ID: References: <1524406859-29585-1-git-send-email-ophirmu@mellanox.com> <2601191342CEEE43887BDE71AB977258AEA5081C@IRSMSX102.ger.corp.intel.com> <2601191342CEEE43887BDE71AB977258AEA5221E@IRSMSX102.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0501MB2204; 7:E9I7CM1YLAdpMsZhdc4K/I9dVEB2aqEt4qPFzA+DYz1mlmZhevKKnh6ry9TiKGl13cj4ckzqyQjnZrogUL14O2s84/mXt/g2TTrfia4hqpdEJxYU5XgZfGG6UyjMiIY+/TcjxF22cZB/yRY6x4gY8N1ovmT5Cfare40mpzza0Ipl8xe9h3Q8CpgL1L3vzIlS7kv/0xFNDEukuYFk4pEiXVknSL3Jh+jSQAnAGyoH8QmP/Jyo8Kxjgz0oUJPTmqUC x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2204; x-ms-traffictypediagnostic: HE1PR0501MB2204: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231232)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041310)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:HE1PR0501MB2204; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2204; x-forefront-prvs: 0652EA5565 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39380400002)(366004)(39860400002)(376002)(346002)(189003)(199004)(51444003)(13464003)(186003)(53546011)(86362001)(53936002)(3846002)(33656002)(54906003)(110136005)(5660300001)(9686003)(66066001)(7736002)(316002)(102836004)(5250100002)(6116002)(2501003)(2900100001)(97736004)(229853002)(55016002)(26005)(14454004)(6506007)(6436002)(81166006)(81156014)(76176011)(3660700001)(3280700002)(4326008)(476003)(11346002)(7696005)(8676002)(8936002)(93886005)(2906002)(446003)(305945005)(105586002)(68736007)(6246003)(106356001)(99286004)(486006)(478600001)(25786009)(74316002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2204; H:HE1PR0501MB2314.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: rm7bTUsXjXJnvPk0vdGtRQmm42LOR80RustjXou63uM0IvIxHNmz7HLt2/AO9fNYXPQ330Aj4iP+bFlAUAc8ycHljz574308Vww6Gy3jDdJ5Dsgxs1+bHlTwbv9MQ1MREFAAuW784b74GXS48A4y074vQFD4R5c+Iy7fboG5I1mDe17NACqob+x/mEGSF1v7 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: f336b94f-ef97-48d5-13a3-08d5a9eabe62 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f336b94f-ef97-48d5-13a3-08d5a9eabe62 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2018 13:53:22.2926 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2204 Subject: Re: [dpdk-stable] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 13:53:25 -0000 Hi Jiayu, > -----Original Message----- > From: Hu, Jiayu [mailto:jiayu.hu@intel.com] > Sent: Tuesday, April 24, 2018 3:56 PM > To: Ananyev, Konstantin ; Ophir Munk > ; dev@dpdk.org > Cc: Thomas Monjalon ; Olga Shern > ; Pascal Mazon ; > stable@dpdk.org > Subject: RE: [PATCH v1] gso: fix marking TCP checksum flag in TCP segment= s >=20 > Hi Konstantin and Ophir, >=20 ...=20 > > Another possibility - might be make chages in librte_gso to allow user > > to specify what flags to set for the output packets (probably via > > rte_gso_ctx.flag) >=20 > It would be a solution. We can add flags to rte_gso_ctx.flag and the GSO > library can do some extra work (like checksum) according to the flags. >=20 I think that calculating TCP checksums by GSO library should be optional (i= f at all).=20 In my case I prefer TAP PMD to do the work which is TAP-specific. =20 My original intention in this patch was only to mark PKT_TX_TCP_CKSUM flag. > Thanks, > Jiayu > > > > Konstantin > > ...