patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Carrillo, Erik G" <erik.g.carrillo@intel.com>
To: mattias.ronnblom <mattias.ronnblom@ericsson.com>
Cc: Jerin Jacob <jerinj@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>,
	mattias.ronnblom <mattias.ronnblom@ericsson.com>
Subject: RE: [PATCH v2] doc: fix minor issues in the event timer adapter guide
Date: Tue, 1 Nov 2022 22:20:18 +0000	[thread overview]
Message-ID: <IA1PR11MB64183B6F642FD37EB3C23B72B9369@IA1PR11MB6418.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221101093340.41134-1-mattias.ronnblom@ericsson.com>

> -----Original Message-----
> From: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> Sent: Tuesday, November 1, 2022 4:34 AM
> To: Carrillo, Erik G <erik.g.carrillo@intel.com>
> Cc: Jerin Jacob <jerinj@marvell.com>; dev@dpdk.org; stable@dpdk.org;
> mattias.ronnblom <mattias.ronnblom@ericsson.com>
> Subject: [PATCH v2] doc: fix minor issues in the event timer adapter guide
> 
> In the example:
> * Properly initialize the socket id field.
> * Remove comments redundant and/or not consistent with the code. 180
>   seconds is not 2 minutes.
> * Remove redundant pointer initialization.
> * Access max_tmo_ns with the appropriate name.
> 
> In both the example and in one instance in the body text, the flags field of
> the conf struct was erroneously referred to as timer_adapter_flags.
> 
> v2: max_tmo_nsec -> max_tmo_ns fix.
> 
> Fixes: 30e7fbd62839 ("doc: add event timer adapter guide")
> Cc: erik.g.carrillo@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> ---
>  doc/guides/prog_guide/event_timer_adapter.rst | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/doc/guides/prog_guide/event_timer_adapter.rst
> b/doc/guides/prog_guide/event_timer_adapter.rst
> index 7547059a05..4cba5f1cd1 100644
> --- a/doc/guides/prog_guide/event_timer_adapter.rst
> +++ b/doc/guides/prog_guide/event_timer_adapter.rst
> @@ -107,18 +107,19 @@ to ``rte_event_timer_adapter_create()``.
> 
>  .. code-block:: c
> 
> -	#define NSECPERSEC 1E9 // No of ns in 1 sec
> +	#define NSECPERSEC 1E9
>  	const struct rte_event_timer_adapter_conf adapter_config = {
>                  .event_dev_id = event_dev_id,
>                  .timer_adapter_id = 0,
> +		.socket_id = rte_socket_id(),
>                  .clk_src = RTE_EVENT_TIMER_ADAPTER_CPU_CLK,
> -                .timer_tick_ns = NSECPERSEC / 10, // 100 milliseconds
> -                .max_tmo_nsec = 180 * NSECPERSEC // 2 minutes
> +                .timer_tick_ns = NSECPERSEC / 10,
> +                .max_tmo_ns = 180 * NSECPERSEC,
>                  .nb_timers = 40000,
> -                .timer_adapter_flags = 0,
> +                .flags = 0,
>  	};
> 
> -	struct rte_event_timer_adapter *adapter = NULL;
> +	struct rte_event_timer_adapter *adapter;
>  	adapter = rte_event_timer_adapter_create(&adapter_config);
> 
>  	if (adapter == NULL) { ... };
> @@ -145,7 +146,7 @@ to support timers of the respective type. A periodic
> timer expires at a fixed  time interval repeatedly till it is cancelled. A non-
> periodic timer expires only  once. The periodic capability flag,
> ``RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC``,
>  can be set for implementations that support periodic mode if desired. To -
> configure an adapter in periodic mode, ``timer_adapter_flags`` of
> +configure an adapter in periodic mode, ``flags`` of
>  ``rte_event_timer_adapter_conf`` is set to include the periodic flag
> ``RTE_EVENT_TIMER_ADAPTER_F_PERIODIC``. Maximum timeout
> (``max_tmo_nsec``) does  not apply to periodic mode.

Thanks for the corrections.  It looks like there's one more instance of the incorrect "max_tmo_nsec" string above.  With that last update:

Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>

> --
> 2.34.1


  reply	other threads:[~2022-11-01 22:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-01  7:45 [PATCH] doc: fix various " Mattias Rönnblom
2022-11-01  9:33 ` [PATCH v2] doc: fix " Mattias Rönnblom
2022-11-01 22:20   ` Carrillo, Erik G [this message]
2022-11-04  6:52   ` [PATCH v3] " Mattias Rönnblom
2022-11-04 10:58     ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=IA1PR11MB64183B6F642FD37EB3C23B72B9369@IA1PR11MB6418.namprd11.prod.outlook.com \
    --to=erik.g.carrillo@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).