From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E625642345 for ; Tue, 10 Oct 2023 03:43:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA429402E6; Tue, 10 Oct 2023 03:43:06 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 40C2A40278; Tue, 10 Oct 2023 03:43:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696902184; x=1728438184; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=j9oXaO9lwOEkpEZXVi4bKigNBx/E4wONLO4AJtIeFx4=; b=Rirg3MiC6KXcVmkXq9Na3sOP6K+Zu0w1uGOjXwPzpcS1SHPBWIF03+MK jdDgMxBQ5951pbrRjfuCgfdJmbZwM4mDbN1T+UXMFZAXS3me0YnQ9OQdo u76k8ynf3VBpB0/ymkUYq8HiIkJlHf5a08mdeSs6EJ4se2pZNWeHIBO8F aKJZNwG9VEgep2mKU4Bik4SccQzk+cRhoE1vqLy1yMcPdbSfqriz4Cc4t uo8atQldVAyEDGM4ldVp7o4K9UJzmbZP0Z+bgUrnJqYZvwhWHQksWP+Ju ljRmB6NaacNkRmudoBH2Cp9OR/UccO2nKP9JcjBjRjtt1k/cAUn4YgGW/ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10858"; a="369359782" X-IronPort-AV: E=Sophos;i="6.03,211,1694761200"; d="scan'208";a="369359782" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2023 18:43:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10858"; a="782698217" X-IronPort-AV: E=Sophos;i="6.03,211,1694761200"; d="scan'208";a="782698217" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Oct 2023 18:43:02 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 9 Oct 2023 18:43:02 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 9 Oct 2023 18:43:01 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 9 Oct 2023 18:43:01 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 9 Oct 2023 18:42:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dlj/W1WheSmVgs+vQs+sMt9bHrHCw/RcTCXBibt/3Hivre2wuXYACFJHuBO/m5eSwYRz8Q5ADsToRMCzuAz/U5zrSaLnawLpiOoHVAW2pmd7rS32LjKB4P5b7mh+EoOs3Xm9s3opG6+vitzCyWaCwxG5Jyu3l81s0/grIdwB9bYBVr3ANMINbI5Qb7IFfOqwTg/taMmcktrpXW4pk+AR7nFGg67DfqVzHhuAQYr98lI3tl2e5h6O67tSikyxnCMEx9eGQ+SCrxIZ5zj5qAv9v2DdEemSjCF0V8gVGPHUUacY/eunnLcoMxezMJoiHiRKcKw5SV1K2RAA3Dbgg9VOhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/ubcExq9NfQyT0NfJo18keOdpZHJwOWAkiBttPo4owI=; b=L0XE3StB2jlgpixKCBfQfnrcuYyzbdsNpsQNUWjgLSdMwhlp9ByKj9YwmnLOj4ngXV3tBWrGnT/HnMeZYTiYN2LbcHsFEFwiYePj3YIcKmTv9cKraE4KbCWw074SilhEOqpws1BxZKAI65twBeXTXd1BSgHwlkLidUMLjMQjHJii5UyOSF7uJ+9eiJ1FaWqX9MSg4yScBrcmFhHIatw8Em0l2W4EOyIFGO/mnnnfB5QODRwHREbI0zirMfgT2dxL5+UteeQnI9PsmSUFxf9g27lLpbiB2MaHj6e1BpkrkYhKcCYsSJe1av0QSSgwmTwFvskP3pjomoy3DC5/H8d6bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from LV2PR11MB5997.namprd11.prod.outlook.com (2603:10b6:408:17f::10) by DM4PR11MB6454.namprd11.prod.outlook.com (2603:10b6:8:b8::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Tue, 10 Oct 2023 01:42:53 +0000 Received: from LV2PR11MB5997.namprd11.prod.outlook.com ([fe80::f14c:380b:cbbf:a014]) by LV2PR11MB5997.namprd11.prod.outlook.com ([fe80::f14c:380b:cbbf:a014%4]) with mapi id 15.20.6838.040; Tue, 10 Oct 2023 01:42:52 +0000 From: "Xing, Beilei" To: "Zhang, Yuying" , "dev@dpdk.org" , "Zhang, Qi Z" , "Wu, Jingjing" CC: "stable@dpdk.org" Subject: RE: [PATCH v1] net/idpf: fix incorrect status calculation Thread-Topic: [PATCH v1] net/idpf: fix incorrect status calculation Thread-Index: AQHZ8clsdiWrjFwkKket7bAnnUbaF7BCUf6A Date: Tue, 10 Oct 2023 01:42:52 +0000 Message-ID: References: <20230928050520.2327245-1-yuying.zhang@intel.com> In-Reply-To: <20230928050520.2327245-1-yuying.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV2PR11MB5997:EE_|DM4PR11MB6454:EE_ x-ms-office365-filtering-correlation-id: 87497c4e-aaaa-4fda-f9e1-08dbc9323812 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yCqBzF1CiIcgeIMpPWIE+I5zau34pVNdbwzcY0z5bkuQOX0aaTvlvhBzR/d/nxwSXsqptladQflz/waZZQAesP/RU3nTaMbUxb5SgMycRlEIIrb1vkVKd2HqJn1WRSrRDa54OScpiLxA89S5oUCIj0riDfgHvxLfx8l20Fql10BJWS2ch8BI3oZpoSd9QW47uTdXaiWfVhFjtnXM09DZ/Ed4DkWT8Cg9Ph8l0FAxOvhJTCM5AtAF5sTku4gCDhrVShmbIskX0Dbl5LH08hhw+6JskQAQaYvFij8NOqgEDujb6oPX3daP9DYFVOtjyErKiO/h12KrT7dQgMBdRGc68dLGi9mXSnKXoPZgYwcnter2cjiZdz0Da2pFHcp1+kO9gC5ea44+r22VBZX4SbkVPS6Yl8KmMIPnPO4/MIKBpFe/nn/BrqDBkRF7PAP6v0UmfRbTIagyF0MIsOC0WYtw+zM7c43cvn1mJjg/0zgpOj1L9MOxDoRcA79b7qybe47QVfn4QCc0v3I1BqF3BAZfb31gA5OckFvhZuF86EugxD/FddivV3hu4aamVBsoa04cXtajDQ/JGyZRyCQe1ro+DELJfwAcaPyGbFLVrJU8UHIQGY9mnNzOXgw7J1naskZy x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV2PR11MB5997.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(346002)(39860400002)(136003)(366004)(376002)(230922051799003)(1800799009)(186009)(64100799003)(451199024)(53546011)(9686003)(33656002)(86362001)(55016003)(38100700002)(38070700005)(82960400001)(122000001)(26005)(2906002)(83380400001)(71200400001)(7696005)(6506007)(478600001)(8936002)(8676002)(4326008)(6636002)(52536014)(450100002)(316002)(41300700001)(5660300002)(110136005)(66446008)(66946007)(66556008)(66476007)(76116006)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XdacBopMgLEwdcuXrFRtUKVlMUalyUFViAIkR3YOoepg5hgUA6NUYAMiDHz+?= =?us-ascii?Q?0FsnSnDvcwiSHSWPgOPClnuC4hxHiUcBdXZA+pTcQok1C5k+UQZU4LAfASn2?= =?us-ascii?Q?toMh8BQV++6F6srM3wRNCp9FUes25b2w/dLavUQo80GK6YThkfrsz3SmbLX7?= =?us-ascii?Q?NLbx9wHb0J+crtI/k1fVqiKO6MLiVFmdQsxOlLIAKaXNHlDlGSmAaqSXsde3?= =?us-ascii?Q?DKx8Ng7OlguhFGqfUQxZelha3Lpu1zsSiNzKUMrVjcT47yBV/Mn72W8dO1i1?= =?us-ascii?Q?t+yefWH4/HymRGLlJZ/s20T217Wj/5NiuZOYiLD2q+ugZ2KrH2OX306WDuxx?= =?us-ascii?Q?WLw1DVbN02tTkVx8WIosXPlwCSm83Jd/11tLr+BoFUPQQT7rzCoIQM/2DXgA?= =?us-ascii?Q?X2Uv4qyt6W1v6lDpnMQiVhtEzUhx+lHfn9mftzKLVkfU6ntVvJ2SWy0myPGY?= =?us-ascii?Q?nwClKR/v+p6qvDOwV2ICPqxedF3Ms6iDUvlroJwPiujTs0ONKrQj2ajoDXw8?= =?us-ascii?Q?/2bNglaT6h4YAyDOyeTY+jVCsG1O68TQFZceewRacDB8u3Jao9xx2tTXKlEQ?= =?us-ascii?Q?zlyPsehcrhhsWolCLYZGIFpPLZ4pdwYswsRmHxNqb4mRCCUctXGpChOpgqVN?= =?us-ascii?Q?9hTGNSOeH3MeNsfRFh21BjPoC5k3edqqaUErI4phiat6PFwoLYRAfKkBUBL7?= =?us-ascii?Q?UPCJ0KB6wfcO653FLj+gASc0y3NetdO6FHZ2T/vCQi2YStr3ZzbGjFrb8rbi?= =?us-ascii?Q?uDzOrvu2LZtKR0WVWk82/L9FUpVAHw4AQtK/4l0bbOsI+RPDqIKPR7xylxG3?= =?us-ascii?Q?j1NcT/AVIqDoOlwN3gl9o4dPaEPQSmj5UMurwqve7l4EWcn5BGRW2ZRPGPpi?= =?us-ascii?Q?eTRQ4h2WKDEbpYPbc02C4i8dgFZ0UY2SvZylhKwhrpEHULltroXu3bncNb8I?= =?us-ascii?Q?xMM4f3FdhhTp6gGH2x6iLvP+JTkgZd0qDAjYfXUCXUWQix6b/tcm8aMBvVGs?= =?us-ascii?Q?fhOFMNZim3u9gBTEcqyWnXbA7xVm4D/iO2YrAcH7pPVWkPQtF5g0Zhz3BSV9?= =?us-ascii?Q?XYF4r4jZBED4+YplEXJtp+VRjCN3Y1avjYeJ9a8u0zOR1Ms/kIsJGR3jLBAA?= =?us-ascii?Q?nK4c0a2i+1LFizAMh0gJr/dVbep7oxugX0U1YKz3zg+rGC9VFjLRHCY6YJkE?= =?us-ascii?Q?ttdHhDiCaanUBDt0TfairNp2K09I436M6YhZ3rugkPmwwZ+DJEbfNEg5Jc1E?= =?us-ascii?Q?xcqYOtrxELNyTFlsBdhZ0414hF0zACtswfk7L+8kVqDrdGCdwUPb/lLcXRYg?= =?us-ascii?Q?ylLFoW9ATiZaYqquJ+HyP57ckCF8XSrkm1FM+AZEVWLeOrEgoSNVQTGY8LmX?= =?us-ascii?Q?otbUaoVb0OqFlvAvTsZBI4da9cIkMsEjj9y3ZKwi5eVKqOnEpnH3hz+kgN3B?= =?us-ascii?Q?JiUoUWGdOgOGIVpB/cYu3BQj7km+QNkiDPNKrgFEIlUblAXcqW6ApHKj4oSL?= =?us-ascii?Q?KfhKBpWAAqqX62OY9EmaPp/jiGywyHfE+PgX8q19rA9Evrj9XCu7y1TUkTAM?= =?us-ascii?Q?JhaUbstPDIziCLXxQ35QDy56LvDNaeIky+Ru/uhd?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV2PR11MB5997.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87497c4e-aaaa-4fda-f9e1-08dbc9323812 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2023 01:42:52.8762 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cPCnH5P0yzW7EHFSjYfrx3a9DA72u5/60HRUUZLVWYst4s2NlMK1Uh6bTxYzP7NE+hf2P2Bg8svzarRYp8Te9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6454 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Zhang, Yuying > Sent: Thursday, September 28, 2023 1:05 PM > To: Zhang, Yuying ; dev@dpdk.org; Zhang, Qi Z > ; Wu, Jingjing ; Xing, Beile= i > > Cc: stable@dpdk.org > Subject: [PATCH v1] net/idpf: fix incorrect status calculation >=20 > From: Yuying Zhang >=20 > Fix the incorrect ingress packet number calculation. >=20 > Fixes: 7514d76d407b ("net/idpf: add basic statistics") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yuying Zhang > --- > drivers/net/idpf/idpf_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethde= v.c > index 3af7cf0bb7..6ae2ac2681 100644 > --- a/drivers/net/idpf/idpf_ethdev.c > +++ b/drivers/net/idpf/idpf_ethdev.c > @@ -281,7 +281,7 @@ idpf_dev_stats_get(struct rte_eth_dev *dev, struct > rte_eth_stats *stats) >=20 > idpf_vport_stats_update(&vport->eth_stats_offset, pstats); > stats->ipackets =3D pstats->rx_unicast + pstats->rx_multicast + > - pstats->rx_broadcast - pstats->rx_discards; > + pstats->rx_broadcast; Seems rx_error is also considered in ingress packets. Same for cpfl. > stats->opackets =3D pstats->tx_broadcast + pstats->tx_multicast > + > pstats->tx_unicast; > stats->ierrors =3D pstats->rx_errors; > -- > 2.34.1