From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C7EF41BA8 for ; Thu, 2 Feb 2023 07:18:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8544D42D1D; Thu, 2 Feb 2023 07:18:58 +0100 (CET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 51539406A2; Thu, 2 Feb 2023 07:18:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675318735; x=1706854735; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Mwf1y2yZKcYusVVWtkC4oj218O1Y9vEC1mPS8MTerw8=; b=ikVvjQsNDJ6tOVkGV5CelmJWlr6kxFn+SNDNGe8HlzgV0wzodg/HCg4S VisfHj4FKpoq19POuPfrJbLj1NGaeVFdN51nYc2CgaDxRxkIxviujdKRW Tklk91Nq2+QCb2W2jcaCSNUjfQAjop0i/CrHHvGeANutzkUDs+DiqOV7I yfX6t1N+CWzLdQ59cqCMaooxylHsqDpsy5OjuvzL2NUSbc3sZiopS247F 7VcEldq5siiNIDKOOk3irNjf5g7JxMSOh48JsZVWv7lC68JkVii9WB7+p UrQ71mDsFeYn637osFRw+uskzX+T6+3A3WUT5wDmyLuBKQtqkbCaLa+bf g==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="390757051" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="390757051" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 22:18:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="658608136" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="658608136" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP; 01 Feb 2023 22:18:54 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Feb 2023 22:18:54 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Feb 2023 22:18:53 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 1 Feb 2023 22:18:53 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 1 Feb 2023 22:18:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ec6Ch2d1d2beN7mTTrL1z4YYiLv0ocpz2Bt5JTZxIXNuJnSLcytOikSJJzgBRdg6q3osJITl2ViSJ9gXGYKhS5D4oeNS1xTkAxY+wT6NcwT2svDtuNaJdXGsSXbAH2S98IU++zMHlbEzmY2TLfGiAEHO2kV8fh3TFI3Mo5+gqHsagN0FNhpiAnWpCeQhVfrauvGrSbkgAHs+wXqli+3ztgcw5CCu9+y9MaL0dW2nBvTq0c/lPY91AulK/YrfeuUomc/m2eDjbAnfi4u4aReml69lqUpBE3SR1EMlJShhBjij9CBXHaMGCtALK+WL199LC9VL/pXtK7ovPOIuwux8FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mwf1y2yZKcYusVVWtkC4oj218O1Y9vEC1mPS8MTerw8=; b=HPt7f4jUudyp2dAZbQTzYaSSN8RoI1YgrVXk+yAr+ZNHzExaABGRU12z/bru70GzFEUgsM97XrhXCO5QyZUzSlrrf5O/V9R1hQeOehAIkH6fbDpPU9J5kxGUP/W99Lq8zYImuU25USyx7rShQ0u5PffKtcpENfqnpG2n+AJJraHhITGhKqH6/B34VusefAAjaux3wol8p2mVN7nJqpDOFdjRSV6UxosxMJkEE6NRjqnDP/5aw2MGeU9FJXC0WjXzjM8iPY+31N7eXtrarpd3bm/D+TZkyHgq1YOxNhW9RPaSGGWC+DYM3f891Qv7pVsvY0+DIvH5fHqt1CAQcbnrxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from LV2PR11MB5997.namprd11.prod.outlook.com (2603:10b6:408:17f::10) by CY8PR11MB7267.namprd11.prod.outlook.com (2603:10b6:930:9a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Thu, 2 Feb 2023 06:18:45 +0000 Received: from LV2PR11MB5997.namprd11.prod.outlook.com ([fe80::19ed:7c4b:6f5a:5377]) by LV2PR11MB5997.namprd11.prod.outlook.com ([fe80::19ed:7c4b:6f5a:5377%9]) with mapi id 15.20.6064.027; Thu, 2 Feb 2023 06:18:45 +0000 From: "Xing, Beilei" To: "Ye, MingjinX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Zhou, YidingX" , "stable@dpdk.org" , "Wu, Jingjing" Subject: RE: [PATCH] net/iavf: add check for mbuf Thread-Topic: [PATCH] net/iavf: add check for mbuf Thread-Index: AQHZNTQRTNlA4Nq1nUWx6YwguvgDB667LxFg Date: Thu, 2 Feb 2023 06:18:45 +0000 Message-ID: References: <20230131051937.328725-1-mingjinx.ye@intel.com> In-Reply-To: <20230131051937.328725-1-mingjinx.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV2PR11MB5997:EE_|CY8PR11MB7267:EE_ x-ms-office365-filtering-correlation-id: cf97fb72-d435-46cc-8e14-08db04e556e1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6KtGnzW1S/MbJ4H7V04gorUwuS+qSlu+hy9PHNW7LRoid8msRcOMXoI2QPrjtN9K8uT3QCcPBTRG3Qj5IDP+zlIKoPHq3glNyXSRMl8CuD5N4qtCAtb8uhNB2/zl/JTNRkNcd4osq2XVjv45CJnsTheF8kakj4+5sUo4IOHULUD7owMZKeFt8AWId5ljrx4HeAftNzyZ93GizhOfMBSiMT3MTc2g2zBnRLp4buKT5AIaKAAHnSxExxafkfJGqM6CLJuBf1lfXHvP/DON5W45j0fX2zsq0eicisyl6LVuSsZbjlYT9GUyj/oY4rdv4rQF54XFgiL7WxQY9vSzLNNUAzqPPDIjtSPdtn4VthuGoz+yX6KwTD/PJ78+TnimIIN1DVnndnp7LfAfLyty8jDqRwd25aq9eo0gHdmWIyn2xiqWODRVtX0iXCyDVtDo2ugxdi31jj70yZPjX3qwg27rvwURNw1WS7mPO+KD+8Qr80NRaqiISGQSbDK1DOIfgBlxu7r+hw8G2OTfj0Kht4UDLpNhRESwljhkE1NnE77V1xz2KY4UN/vumlBFwDuU34V3bu4MUHwtrCVnsPHdzfiDJUP6zXInJ+HQBbDkBEp7l+gvrXdG7w98XpeCYXghhmqVS62Xw68WWAlUWhYhjaQ5FPYW3WOfHigzke1v5oilxR0gCCzPHQpPHaGNTehwpwLs x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV2PR11MB5997.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(396003)(346002)(366004)(39860400002)(136003)(451199018)(2906002)(38100700002)(33656002)(4744005)(54906003)(83380400001)(107886003)(71200400001)(316002)(52536014)(6506007)(478600001)(7696005)(9686003)(26005)(186003)(64756008)(76116006)(450100002)(38070700005)(66556008)(8936002)(4326008)(55016003)(66446008)(8676002)(41300700001)(5660300002)(86362001)(82960400001)(53546011)(110136005)(66476007)(122000001)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xTBC/+tJujN1737hPVtejY0N7No/QP4ceNgQE17ktlzQ30j2pDee/PO+VPop?= =?us-ascii?Q?ClgO8VJ47mUDK5kCMYtNo+uAKHYYhN4Vw1Lg8gWWs495U+zuxGcENoQ1wUxp?= =?us-ascii?Q?bsVXdSjAQNAmXDbwmmKi3cMDthnRrwxP66fclV77jgTbiA8Is+vozjan85z1?= =?us-ascii?Q?qufUbo1euEktgJQ77BPDNbVaVXOwyvKLAFddo/R5Q/ygNG7s59bx1cwBzc0f?= =?us-ascii?Q?r8z2Uzq2o5aYt9ZG22QTCiErKdHN6my34oMOpef4tS9ZEraFTay2H4z489y+?= =?us-ascii?Q?8sDX/GRZzlY1/Pn6tjsJ4sN1gLc+sC5ve2B2w0imL+aUvst40A7KwJCwMIp7?= =?us-ascii?Q?FiQPNss7TeuvA4foNH0S4Q6gk59nlrBAFgwIRi04I/+7DPAKVzPCpMBzxFYZ?= =?us-ascii?Q?GkjiWj0W8Gh7Ttj+WxkL/xwaGs1UpSNa6hXIGp6nHzbjr2o5fCB5NOlC2Vho?= =?us-ascii?Q?XlhOCDfQ5OHzmYg609AlhBk20HwCwvXqD6eXkPf0pcphJ35tfAnsfKx3hWN0?= =?us-ascii?Q?yS60QL0p6bbisq2vxDCIbWwx4E0aOonhWItFPrKB0Kz/aoMUrFbk6x+X5YmP?= =?us-ascii?Q?P41HVqgIKbg/C+Ox2/1I+MumLX4g4wsZmvQKIE4K1+Er5BMaTRuaURD7YheA?= =?us-ascii?Q?NLENwxcUHbgB6O+3SqBVySpsjiNbxUtkCBs26F9V+8oOF7NLn63zhXheNhTg?= =?us-ascii?Q?V15d/rr44bq/YB8IW88g20WaCMq0ApQnzHLxlGXJWcV0WdaTcmSgTVbsfcdD?= =?us-ascii?Q?lZcCsw+VCIByhg+02pQf3yQuHuD0T4sdkejQqs8eg5VW0zntSyVpj/0psToV?= =?us-ascii?Q?N7ERZUfLEhkz0l7tnbZ4ErXIPp02FnpWQb+NNgDQNRwvJPgqBXaXWmKSqU+1?= =?us-ascii?Q?bFY6iAgje9RyHAY9zqavuMSTqN7YpM8Ipdiu3aCBjoCE+vwiN2LHU5z5z05M?= =?us-ascii?Q?c0JINYHuKlah5io95GSD3a+ISRNcXq9WJbTXILHli7FEvtRfT0o098V9tFtj?= =?us-ascii?Q?C+NWyaDJTfLZ+UScnpL5ChoA1UsH+hYfMwpy4tYDuv6ByvzEa+Y3TarTljIl?= =?us-ascii?Q?HtjmOHrnVMYQyMohw9FY7RrRDWdxPdStD7MUjMXbOROxbJCkYfE3vmk0DmkL?= =?us-ascii?Q?X04kycK6KNjCRrXQaBKkWvZX527GZRw7d0CV5Qn2lmkQbycCyhxO1EjqCGtV?= =?us-ascii?Q?nPZ6uqtaHK/TTmC0ScuKNmkGP+gh0KEWVrOZjGDIQ31xUv9IYmJFMpTEUUXP?= =?us-ascii?Q?DqjFJuR3V9WQMp1aX03VIcAooJexRO52pK3hw07jPiS2Z9XiEDvUvwe1g3ri?= =?us-ascii?Q?ml9YMrUupP+EXkbBDrRSDeCZY2lcYNU2Gn4OgXjtE9X/WWarqqLYiVeL9CFb?= =?us-ascii?Q?JskxbZdmwvGwNiJJpfDR4X6jfF3GIA9Br9GVVj8U8udor+EzwHkzWcNkpHZJ?= =?us-ascii?Q?aFiY4p587ngyzXmht4DCTV4v2n/gn8y6XOSigcTijD2hJpyx2Wdk5eQOSYld?= =?us-ascii?Q?HLCQ0Wk4f8F4+MdeVal85+iqo10Mqq50QIPTf7OsaFgshUQFYJAMre089DXD?= =?us-ascii?Q?wDjiIwdBfTSBglDFhBcwl6Rw7VbchZFjkhQ2kmU0?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV2PR11MB5997.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf97fb72-d435-46cc-8e14-08db04e556e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2023 06:18:45.4545 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4E89Q5mm6y0d331KWYKX2apVnOTJ53WsbP0X3SszHGSvdbF90FwIM2ZYSk48jwtMikmaT4jCslNF7rTO8o/jag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7267 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Ye, MingjinX > Sent: Tuesday, January 31, 2023 1:20 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; Ye, MingjinX ; > stable@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Subject: [PATCH] net/iavf: add check for mbuf >=20 > The scalar Tx path would send wrong mbuf that causes the kernel driver to= fire > the MDD event. >=20 > This patch adds mbuf detection in tx_prepare to fix this issue, rte_errno= will be > set to EINVAL and returned if the verification fails. =20 I don't think PMD needs to check all packets contents, there're so many pro= tocols supported. It depends on HW capability, or application and user should make sure packe= ts accuracy. >=20 > Fixes: 3fd32df381f8 ("net/iavf: check Tx packet with correct UP and queue= ") > Fixes: 12b435bf8f2f ("net/iavf: support flex desc metadata extraction") > Fixes: f28fbd1e6b50 ("net/iavf: check max SIMD bitwidth") > Cc: stable@dpdk.org >=20 > Signed-off-by: Mingjin Ye