From: "Ma, WenwuX" <wenwux.ma@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "nipun.gupta@amd.com" <nipun.gupta@amd.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>,
"Li, Miao" <miao.li@intel.com>,
"Ling, WeiX" <weix.ling@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2] bus/pci: fix legacy device IO port map in secondary process
Date: Tue, 22 Aug 2023 02:13:22 +0000 [thread overview]
Message-ID: <MN0PR11MB6110E930DA47E5641F19C4C9EB1FA@MN0PR11MB6110.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230820195310.086bebad@hermes.local>
Hi,
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: 2023年8月21日 10:53
> To: Ma, WenwuX <wenwux.ma@intel.com>
> Cc: nipun.gupta@amd.com; dev@dpdk.org; david.marchand@redhat.com;
> maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>; Li,
> Miao <miao.li@intel.com>; Ling, WeiX <weix.ling@intel.com>;
> stable@dpdk.org
> Subject: Re: [PATCH v2] bus/pci: fix legacy device IO port map in secondary
> process
>
> On Mon, 21 Aug 2023 09:27:07 +0800
> Wenwu Ma <wenwux.ma@intel.com> wrote:
>
> > + struct vfio_device_info device_info = { .argsz = sizeof(device_info) };
> > + char pci_addr[PATH_MAX] = {0}
>
> Not sure if some tools will complain about initializing chars as zero.
> Anyway, why bother since you are using it with snprintf.
>
> Also, the new variables that are only used in the secondary case should be
> declared in that if() not for whole function.
>
>
Ok, thanks
next prev parent reply other threads:[~2023-08-22 2:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 1:58 [PATCH] " Wenwu Ma
2023-08-13 6:15 ` Gupta, Nipun
2023-08-16 1:11 ` Ma, WenwuX
2023-08-21 1:27 ` [PATCH v2] " Wenwu Ma
2023-08-21 2:53 ` Stephen Hemminger
2023-08-22 2:13 ` Ma, WenwuX [this message]
2023-08-22 2:18 ` [PATCH v3] " Wenwu Ma
2023-08-28 6:06 ` Gupta, Nipun
2023-08-29 8:00 ` Ma, WenwuX
2023-08-30 5:07 ` [PATCH v4] " Wenwu Ma
2023-09-04 15:06 ` Gupta, Nipun
2023-09-05 3:10 ` Ling, WeiX
2023-10-03 10:21 ` David Marchand
2023-10-09 3:06 ` Ma, WenwuX
2023-10-18 10:05 ` David Marchand
2023-10-18 12:38 ` Gupta, Nipun
2023-10-18 13:44 ` David Marchand
2023-10-24 2:00 ` [PATCH v5] " Wenwu Ma
2023-10-27 12:50 ` Gupta, Nipun
2023-11-14 10:24 ` [PATCH v6] bus/pci: fix legacy device IO port map Mingjin Ye
2023-11-15 11:26 ` Gupta, Nipun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN0PR11MB6110E930DA47E5641F19C4C9EB1FA@MN0PR11MB6110.namprd11.prod.outlook.com \
--to=wenwux.ma@intel.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=miao.li@intel.com \
--cc=nipun.gupta@amd.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=weix.ling@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).