patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@nvidia.com>
To: Bing Zhao <bingz@nvidia.com>,
	Slava Ovsiienko <viacheslavo@nvidia.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Ori Kam <orika@nvidia.com>,
	Dariusz Sosnowski <dsosnowski@nvidia.com>,
	Suanming Mou <suanmingm@nvidia.com>,
	Matan Azrad <matan@nvidia.com>,
	Michael Baum <michaelba@nvidia.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] net/mlx5: fix age position in hairpin split
Date: Wed, 13 Mar 2024 07:48:14 +0000	[thread overview]
Message-ID: <MN0PR12MB605646369612BD56AE5D1CD3CF2A2@MN0PR12MB6056.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20240307080924.310710-1-bingz@nvidia.com>

Hi,

> -----Original Message-----
> From: Bing Zhao <bingz@nvidia.com>
> Sent: Thursday, March 7, 2024 10:09 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; dev@dpdk.org; Raslan
> Darawsheh <rasland@nvidia.com>
> Cc: Ori Kam <orika@nvidia.com>; Dariusz Sosnowski
> <dsosnowski@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>;
> Matan Azrad <matan@nvidia.com>; Michael Baum <michaelba@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix age position in hairpin split
> 
> When splitting a hairpin rule implicitly, the count action will be on either Tx or
> Rx subflow based on the encapsulation checking.
> 
> Once there is a flow rule with both count and age action, one counter will be
> reused. If there is only age action and the ASO flow hit is supported, the flow
> hit will be chosen instead of a counter.
> 
> In the previous flow splitting, the age would always be in the Rx part, while the
> count would be on the Tx part when there is an encap.
> 
> Before this commit, 2 issues can be observed with a hairpin split:
>   1. On the root table, one counter was used on both Rx and Tx parts
>      for age and count actions. Then one ingress packet will be
>      counted twice.
>   2. On the non-root table, an extra ASO flow hit was used on the Rx
>      part. This would cause some overhead.
> 
> The age and count actions should be in the same subflow instead of 2.
> 
> Fixes: daed4b6e3db2 ("net/mlx5: use aging by counter when counter exists")
> Cc: michaelba@nvidia.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Acked-by: Ori Kam <orika@nvidia.com>
Patch applied to next-net-mlx,

Kindest regards
Raslan Darawsheh

      reply	other threads:[~2024-03-13  7:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07  8:09 Bing Zhao
2024-03-13  7:48 ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN0PR12MB605646369612BD56AE5D1CD3CF2A2@MN0PR12MB6056.namprd12.prod.outlook.com \
    --to=rasland@nvidia.com \
    --cc=bingz@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=dsosnowski@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=michaelba@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=suanmingm@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).