From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3694FA0548 for ; Wed, 8 Sep 2021 05:53:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A4404003E; Wed, 8 Sep 2021 05:53:45 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 5DE374003E for ; Wed, 8 Sep 2021 05:53:43 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10100"; a="200578243" X-IronPort-AV: E=Sophos;i="5.85,276,1624345200"; d="scan'208";a="200578243" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2021 20:53:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,276,1624345200"; d="scan'208";a="580223901" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga004.jf.intel.com with ESMTP; 07 Sep 2021 20:53:42 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 7 Sep 2021 20:53:41 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 7 Sep 2021 20:53:41 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 7 Sep 2021 20:53:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TBR5MtBujvuyPG1iNmPLdMTCGKxUSu/knx54uU6u8tYb+BnnBogrbIsBYwvLq9CnaORshvrHJApl0NDZXPxe9nL7OtgnmLzeLWaIrNeO7KWNYHGFpAW3z+YRTWvysB8LDXdgm0/bKk+t+XSJ5G6yDdECaVhAckWO/3sgy+gzgUf33lzaml88J2Hzc525DYAbMQlLsQxDsnNETsgrKzfiDcuA+Asi4QWviIbSQ+8L8Y3SKKJ7RS9jGmF+/N1Mp+a8uWKO8AK2akrWGFYsc50eVF8LlNPV9TFgewvwOiNBkGPi4paaLYit1wtutvt5ZwGy8SS0W8v8L3Z+6QblPvLzbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=IkjJnH8BIqWeNOzzhWFouJuQlREKLKtPJi8jUd9Ocus=; b=KNw8HM+zzy8ulxdxcEtAGCJw5hkWXC0SbZN9qefH0oXiaeYs8gtGQ5JRtQgqRFRrfN6oBudzpOW64g/TAgwKur0srzbsKOrMNoXK/fRVC7afbDsmxeqQvRQZuM+zir927vNNScIuYgd8PsDg7hJynNHWUarWVBvqw05hB3jsK6L4TPr8iZsZavugYBHqe7/ekKo/JLTBiWkjyRSdcyY9YHMhwSWPAumQRLwMHRC9WRmbavDpMSt7qB/lmCZNUDJi9Wgl4n0dGMON7tMyaUsKPR/tCmrVpggDSaF1sDqebfWYYv41dvrTYyo0cjHl5Puo9YNWPAOqcUaZDn9H0WZi9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IkjJnH8BIqWeNOzzhWFouJuQlREKLKtPJi8jUd9Ocus=; b=dRezXzpWYVnSp+uIUUJYL69w05V11SmQ2Ut3VyWtnpzeceSU46zHI2MMhgOExPHp1KcVMEucfvhQSklo3fobGcE+PkkCbRG4/cOvaaaAIpWpWJIV6OJ4ylJkoblO3IYiQR433jg9O4NhkBRCVre0ECgWd0+rKM5Iq8Qglnc7x40= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB3886.namprd11.prod.outlook.com (2603:10b6:208:137::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 8 Sep 2021 03:53:35 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::197b:884c:3d10:ee6a]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::197b:884c:3d10:ee6a%5]) with mapi id 15.20.4478.025; Wed, 8 Sep 2021 03:53:35 +0000 From: "Xing, Beilei" To: Qiming Chen , "stable@dpdk.org" Thread-Topic: [PATCH 20.11] net/i40e: fix vf resource leakage problem Thread-Index: AQHXou6eOPLZkf7fdUWYuleVu2quxauZhBSg Date: Wed, 8 Sep 2021 03:53:34 +0000 Message-ID: References: <20210906071156.9813-1-chenqiming_huawei@163.com> In-Reply-To: <20210906071156.9813-1-chenqiming_huawei@163.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: 163.com; dkim=none (message not signed) header.d=none;163.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2cac49bb-a648-4fca-0b3d-08d9727c3b98 x-ms-traffictypediagnostic: MN2PR11MB3886: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1227; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rhhs9ugpdqsJ3J5ri8DW3rqG0/OKqDXVCOLdCInPj+IueJ92VaRIpqQ6NEyo1aq12/K6Ai/xvfYjxEyLEN02lFEDZjKeftgKAaj+9Yv6nz5eRP+Av5rkcctRUZyrBgX9ZZ7i3OJLIkj/fEFpTQnOOfC10vk20F6noi2fyH8CUZlUIh13AdnfUyUQDMdq+Lp3BxrzNIwzeni9S+lI4xnNsYQRU6P3Lw6Xotb1bai6hrocKjrbm62tl8zwEzIm+UDRvxNdRW0LbyGuMR0D3zG2UHW7BeJxeBNRHFIzl2T9eMDDV0lxWySknCZrScFSi+w/1d2hSWu0v/yxJWjWz2DCu7ojW/KNDLxBABExPbX7JklKsTcX6tTwoV7Rt7Upifu6m0SYNqjs43sgA+v7PBDZBZSGgH2ZzjUjBQYlBmc32bCrNWQJ64ojpQDP87pYZKCxDRJXPry3tJterwaw+aP6leVrt4lJJ4AeR9cDX5dq9kzhN975MpmFC6sB+vl7d49FkrYfAUy5sN1ZZWIzucQxXl9WJpPViid2kjekKYCi4R9MGxQgRd2iVnIETGbVZkXnTW83GOjgC+CLYDGb7pTiyON1c2Oc/op13CMNE5uGb3G3/meYrexpdOAMs8U7mOmk6XbyC4WdxL1qhFLSAH+yCBv/c1aJRijhJL6tF++9dyb6LmZ9WMzZeQFkxSn69W+TFNRZxwD6huN/d651XPbDKg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(396003)(366004)(376002)(346002)(2906002)(33656002)(66446008)(66476007)(64756008)(8676002)(38070700005)(66556008)(66946007)(110136005)(83380400001)(26005)(6506007)(71200400001)(316002)(8936002)(55016002)(5660300002)(53546011)(186003)(76116006)(478600001)(86362001)(38100700002)(52536014)(122000001)(7696005)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hxJibZe6XgjC9MVww9hizpB/vFsmaegqPLKyifuoSUszzYKwAIgh4r3WQZsR?= =?us-ascii?Q?Ins05i7jH7ylv0y0hyY5ODcsi+qndPW3un3UMnaJUC+HQ0XOUqIlUS7XTMty?= =?us-ascii?Q?kGwq5WOB1BBhunbHKz/4hpYIMjN/E9Zj0opjHKNfEDdpOemsZFAlcBmqjvuc?= =?us-ascii?Q?nWy/M43IM2/mfIXxXSuDdp7Ovj4dgaQUR5zyZy7VqJJ3kw/0QseTGsuGf/As?= =?us-ascii?Q?BlBVTL1nn+Q3utS5kNMrFoIEXy8IVFsropBExzvJVdhBoiCegVSZjpLjA747?= =?us-ascii?Q?RlUkKBeMcF1VW3oqEZnLs3tFszByRFVPCZloCovdgN2fENDrde1R0HJqkN6J?= =?us-ascii?Q?nPHa7tsNwCuQBeMXrOiBYyyQPnyo3x/RzpvfXXfxU5SdvWOQxp3p8Vxbphkk?= =?us-ascii?Q?kgPO95KhKkkAMNerFPlIOIB3jIe9vIDOab5ostd+Q6fumQVHqPcmHCCRk6av?= =?us-ascii?Q?C/KuDvtXM6Pc4JfjUzY9EFyv58hfYGhQuKHCmLZp+teOkh/p8sPObxgTZes1?= =?us-ascii?Q?TKkiCV6Y5LjB4rTQM0AVdqRPjxAC2CnBm/LxjKwMzpX/5sluD3AsW8YYAxLD?= =?us-ascii?Q?3Rro7U++5gvxmIc5kPEw/08tPqjSwCDcp7Uvurn/PnqXpsPSMB25fHlgHvOm?= =?us-ascii?Q?4XA4fRfytJx5x6h8F8rP5IjC4XyF4mFJTSn0FxCd+maKKjG78htFMGjU94BK?= =?us-ascii?Q?Iicnx8B9cXD6b02RNypbBJvIWgt3f8tAlgBnsVf4tcaI/zevis5ggmAMAfow?= =?us-ascii?Q?Z3WLQ5VF87FYMcEEuc4O7alh9bgzpnaLFOs+Bcxq4GgVm/SShd/DpSVm3tP8?= =?us-ascii?Q?YJ/xhDnYmJI0SUkjOApr2QdMp3XnAXZAGWaDA2UdF+WJVYNqmTX6ylFtKrk2?= =?us-ascii?Q?efgT7CElJDDeCrBZ+JALqw0SqCEPU6xvBPsSoYfcO4g1dxKAhy3fKPG1k305?= =?us-ascii?Q?zzE16qsubA6pQZU3D/klEcdnkmHPfVUBI7dd1dBhHGCXEnGG0CyWD9Q5mhYZ?= =?us-ascii?Q?NhInl3VxNdhRBWM6Wnd7BLIDz+Qodt09xHS/xhLsuBL+4xOx8OB5S6fHSoug?= =?us-ascii?Q?uW/q/439diuKnKlCVV2yoUkEtFESfzfPTl1LGSsOYrOT9I7jdc4vwUZH1Oms?= =?us-ascii?Q?WtQKJnete5w+wI0o7TJ1lBxPg3+qlWWRLVbpv2FS2wo6tYR7RFjmpCUkY8HR?= =?us-ascii?Q?r9QWvBQ4VJPHJpmb3HDVXTFYOKQO2aT6ihbitlRsUo2fThGsP/bYZDXFxhp+?= =?us-ascii?Q?a/9XrB6fBvlbJ5EiB34nQ7OXoHrkCkw3JNfZiJWzcxhfeeN2d5hoySju75J1?= =?us-ascii?Q?5GPFil579NMitKuxagauGWTr?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2cac49bb-a648-4fca-0b3d-08d9727c3b98 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2021 03:53:34.9178 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sob/AXbRsZ8PaiPpukOujDk+5MLH7qx+HxNB0N6AVIiwKNR/AM03SLxBOpWzPd0T32+qN6j7ocrjq8SQssYWsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3886 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH 20.11] net/i40e: fix vf resource leakage problem X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Qiming Chen > Sent: Monday, September 6, 2021 3:12 PM > To: stable@dpdk.org > Cc: Xing, Beilei ; Qiming Chen > > Subject: [PATCH 20.11] net/i40e: fix vf resource leakage problem Please also refine the title. >=20 > In the i40evf_dev_init function, when the MAC memory alloc fails, the > previously initialized vf resource is not released, resulting in leakage. > The patch calls the i40evf_uninit_vf function in the abnormal branch to > release resources. >=20 > Fixes: 5c9222058df7 ("i40e: move to drivers/net/") The fix commit should be " i40e: new poll mode driver". > Cc: stable@dpdk.org >=20 > Signed-off-by: Qiming Chen > --- > drivers/net/i40e/i40e_ethdev_vf.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index 003d41373b..f64db72e9a 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -1622,6 +1622,7 @@ i40evf_dev_init(struct rte_eth_dev *eth_dev) > PMD_INIT_LOG(ERR, "Failed to allocate %d bytes needed to" > " store MAC addresses", > RTE_ETHER_ADDR_LEN * > I40E_NUM_MACADDR_MAX); > + (void)i40evf_uninit_vf(eth_dev); > return -ENOMEM; > } > rte_ether_addr_copy((struct rte_ether_addr *)hw->mac.addr, > -- > 2.30.1.windows.1