* [dpdk-stable] [PATCH] net/iavf: fix symmetric rule creating
@ 2021-01-22 3:19 Xuan Ding
2021-01-22 4:05 ` Xing, Beilei
0 siblings, 1 reply; 4+ messages in thread
From: Xuan Ding @ 2021-01-22 3:19 UTC (permalink / raw)
To: qi.z.zhang, jingjing.wu, beilei.xing; +Cc: dev, Xuan Ding, stable
Only allow to create symmetric rule for L3/L4.
Fixes: 91f27b2e39ab("net/iavf: refactor RSS")
Cc: stable@dpdk.org
Signed-off-by: Xuan Ding <xuan.ding@intel.com>
---
drivers/net/iavf/iavf_hash.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c
index 958c73c4fb..5fa2f3cf59 100644
--- a/drivers/net/iavf/iavf_hash.c
+++ b/drivers/net/iavf/iavf_hash.c
@@ -927,6 +927,13 @@ iavf_any_invalid_rss_type(enum rte_eth_hash_function rss_func,
if (rss_type & (ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY |
ETH_RSS_L4_SRC_ONLY | ETH_RSS_L4_DST_ONLY))
return true;
+
+ if (!(rss_type &
+ (ETH_RSS_IPV4 | ETH_RSS_IPV6 |
+ ETH_RSS_NONFRAG_IPV4_UDP | ETH_RSS_NONFRAG_IPV6_UDP |
+ ETH_RSS_NONFRAG_IPV4_TCP | ETH_RSS_NONFRAG_IPV6_TCP |
+ ETH_RSS_NONFRAG_IPV4_SCTP | ETH_RSS_NONFRAG_IPV6_SCTP)))
+ return true;
}
/* check invalid combination */
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH] net/iavf: fix symmetric rule creating
2021-01-22 3:19 [dpdk-stable] [PATCH] net/iavf: fix symmetric rule creating Xuan Ding
@ 2021-01-22 4:05 ` Xing, Beilei
2021-01-25 12:46 ` Zhang, Qi Z
0 siblings, 1 reply; 4+ messages in thread
From: Xing, Beilei @ 2021-01-22 4:05 UTC (permalink / raw)
To: Ding, Xuan, Zhang, Qi Z, Wu, Jingjing; +Cc: dev, stable
> -----Original Message-----
> From: Ding, Xuan <xuan.ding@intel.com>
> Sent: Friday, January 22, 2021 11:19 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Ding, Xuan <xuan.ding@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/iavf: fix symmetric rule creating
>
> Only allow to create symmetric rule for L3/L4.
>
> Fixes: 91f27b2e39ab("net/iavf: refactor RSS")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
Acked-by: Beilei Xing <beilei.xing@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH] net/iavf: fix symmetric rule creating
2021-01-22 4:05 ` Xing, Beilei
@ 2021-01-25 12:46 ` Zhang, Qi Z
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Qi Z @ 2021-01-25 12:46 UTC (permalink / raw)
To: Xing, Beilei, Ding, Xuan, Wu, Jingjing; +Cc: dev, stable
> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Friday, January 22, 2021 12:05 PM
> To: Ding, Xuan <xuan.ding@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH] net/iavf: fix symmetric rule creating
>
>
>
> > -----Original Message-----
> > From: Ding, Xuan <xuan.ding@intel.com>
> > Sent: Friday, January 22, 2021 11:19 AM
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing
> > <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> > Cc: dev@dpdk.org; Ding, Xuan <xuan.ding@intel.com>; stable@dpdk.org
> > Subject: [PATCH] net/iavf: fix symmetric rule creating
> >
> > Only allow to create symmetric rule for L3/L4.
> >
> > Fixes: 91f27b2e39ab("net/iavf: refactor RSS")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> Acked-by: Beilei Xing <beilei.xing@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-stable] [PATCH] net/iavf: fix symmetric rule creating
@ 2021-01-19 10:32 Xuan Ding
0 siblings, 0 replies; 4+ messages in thread
From: Xuan Ding @ 2021-01-19 10:32 UTC (permalink / raw)
To: qi.z.zhang, jingjing.wu, beilei.xing; +Cc: dev, Xuan Ding, stable
Do not allow to create symmetric rule only if l3/l4 src/dst_only is set.
Fixes: 91f27b2e39ab("net/iavf: refactor RSS")
Cc: stable@dpdk.org
Signed-off-by: Xuan Ding <xuan.ding@intel.com>
---
drivers/net/iavf/iavf_hash.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c
index 958c73c4fb..fd6556c1a3 100644
--- a/drivers/net/iavf/iavf_hash.c
+++ b/drivers/net/iavf/iavf_hash.c
@@ -924,8 +924,8 @@ iavf_any_invalid_rss_type(enum rte_eth_hash_function rss_func,
* hash function.
*/
if (rss_func == RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) {
- if (rss_type & (ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY |
- ETH_RSS_L4_SRC_ONLY | ETH_RSS_L4_DST_ONLY))
+ if (!(rss_type & (ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY |
+ ETH_RSS_L4_SRC_ONLY | ETH_RSS_L4_DST_ONLY)))
return true;
}
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-25 12:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-22 3:19 [dpdk-stable] [PATCH] net/iavf: fix symmetric rule creating Xuan Ding
2021-01-22 4:05 ` Xing, Beilei
2021-01-25 12:46 ` Zhang, Qi Z
-- strict thread matches above, loose matches on Subject: below --
2021-01-19 10:32 Xuan Ding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).