patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Power, Ciara" <>
To: "Richardson, Bruce" <>,
	"" <>
Cc: "Burakov, Anatoly" <>,
	"" <>,
	David Marchand <>
Subject: Re: [dpdk-stable] [PATCH] telemetry: fix "in-memory" process socket conflicts
Date: Wed, 22 Sep 2021 08:43:12 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Bruce,

>-----Original Message-----
>From: Richardson, Bruce <>
>Sent: Wednesday 15 September 2021 15:11
>Cc: Power, Ciara <>; Burakov, Anatoly
><>; Richardson, Bruce
><>;; David Marchand
>Subject: [PATCH] telemetry: fix "in-memory" process socket conflicts
>When DPDK is run with --in-memory mode, multiple processes can run
>simultaneously using the same runtime dir. This leads to each process
>removing another process' telemetry socket as it started up, giving
>unexpected behaviour.
>This patch changes that behaviour to first check if the existing socket is active.
>If not, it's an old socket to be cleaned up and can be removed. If it is active,
>telemetry initialization fails and an error message is printed out giving
>instructions on how to remove the error; either by using file-prefix to have a
>different runtime dir (and therefore socket path) or by disabling telemetry if it
>not needed.
>Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")
>Reported-by: David Marchand <>
>Signed-off-by: Bruce Richardson <>
> lib/telemetry/telemetry.c | 25 ++++++++++++++++++++-----
> 1 file changed, 20 insertions(+), 5 deletions(-)

Patch looks good overall, although I see CI is reporting some problems for FreeBSD:

../lib/telemetry/telemetry.c:435:21: error: incompatible pointer types passing 'struct sockaddr_un *' to parameter of type 'const struct sockaddr *' [-Werror,-Wincompatible-pointer-types]
                if (connect(sock, &sun, sizeof(sun)) == 0) {
/usr/include/sys/socket.h:662:41: note: passing argument to parameter here
int     connect(int, const struct sockaddr *, socklen_t);
1 error generated.


  reply	other threads:[~2021-09-22  8:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 14:10 Bruce Richardson
2021-09-22  8:43 ` Power, Ciara [this message]
2021-09-24 16:18 ` [dpdk-stable] [PATCH v2] " Bruce Richardson
2021-09-29  8:50   ` Power, Ciara
2021-09-29 12:28   ` [dpdk-stable] [dpdk-dev] " Kevin Traynor
2021-09-29 13:32     ` Bruce Richardson
2021-09-29 13:51       ` Bruce Richardson
2021-09-29 14:54       ` Kevin Traynor
2021-09-29 15:24         ` Bruce Richardson
2021-09-29 15:31           ` Bruce Richardson
2021-09-29 16:01             ` Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).