From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BF81A0548 for ; Wed, 29 Sep 2021 10:50:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37CD5410EC; Wed, 29 Sep 2021 10:50:54 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id EFAC140E3C; Wed, 29 Sep 2021 10:50:51 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10121"; a="211977837" X-IronPort-AV: E=Sophos;i="5.85,331,1624345200"; d="scan'208";a="211977837" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2021 01:50:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,331,1624345200"; d="scan'208";a="617348125" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga001.fm.intel.com with ESMTP; 29 Sep 2021 01:50:50 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 29 Sep 2021 01:50:50 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 29 Sep 2021 01:50:50 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 29 Sep 2021 01:50:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mwbODIRXIAcoh/wV95jNTGnupEfU46h1Y9lew9PfOwQTnojadDAeYAiKYTjbjEYxQF3sKnUhGqfCl0Wf3gvLvNA4Km1iNufTbSN+4a+4TSto6XBYe2erpveFMwQ/yfuT9VxWaCrNezRRKHmTkPOWk5pJ9iheicb2XkTKpayCLghXW7p03k+Um1++zCCIms34jR085MtBYt5NVD5vaxl7fowYzlYm0hIifTTh1kkbsZqb0VjceaEJwrZbQyrbuXX4a+97t+jLZ2BTtTpSyp1NcStFnQKrznl0nTlJvRyP6yP39u1bIrcEtGSBVUsp+3HT2fndKlafJ5e3Qg14a8Ab/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=n4KM+mR1/lsU4ULziWm9/IMjSFD8Xo1jEJVMS2l7j3c=; b=CYywhQ4HMbSvYo+59D+eNfon6O+T2Q41mtetPi9kBEMI2vWDoa4FHQ8/0a8r/4cjH0Udgupqy+3WVJ+ygPSAa/DynVxWXKn1opwV5XQOw9Fmx1DK2ZrCxdcCFnjxMBwzxsc5VMxJuOBWxJaGEB/W/EWLHvqsVyJf2JhI6zL/4ZYXBjug8LZiQyUBB5yKBvVRAMGFDJkpYZJUxeYZjDRnY+x7UOInhS1KZRbzxOKz6ch2g6S8eXbBJrYL82LaESXR0O0hiO3RRo9O966mQefed0da9oywPx0ufYjJwGOr9QllEQ10qgkjtp+Hg5LlrRjjNOqCHVYaka4VNKmf0aSyAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n4KM+mR1/lsU4ULziWm9/IMjSFD8Xo1jEJVMS2l7j3c=; b=an+VW1dvmMHhpKr1w8kQZ5HVFCrFX0XgODklVk0jMlHQ7JM59X4CfG2Tp6W2R4HbWwO1C2zagDfHbygSJAZzT9Hmy5L24701WreS/4/RLDMwy3b1aAjOLm5Pbl3FJK1hN7toTZ08mTxScro+OfjzjLZTkSE4hJ+kQ+f231DwrWE= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB3999.namprd11.prod.outlook.com (2603:10b6:208:154::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Wed, 29 Sep 2021 08:50:41 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2%6]) with mapi id 15.20.4566.014; Wed, 29 Sep 2021 08:50:41 +0000 From: "Power, Ciara" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Burakov, Anatoly" , "stable@dpdk.org" , David Marchand Thread-Topic: [PATCH v2] telemetry: fix "in-memory" process socket conflicts Thread-Index: AQHXsV/q74NfN5mYV0CBZ/e0uQytiKu6u0uA Date: Wed, 29 Sep 2021 08:50:40 +0000 Message-ID: References: <20210915141030.23514-1-bruce.richardson@intel.com> <20210924161842.2879019-1-bruce.richardson@intel.com> In-Reply-To: <20210924161842.2879019-1-bruce.richardson@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 853a634c-f29d-4d21-9768-08d98326378b x-ms-traffictypediagnostic: MN2PR11MB3999: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TtWS4RIz5hc1oJJ0eAXlvqj04YrUO0iplrg4GOaYaCrLheIhKRiFnZj+rlJ8hKxyn5TPEf8SVtjBZM+RSYpd0uv4RpDMd318bfOEJOXvWH0F1xbtfS9qVcPV9i6PZ3the9OnknXCnUZfvQaH8BSzT7L2OskEtaAgqs7cDMSSqrHk3u0K/uGWKjGwp9TZLXcp7kdDfFvwGRM8r7MQzRnAGdzyMTeBhI3PUlbBcZ5agTl4yBEOWs21+X9VTMCySOmSSLNAZNTSNk9HX8WXM8ITBUDfWBjruP2n4QMaORcmzzIeMVmjbniq8dpNV3yJ5gp5GHtnnYVY/POw8q1OtaOZQ8SkLeTNsGBw2MlcNHy2q+k5bbGgcXRwN8JSv+RuAg0Phpj0dIa8T2PvHzzsNghQTLLSxCuhRCcfU8tZeVCW7oRcqcpRZAXEzZplZg7hCU5PFsZDlPYl3WaTpW1QfS4kJ9ZJ8AryhObjpC2h3qkseK/CJulTTS0JL50+G1JKed25WjWQoTt0kzyrQSahfO4mOw7Y5fW3vB7ARzUwI1nNFYdyY7z/DCuBsKeAKmkSK0v39T7g+Qa1DAdPWim7qin4x4z6CoWorscCMYir4ByZk3FeXl+avC0xsxVuSaNNZvxCH82koknh91VqEWVLY4xAECWdvS5riNEl8bNdDW+1Ns3ezVyY2pnqcgJ51/IaMmK72tMSubpPx+AzX/b9Vg+iGw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(316002)(38100700002)(71200400001)(38070700005)(110136005)(54906003)(7696005)(4326008)(122000001)(33656002)(83380400001)(5660300002)(508600001)(76116006)(8676002)(8936002)(86362001)(66446008)(55016002)(52536014)(2906002)(186003)(66946007)(9686003)(64756008)(66556008)(66476007)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SaxGjvZUAiM0mX/MxNAv/egkriSD6xx64gTEFKvnN+h0LPijagmJh2u4dovo?= =?us-ascii?Q?44ov+t10RWYXRUaguM8Ry1e8DdH264Cr9W76eFr3/wQGbwpTPZfeNvdEUO4J?= =?us-ascii?Q?hc4McHbyPkymd/jKabauTyR8wENxKYyHDXZvIBbr9HJVeiiOSglrHu8CTb3w?= =?us-ascii?Q?Qq3QWy/KarRRjPV9xwz/+SGNvd074zdilK4gvzgpxRNrGdvnsCF2p0gl/l2F?= =?us-ascii?Q?nPEgMf9pb09J2peEmtuJ0Jgp7TzEImLSjCXemj3SRLhanCvuSSBtn0zQoJxQ?= =?us-ascii?Q?8pCyE81e2rzScRQqn4DXZ5b8iTUqsAbQb7iU/U/rwSrj+sk0xzHyib8zFhga?= =?us-ascii?Q?0brE6BccusZ2HkrW43m0bVP6/WfIF43/LnOPmVftoNJIKj02nntMXTVifk3u?= =?us-ascii?Q?W6CMfDOLDCd4IqiSlpAnvRBtybcCUkhof6OuiAOBeHinH0ppD+BcofDvA79/?= =?us-ascii?Q?SwLhyeAah1EUfIvEGWhG5Sr/biRjYHMsJMpNvFQYOAqA8zLKF2j9ckcnfVZ3?= =?us-ascii?Q?5AAXKL/RWGBnT1jPfy6pus1GGP6Z6kgiWJjftXllfRtTqPCcxtGlK47l4j8g?= =?us-ascii?Q?8pbTPtxzvxz6zGBSuV/ats3p+l8a6YK8APTPEoU56rhr07VXCFy599yih2yJ?= =?us-ascii?Q?8d8++vM5rOfIoPHI6qRDXA0tJMP2KshngB5uVc3jLxQuTJnNh/c+2gZ5zLq7?= =?us-ascii?Q?uI5RK2B5yjulhtCkW/hRecsvyK6ZaCZdNbN3Ikwd1yeAoOGRcKCNJByxcOeZ?= =?us-ascii?Q?PF6BuOZG/XHgvCVgFzCl6/N0NrCSHvsDC4xyPE34iS9V+Su3CEc/fLcrUcST?= =?us-ascii?Q?WWpvA4IYuIytseyuYh9jDJnc6leO5PRgLx9ggq/i7DVsr3rbRwMJeiobFZls?= =?us-ascii?Q?d1d2EnL3eTz17SAJ5m0AqhnVyyV+Xbfmr1dRmu2ALJuiY9N0EduExCoZaitZ?= =?us-ascii?Q?I7OH6whYJQdMmQKUzyy/nKhhxg70y8j1lgFUOVgDwGjRb78vDq678TbyI0mg?= =?us-ascii?Q?VF9HGvBootswTTGPVLBaCd2WY3YvNuLeYST1as6+OTRGgzORaD4b2u8kTVRV?= =?us-ascii?Q?yG2vzov19E1d/7OVor6E9zgK4FGDBKWqmihvVQGFuLq8dznVuY/Lq4Na3MPo?= =?us-ascii?Q?LCrvBp9cc1/lIMjlSK+lXQeWEbI9ZHbBJaq4Wvly25AMgz4PDxLFjACE5TyF?= =?us-ascii?Q?2TpdYXNucrFpNsAFjcWp1QUHWcdfyH91/ncMkjgl7OSAZOn/6dUZxOYUDwIe?= =?us-ascii?Q?0yNog/wjP6G7u26gG2mycnRynWu+05QFIz0+mqyN9UPxRUSJKJP8xV4zYLW7?= =?us-ascii?Q?WIHDHMDabxwl2q5Ke38rh5h94/rVGdxpKr3/TtE+/7PafIYtitc04Abxxxbi?= =?us-ascii?Q?wFWxpscjPFxwjE+FTfqZHVL2xIpu?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 853a634c-f29d-4d21-9768-08d98326378b X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2021 08:50:40.9289 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nB8akkMadptlr+fWjAgMgM9F1oN7xSL7WDQpnn86iPr2Uf0Kvog11DGZhN2O8KZ0r1Yl7qhsGo5hOhP16EA86A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3999 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v2] telemetry: fix "in-memory" process socket conflicts X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Bruce, >-----Original Message----- >From: Richardson, Bruce >Sent: Friday 24 September 2021 17:19 >To: dev@dpdk.org >Cc: Power, Ciara ; Burakov, Anatoly >; Richardson, Bruce >; stable@dpdk.org; David Marchand > >Subject: [PATCH v2] telemetry: fix "in-memory" process socket conflicts > >When DPDK is run with --in-memory mode, multiple processes can run >simultaneously using the same runtime dir. This leads to each process >removing another process' telemetry socket as it started up, giving >unexpected behaviour. > >This patch changes that behaviour to first check if the existing socket is= active. >If not, it's an old socket to be cleaned up and can be removed. If it is a= ctive, >telemetry initialization fails and an error message is printed out giving >instructions on how to remove the error; either by using file-prefix to ha= ve a >different runtime dir (and therefore socket path) or by disabling telemetr= y if it >not needed. > >Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") >Cc: stable@dpdk.org > >Reported-by: David Marchand >Signed-off-by: Bruce Richardson >--- >v2: fix build error on FreeBSD >--- Acked-by: Ciara Power Thanks!