From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: "Xueming(Steven) Li" <xuemingl@nvidia.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>, "Ding, Xuan" <xuan.ding@intel.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3 3/3] vhost: fix fd leak in kick setup
Date: Wed, 11 Nov 2020 07:57:40 +0000 [thread overview]
Message-ID: <MN2PR11MB40638B1C4F307337862EAFD49CE80@MN2PR11MB4063.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BY5PR12MB4324FA1AC3E16DE50ECB211FA1E80@BY5PR12MB4324.namprd12.prod.outlook.com>
Hi Xueming & Maxime,
> -----Original Message-----
> From: Xueming(Steven) Li <xuemingl@nvidia.com>
> Sent: Wednesday, November 11, 2020 2:02 PM
> To: Maxime Coquelin <maxime.coquelin@redhat.com>; dev@dpdk.org; Ding, Xuan
> <xuan.ding@intel.com>; stephen@networkplumber.org; NBU-Contact-Thomas
> Monjalon <thomas@monjalon.net>; stable@dpdk.org; Xia, Chenbo
> <chenbo.xia@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v3 3/3] vhost: fix fd leak in kick setup
>
> Hi Maxime,
>
> Near end of this function, if vhost_check_queue_inflights_packed() and
> vhost_check_queue_inflights_split() return with error, is the fd expected
> to be
> closed by closing vq?
I thought about this before. In theory, it will not cause fd leak because the fd
is saved in vq. It will be closed upon next kick msg or vhost device destroy. But
thinking it again, maybe it's better to close it now since anyway it's useless now😊
What do you think?
Thanks,
Chenbo
>
> >-----Original Message-----
> >From: dev <dev-bounces@dpdk.org> On Behalf Of Maxime Coquelin
> >Sent: Monday, November 9, 2020 8:17 PM
> >To: dev@dpdk.org; xuan.ding@intel.com; stephen@networkplumber.org;
> >NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; stable@dpdk.org;
> >chenbo.xia@intel.com
> >Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> >Subject: [dpdk-dev] [PATCH v3 3/3] vhost: fix fd leak in kick setup
> >
> >This patch fixes a file descriptor leak which happens in the error path
> of
> >vhost_user_set_vring_kick().
> >
> >Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> >Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
> >---
> > lib/librte_vhost/vhost_user.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> >diff --git a/lib/librte_vhost/vhost_user.c
> b/lib/librte_vhost/vhost_user.c index
> >94b066f0b9..f3b2adabac 100644
> >--- a/lib/librte_vhost/vhost_user.c
> >+++ b/lib/librte_vhost/vhost_user.c
> >@@ -1855,8 +1855,12 @@ vhost_user_set_vring_kick(struct virtio_net **pdev,
> >struct VhostUserMsg *msg,
> >
> > /* Interpret ring addresses only when ring is started. */
> > dev = translate_ring_addresses(dev, file.index);
> >- if (!dev)
> >+ if (!dev) {
> >+ if (file.fd != VIRTIO_INVALID_EVENTFD)
> >+ close(file.fd);
> >+
> > return RTE_VHOST_MSG_RESULT_ERR;
> >+ }
> >
> > *pdev = dev;
> >
> >--
> >2.26.2
next prev parent reply other threads:[~2020-11-11 7:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 12:16 [dpdk-stable] [PATCH v3 0/3] vhost: fix fd an memory leaks Maxime Coquelin
2020-11-09 12:16 ` [dpdk-stable] [PATCH v3 1/3] vhost: fix error path when setting memory tables Maxime Coquelin
2020-11-11 6:06 ` [dpdk-stable] [dpdk-dev] " Xueming(Steven) Li
2020-11-12 17:00 ` Maxime Coquelin
2020-11-09 12:16 ` [dpdk-stable] [PATCH v3 2/3] vhost: fix fd leak in dirty logging setup Maxime Coquelin
2020-11-10 1:44 ` Xia, Chenbo
2020-11-11 6:13 ` [dpdk-stable] [dpdk-dev] " Xueming(Steven) Li
2020-11-09 12:16 ` [dpdk-stable] [PATCH v3 3/3] vhost: fix fd leak in kick setup Maxime Coquelin
2020-11-11 6:01 ` [dpdk-stable] [dpdk-dev] " Xueming(Steven) Li
2020-11-11 7:57 ` Xia, Chenbo [this message]
2020-11-12 17:06 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB40638B1C4F307337862EAFD49CE80@MN2PR11MB4063.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=xuan.ding@intel.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).