From: Raslan Darawsheh <rasland@nvidia.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
Matan Azrad <matan@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>
Subject: RE: [PATCH v2] net/mlx5: fix build with GCC 12 and ASan
Date: Thu, 23 Mar 2023 11:01:02 +0000 [thread overview]
Message-ID: <MN2PR12MB308675395B48C0976DDA4954CF879@MN2PR12MB3086.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230322170627.2317956-1-david.marchand@redhat.com>
Hi,
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, March 22, 2023 7:06 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Subject: [PATCH v2] net/mlx5: fix build with GCC 12 and ASan
>
> Building with gcc 12 and ASan raises this warning:
>
> ../drivers/net/mlx5/mlx5_txpp.c: In function ‘mlx5_txpp_xstats_get_names’:
> ../drivers/net/mlx5/mlx5_txpp.c:1066:25: error: ‘strncpy’ specified bound
> 64 equals destination size [-Werror=stringop-truncation]
> 1066 | strncpy(xstats_names[i + n_used].name,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1067 | mlx5_txpp_stat_names[i],
> | ~~~~~~~~~~~~~~~~~~~~~~~~
> 1068 | RTE_ETH_XSTATS_NAME_SIZE);
> | ~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Prefer strlcpy for xstats.
>
> Fixes: 3b025c0ca425 ("net/mlx5: provide send scheduling error statistics")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changes since v1:
> - updated mlx5_xstats_get_names too,
>
> ---
Acked-by: Raslan Darawsheh <rasland@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2023-03-23 11:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 9:03 [PATCH] " David Marchand
2023-03-14 9:02 ` David Marchand
2023-03-14 13:00 ` Slava Ovsiienko
2023-03-15 10:05 ` David Marchand
2023-03-15 12:08 ` Slava Ovsiienko
2023-03-22 17:06 ` [PATCH v2] " David Marchand
2023-03-23 11:01 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB308675395B48C0976DDA4954CF879@MN2PR12MB3086.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).