From: Ori Kam <orika@nvidia.com>
To: Maxime Leroy <maxime.leroy@6wind.com>,
Raslan Darawsheh <rasland@mellanox.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix rss reta is reset when device is started
Date: Thu, 10 Sep 2020 12:17:07 +0000 [thread overview]
Message-ID: <MN2PR12MB428657A83A08BC1A96AA8141D6270@MN2PR12MB4286.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAEykdvoOACa0KXvp2G0V7xxCx3O65siQ8TaEmt3KUbiNWB3tvQ@mail.gmail.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Maxime Leroy
>
> Hi Raslan,
>
> Any comment/review on the fix ?
>
> Regards,
>
> Maxime
>
> On Thu, Jul 16, 2020 at 12:43 PM Maxime Leroy <maxime.leroy@6wind.com>
> wrote:
> >
> > The following sequences was working fine on mlx5:
> > rte_eth_dev_configure(portid, ...);
> >
> > for (queueid = 0; queueid < nb_txq; queueid++)
> > rte_eth_tx_queue_setup(portid, queueid, ...);
> >
> > for (queueid = 0; queueid < nb_rxq; queueid++)
> > rte_eth_rx_queue_setup(portid, queueid, ...);
> >
> > // use a custom reta configuration
> > rte_eth_dev_rss_reta_update(portid, reta_conf, reta_size);
> > rte_eth_dev_start(portid);
> >
> > We were able to configure a custom reta before starting the port.
> >
> > The commit "net/mlx5: support RSS on hairpin" breaks this logic by
> > moving the code initializing the RSS reta from rte_eth_dev_configure
> > into rte_eth_dev_start.
> >
> > To fix the issue, the skip_default_rss_reta is always set to 1 in
> > rte_eth_dev_rss_reta to avoid reconfigure the rss reta when the device
> > is started.
> >
> > Fixes: 63bd16292c3a ("net/mlx5: support RSS on hairpin")
> > Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>
> > ---
Acked-by: Ori Kam <orika@nvidia.com>
Thanks,
Ori
next prev parent reply other threads:[~2020-09-10 12:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 10:43 [dpdk-stable] " Maxime Leroy
2020-09-10 11:23 ` Maxime Leroy
2020-09-10 12:17 ` Ori Kam [this message]
2020-09-15 8:14 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB428657A83A08BC1A96AA8141D6270@MN2PR12MB4286.namprd12.prod.outlook.com \
--to=orika@nvidia.com \
--cc=dev@dpdk.org \
--cc=maxime.leroy@6wind.com \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).