From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 147DFA0564 for ; Fri, 28 Feb 2020 06:38:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BF4761BF8F; Fri, 28 Feb 2020 06:38:01 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 8545F1BF8F for ; Fri, 28 Feb 2020 06:38:00 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01S5ZaiH031862; Thu, 27 Feb 2020 21:37:59 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=QxStCVahaITYqOzbhrfh9ezmPwIJnhQJtaE1fAU8i/U=; b=Kl04m0/NQyhiucj7LoYMb5xcjfWPwB59DFfuXbw3KvJEWPsjf1AnEuXU99gJ0Lks5m3y t7BOIzflDCyMDPB9x5I60gk6dSbfgMqiEtcPvxnv43GLz40Ux1kzqOrmgKLeje9WrPB+ FBfK9at25ZrHK9EFZwTJjsBPLhUcgi9Tn1ZHnyqJOzRmXKKgIBJALGA/ZrjfD85NHa5j 9bnKELPoysIVFhYKGBocvCj/WQhX6nvf6CVf3UyD0Rn4Lvg5AtjMOWg0MeYuV74CYoyH AVVEkTsxPa0PWO1BIWuuK6QH1CfWBy2cPMfDT+N0M87F7BhYcBAh8fXPU7S6mIUCzUlk CA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2yepv1kcw8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 27 Feb 2020 21:37:59 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 27 Feb 2020 21:37:57 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 27 Feb 2020 21:37:57 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 27 Feb 2020 21:37:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RmAMYkOv0ODm+VsVxFAFdlIzX14uq5viXtVvs4POMoempsIl1LqFEPCvpwc8no6xpMFM7orTl8Fosnuy5MkABCUajuPvWYd8zorzgMpw+/ltBj4ExW5cdUXbXYbourojC+JKir01Ky/V6l7i/xgeM3SfncKVP5HbNN78CLn3WsqTXhY2ouYqqYyKfW9eNwsU+RIXHyCJzI5h4ASXlRouBx8HdT06SWpmOYhcRaLo0k/5MF+Vzjdj5Jr09Lycd6FuXKiumX6QK31shOkuw+DQVX/fCWpRDDhgSz4/N5pzqEMucIFy3+0RWqSmsUnTxuhzvPdT8hofaJe4vt3Osqlqxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QxStCVahaITYqOzbhrfh9ezmPwIJnhQJtaE1fAU8i/U=; b=fOO2e+VK/ID96LVwt72bt0ZwWAFECaqYfYPmGcx65kSkdfHcI05kBvDapgAO4IcMsZ2cnbnTE92UR8jKMVNJ8845O4trBgCwbSjKuYJ+HWepY42y/4oxFA8eP7KoxKq5oVetawSKr84/4hSfxTdgFn0aq5MFfP2GyzmtN1n4sXrQWYvMV48Hc9Ji16wyux6NTtjFhcDhzypK5nQ1Rb+tLia51drcfV05e7/SDKe/DkFVG/dTc0HLOMdErSSjmqqeUaTjtyplJlk7DP8gPXyEYAZduvZx1kuVd7blRvG2G/WQWta1CuWOE93oJZt5QgoiePcWWy0nDZs6YOAFVv9iiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QxStCVahaITYqOzbhrfh9ezmPwIJnhQJtaE1fAU8i/U=; b=Nq43itii33FNnyeP83UTr7gAt75JK8k5TjfXiH7Z5pjipM3UgqUbVH2hoP/rZFHc84dw5eOgPJplfUz/+/z2V5HVQbCmFSqW2mKjiwG6m7RuxjpA7lfboGgZV5F+R6VuyP2ihxxLWvkH+rWAyGrNZS7wh2TqyJs7PIC+lZeOuMQ= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (2603:10b6:208:3b::26) by MN2PR18MB2974.namprd18.prod.outlook.com (2603:10b6:208:3a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.15; Fri, 28 Feb 2020 05:37:55 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::648f:e7fa:f95e:191b]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::648f:e7fa:f95e:191b%2]) with mapi id 15.20.2772.012; Fri, 28 Feb 2020 05:37:55 +0000 From: Anoob Joseph To: Akhil Goyal , "luca.boccassi@gmail.com" , Ankur Dwivedi CC: dpdk stable Thread-Topic: [EXT] patch 'examples/ipsec-secgw: extend inline session to non AES-GCM' has been queued to stable release 19.11.1 Thread-Index: AQHV7VEkBoNHSRTrBUmmC6m1+sQc7KgwAs+QgAAC6wCAABHr8A== Date: Fri, 28 Feb 2020 05:37:55 +0000 Message-ID: References: <20200217174546.25334-54-luca.boccassi@gmail.com> <20200227093402.17690-1-luca.boccassi@gmail.com> <20200227093402.17690-2-luca.boccassi@gmail.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 195a1b81-16d9-4268-7399-08d7bc105ca3 x-ms-traffictypediagnostic: MN2PR18MB2974: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1122; x-forefront-prvs: 0327618309 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(346002)(366004)(396003)(39850400004)(136003)(199004)(189003)(316002)(110136005)(8936002)(81156014)(8676002)(7696005)(6506007)(186003)(53546011)(26005)(55236004)(81166006)(5660300002)(64756008)(66556008)(66476007)(66946007)(86362001)(76116006)(52536014)(66446008)(45080400002)(4326008)(966005)(478600001)(9686003)(55016002)(71200400001)(19627235002)(33656002)(6636002)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2974; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JRjDUMkdNB9rxk89ABBl2vETs48Hiv2QeS0n2vMyUFumjPoq9Ax1+S8GzP37eLRzHXRM4LJuEpPBwgwFtRu2cEUEpoU9WQTkX0GcR6EU8Ge+/thdCgtBWRQ6hw7U3NhRy+H8Tm8mIRNCFFyigw0OTmhZKRZz/Qn0FRQbt6EB6DdvyqPuFp6MNhtNiiZyfAbySoLQ6s6zC7ToeLVnKnGjBkwwc44NG2CYa4MeVZ1YsKQRdQiwGUwd5/gTWMIVK+68P9L9fiWGpxTCNZYnHSV3o1Bf7VUyvMKS9TdkIGtUGkNoIVth5wCIVSNdW7Pw8FNZAs84ocxg22vv3gyIRmXj8xE8hs8p026MzmARenr/svLrTdmpHCa4fEZr/8NMFz2EnIdDOvbnnSKgT2p81AaPGqN7xupaGN3G3c/UPdmq0SzY366yAstOw231kOnWVC84TT6ae7ioHUSu0VG4L4orwjp33K479R8MKeWFvUGShVQE8pB0fR747cJ5JwZdzX1Ml7bvY3mRQ6vlmOboSfSKuw== x-ms-exchange-antispam-messagedata: yFeYyGcp5xn6TEGoUVbFdt7EmfT9km8aD4kORCyDF5G07xO4iahQq+decWBmchFUqQmzM9nB8cO2cAhC93I66Zye2X0kwvZxizkTUZASeBoFcx2y1GaqgQCgbmotFroonupkPaSAQXaZEPgAARM2Rw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 195a1b81-16d9-4268-7399-08d7bc105ca3 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2020 05:37:55.4249 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 70nLCA08rz/xmClLGJXAzSasq8bCmF+xc11aqgeNZCVQuGtFRn7Mb9SzakqazfXVGCAFEhnH7kEavtcQakop/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2974 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-02-28_01:2020-02-26, 2020-02-28 signatures=0 Subject: Re: [dpdk-stable] [EXT] patch 'examples/ipsec-secgw: extend inline session to non AES-GCM' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Akhil, Will send the appropriate patch after verifying build etc. Thanks, Anoob > -----Original Message----- > From: Akhil Goyal > Sent: Friday, February 28, 2020 10:03 AM > To: Anoob Joseph ; luca.boccassi@gmail.com; Ankur > Dwivedi > Cc: dpdk stable > Subject: RE: [EXT] patch 'examples/ipsec-secgw: extend inline session to = non > AES-GCM' has been queued to stable release 19.11.1 >=20 >=20 >=20 > > > > Hi Luca, > > > > The diff between upstream patch and dpdk-stable patch doesn't look > > right. I would say we can defer this change from merge to stable. > > > > @Akhil, what's your take on this? >=20 > Why do we need to defer this patch? > I think the only thing is declaration of ips is missing. The compilation = will be > broken. > Can you send the appropriate patch to stable? >=20 > > > > Thanks, > > Anoob > > > > > -----Original Message----- > > > From: luca.boccassi@gmail.com > > > Sent: Thursday, February 27, 2020 3:03 PM > > > To: Ankur Dwivedi > > > Cc: Anoob Joseph ; Akhil Goyal > > > ; dpdk stable > > > Subject: [EXT] patch 'examples/ipsec-secgw: extend inline session to > > > non AES-GCM' has been queued to stable release 19.11.1 > > > > > > External Email > > > > > > -------------------------------------------------------------------- > > > -- > > > Hi, > > > > > > FYI, your patch has been queued to stable release 19.11.1 > > > > > > Note it hasn't been pushed to > > > > > https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__eur01.safelinks.= p > > rotection.outlook.com_-3Furl-3Dhttps-253A-252F- > 252Furldefens&d=3DDwIFAg& > > c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DjPfB8rwwviRSxyLWs2n6B- > WYLn1v9SyTMrT5EQqh2TU > > > &m=3DeOnW_NUoUMFWqoaBTOmC7zVyaSoWZB_hVr6nQKboVm8&s=3Dmu21 > wyPbS7W4bBgKdfTO4 > > xfLokZ_8cS6b8m5O7tOKd0&e=3D > > e.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttp- > > > &data=3D02%7C01%7Cakhil.goyal%40nxp.com%7C0d2ac7af89ca48357a110 > > > 8d7bc062ce6%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6371846 > > > 07019183710&sdata=3DtSi80Em79D5Nvv3YUVa5HlUfyStN5MOf5eCyOs2e2 > b > > o%3D&reserved=3D0 > > > 3A__dpdk.org_browse_dpdk- > > > > 2Dstable&d=3DDwIDAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DjPfB8rwwviRSxyLWs > > > 2n6B-WYLn1v9SyTMrT5EQqh2TU&m=3DuIvPnv- > > > I27twfm1d6XD0AMFwcH8L4mBZAQxhhR9PzDw&s=3D- > > > O8xzMfTZw5m9whfatE2Ma7_ub-QaoVc1uZWrbWRSKU&e=3D yet. > > > It will be pushed if I get no objections before 02/29/20. So please > > > shout if anyone has objections. > > > > > > Also note that after the patch there's a diff of the upstream commit > > > vs the patch applied to the branch. This will indicate if there was > > > any rebasing needed to apply to the stable branch. If there were > > > code changes for rebasing > > > (ie: not only metadata diffs), please double check that the rebase > > > was correctly done. > > > > > > Thanks. > > > > > > Luca Boccassi > > > > > > --- > > > From 42b568622cf6345e311aee821d755963e786a704 Mon Sep 17 00:00:00 > > > 2001 > > > From: Ankur Dwivedi > > > Date: Fri, 14 Feb 2020 12:08:18 +0530 > > > Subject: [PATCH] examples/ipsec-secgw: extend inline session to non > > > AES- GCM > > > > > > [ upstream commit b685f931e1ce33d287e3891d4f19ab07f8d2aa79 ] > > > > > > This patch extends creation of inline session to all the algorithms. > > > Previously the inline session was enabled only for AES-GCM cipher. > > > > > > Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with > > > inline > > > crypto") > > > > > > Signed-off-by: Ankur Dwivedi > > > Acked-by: Anoob Joseph > > > Acked-by: Akhil Goyal > > > --- > > > examples/ipsec-secgw/sa.c | 25 ++++++++++++------------- > > > 1 file changed, 12 insertions(+), 13 deletions(-) > > > > > > diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c > > > index > > > c75a5a15f5..04827d7e11 100644 > > > --- a/examples/ipsec-secgw/sa.c > > > +++ b/examples/ipsec-secgw/sa.c > > > @@ -993,7 +993,6 @@ sa_add_rules(struct sa_ctx *sa_ctx, const struct > > > ipsec_sa entries[], > > > } > > > > > > if (sa->aead_algo =3D=3D RTE_CRYPTO_AEAD_AES_GCM) { > > > - struct rte_ipsec_session *ips; > > > iv_length =3D 12; > > > > > > sa_ctx->xf[idx].a.type =3D > > > RTE_CRYPTO_SYM_XFORM_AEAD; @@ -1014,18 +1013,6 @@ > > > sa_add_rules(struct sa_ctx *sa_ctx, const struct ipsec_sa entries[], > > > > > > sa->xforms =3D &sa_ctx->xf[idx].a; > > > > > > - ips =3D ipsec_get_primary_session(sa); > > > - if (ips->type =3D=3D > > > - > > > RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL || > > > - ips->type =3D=3D > > > - > > > RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO) { > > > - rc =3D create_inline_session(skt_ctx, sa, ips); > > > - if (rc !=3D 0) { > > > - RTE_LOG(ERR, IPSEC_ESP, > > > - "create_inline_session() > > > failed\n"); > > > - return -EINVAL; > > > - } > > > - } > > > print_one_sa_rule(sa, inbound); > > > } else { > > > switch (sa->cipher_algo) { > > > @@ -1094,6 +1081,18 @@ sa_add_rules(struct sa_ctx *sa_ctx, const > > > struct ipsec_sa entries[], > > > > > > print_one_sa_rule(sa, inbound); > > > } > > > + > > > + if (ips->type =3D=3D > > > + RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL || > > > + ips->type =3D=3D > > > + RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO) { > > > + rc =3D create_inline_session(skt_ctx, sa, ips); > > > + if (rc !=3D 0) { > > > + RTE_LOG(ERR, IPSEC_ESP, > > > + "create_inline_session() failed\n"); > > > + return -EINVAL; > > > + } > > > + } > > > } > > > > > > return 0; > > > -- > > > 2.20.1 > > > > > > --- > > > Diff of the applied patch vs upstream commit (please double-check > > > if non- > > > empty: > > > --- > > > --- - 2020-02-27 09:31:55.915137861 +0000 > > > +++ 0002-examples-ipsec-secgw-extend-inline-session-to-non-AE.patch > > > 2020-02-27 09:31:55.631945112 +0000 @@ -1,26 +1,27 @@ -From > > > b685f931e1ce33d287e3891d4f19ab07f8d2aa79 Mon Sep 17 00:00:00 > > > 2001 > > > +From 42b568622cf6345e311aee821d755963e786a704 Mon Sep 17 > 00:00:00 > > > 2001 > > > From: Ankur Dwivedi > > > Date: Fri, 14 Feb 2020 12:08:18 +0530 > > > Subject: [PATCH] examples/ipsec-secgw: extend inline session to non > > > AES- GCM > > > > > > +[ upstream commit b685f931e1ce33d287e3891d4f19ab07f8d2aa79 ] > > > + > > > This patch extends creation of inline session to all the algorithms. > > > Previously the inline session was enabled only for AES-GCM cipher. > > > > > > Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with > > > inline > > > crypto") > > > -Cc: stable@dpdk.org > > > > > > Signed-off-by: Ankur Dwivedi > > > Acked-by: Anoob Joseph > > > Acked-by: Akhil Goyal > > > --- > > > - examples/ipsec-secgw/sa.c | 26 ++++++++++++-------------- > > > - 1 file changed, 12 insertions(+), 14 deletions(-) > > > + examples/ipsec-secgw/sa.c | 25 ++++++++++++------------- > > > + 1 file changed, 12 insertions(+), 13 deletions(-) > > > > > > diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c > > > -index e75b687c46..4822d6bdaa 100644 > > > +index c75a5a15f5..04827d7e11 100644 > > > --- a/examples/ipsec-secgw/sa.c > > > +++ b/examples/ipsec-secgw/sa.c > > > -@@ -1057,7 +1057,6 @@ sa_add_rules(struct sa_ctx *sa_ctx, const > > > struct ipsec_sa entries[], > > > +@@ -993,7 +993,6 @@ sa_add_rules(struct sa_ctx *sa_ctx, const > > > +struct ipsec_sa entries[], > > > } > > > > > > if (sa->aead_algo =3D=3D RTE_CRYPTO_AEAD_AES_GCM) { @@ - > > > 28,11 +29,10 @@ > > > iv_length =3D 12; > > > > > > sa_ctx->xf[idx].a.type =3D > > > RTE_CRYPTO_SYM_XFORM_AEAD; -@@ -1077,19 +1076,6 @@ > > > sa_add_rules(struct sa_ctx *sa_ctx, const struct ipsec_sa entries[], > > > - sa->digest_len; > > > +@@ -1014,18 +1013,6 @@ sa_add_rules(struct sa_ctx *sa_ctx, const > > > +struct ipsec_sa entries[], > > > > > > sa->xforms =3D &sa_ctx->xf[idx].a; > > > -- > > > + > > > - ips =3D ipsec_get_primary_session(sa); > > > - if (ips->type =3D=3D > > > - > > > RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL || @@ -45,13 > +45,14 @@ > > > - return -EINVAL; > > > - } > > > - } > > > + print_one_sa_rule(sa, inbound); > > > } else { > > > switch (sa->cipher_algo) { > > > - case RTE_CRYPTO_CIPHER_NULL: > > > -@@ -1156,6 +1142,18 @@ sa_add_rules(struct sa_ctx *sa_ctx, const > > > struct ipsec_sa entries[], > > > - sa->xforms =3D &sa_ctx->xf[idx].a; > > > - } > > > +@@ -1094,6 +1081,18 @@ sa_add_rules(struct sa_ctx *sa_ctx, const > > > +struct ipsec_sa entries[], > > > > > > + print_one_sa_rule(sa, inbound); > > > + } > > > ++ > > > + if (ips->type =3D=3D > > > + RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL || > > > + ips->type =3D=3D > > > @@ -63,10 +64,9 @@ > > > + return -EINVAL; > > > + } > > > + } > > > -+ > > > - print_one_sa_rule(sa, inbound); > > > } > > > > > > + return 0; > > > -- > > > 2.20.1 > > >