* [dpdk-stable] [PATCH] net/mlx5: fix hashed list size for tunnel flow groups
@ 2021-02-22 15:56 Viacheslav Ovsiienko
2021-02-23 8:24 ` Matan Azrad
2021-02-24 8:15 ` [dpdk-stable] [PATCH v2] " Viacheslav Ovsiienko
0 siblings, 2 replies; 4+ messages in thread
From: Viacheslav Ovsiienko @ 2021-02-22 15:56 UTC (permalink / raw)
To: dev; +Cc: rasland, matan, stable
The hasged list size must be the power of 2, otherwise the
adjustment is applied and the warning message is emitted.
This patch provides the correct list size to eliminate the
warning.
Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload")
Cc: stable@dpdk.org
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
drivers/net/mlx5/mlx5_flow.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 632f46dfde..ab5be3dacc 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -7940,7 +7940,8 @@ int mlx5_alloc_tunnel_hub(struct mlx5_dev_ctx_shared *sh)
return -ENOMEM;
LIST_INIT(&thub->tunnels);
rte_spinlock_init(&thub->sl);
- thub->groups = mlx5_hlist_create("flow groups", MLX5_MAX_TABLES, 0,
+ thub->groups = mlx5_hlist_create("flow groups",
+ rte_align32pow2(MLX5_MAX_TABLES), 0,
0, mlx5_flow_tunnel_grp2tbl_create_cb,
mlx5_flow_tunnel_grp2tbl_match_cb,
mlx5_flow_tunnel_grp2tbl_remove_cb);
--
2.18.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [PATCH] net/mlx5: fix hashed list size for tunnel flow groups
2021-02-22 15:56 [dpdk-stable] [PATCH] net/mlx5: fix hashed list size for tunnel flow groups Viacheslav Ovsiienko
@ 2021-02-23 8:24 ` Matan Azrad
2021-02-24 8:15 ` [dpdk-stable] [PATCH v2] " Viacheslav Ovsiienko
1 sibling, 0 replies; 4+ messages in thread
From: Matan Azrad @ 2021-02-23 8:24 UTC (permalink / raw)
To: Slava Ovsiienko, dev; +Cc: Raslan Darawsheh, stable
From: Viacheslav Ovsiienko
> The hasged list size must be the power of 2, otherwise the adjustment is
> applied and the warning message is emitted.
> This patch provides the correct list size to eliminate the warning.
>
> Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload")
> Cc: stable@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-stable] [PATCH v2] net/mlx5: fix hashed list size for tunnel flow groups
2021-02-22 15:56 [dpdk-stable] [PATCH] net/mlx5: fix hashed list size for tunnel flow groups Viacheslav Ovsiienko
2021-02-23 8:24 ` Matan Azrad
@ 2021-02-24 8:15 ` Viacheslav Ovsiienko
2021-02-24 10:11 ` Raslan Darawsheh
1 sibling, 1 reply; 4+ messages in thread
From: Viacheslav Ovsiienko @ 2021-02-24 8:15 UTC (permalink / raw)
To: dev; +Cc: rasland, matan, stable
The hashed list size must be the power of 2, otherwise the
adjustment is applied and the warning message is emitted.
This patch provides the correct list size to eliminate the
warning.
Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload")
Cc: stable@dpdk.org
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
v2: fix typos in commit message
---
drivers/net/mlx5/mlx5_flow.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 632f46dfde..ab5be3dacc 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -7940,7 +7940,8 @@ int mlx5_alloc_tunnel_hub(struct mlx5_dev_ctx_shared *sh)
return -ENOMEM;
LIST_INIT(&thub->tunnels);
rte_spinlock_init(&thub->sl);
- thub->groups = mlx5_hlist_create("flow groups", MLX5_MAX_TABLES, 0,
+ thub->groups = mlx5_hlist_create("flow groups",
+ rte_align32pow2(MLX5_MAX_TABLES), 0,
0, mlx5_flow_tunnel_grp2tbl_create_cb,
mlx5_flow_tunnel_grp2tbl_match_cb,
mlx5_flow_tunnel_grp2tbl_remove_cb);
--
2.18.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [PATCH v2] net/mlx5: fix hashed list size for tunnel flow groups
2021-02-24 8:15 ` [dpdk-stable] [PATCH v2] " Viacheslav Ovsiienko
@ 2021-02-24 10:11 ` Raslan Darawsheh
0 siblings, 0 replies; 4+ messages in thread
From: Raslan Darawsheh @ 2021-02-24 10:11 UTC (permalink / raw)
To: Slava Ovsiienko, dev; +Cc: Matan Azrad, stable
Hi,
> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Sent: Wednesday, February 24, 2021 10:15 AM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; stable@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix hashed list size for tunnel flow groups
>
> The hashed list size must be the power of 2, otherwise the
> adjustment is applied and the warning message is emitted.
> This patch provides the correct list size to eliminate the
> warning.
>
> Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload")
> Cc: stable@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
>
> ---
> v2: fix typos in commit message
> ---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-24 10:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-22 15:56 [dpdk-stable] [PATCH] net/mlx5: fix hashed list size for tunnel flow groups Viacheslav Ovsiienko
2021-02-23 8:24 ` Matan Azrad
2021-02-24 8:15 ` [dpdk-stable] [PATCH v2] " Viacheslav Ovsiienko
2021-02-24 10:11 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).