From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60A43A054F for ; Wed, 7 Sep 2022 10:56:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58294427EA; Wed, 7 Sep 2022 10:56:02 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2063.outbound.protection.outlook.com [40.107.96.63]) by mails.dpdk.org (Postfix) with ESMTP id F05D240042; Wed, 7 Sep 2022 10:56:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d3gPFFr3WZbDNjvfYZhfFjPqeOkTdPaH9FAlBcXHU2Mhf9uP08hAdojZdD3F+aWEx2gIMqxVh3dsvMJxEkmKfHmQsaATWYCN2RcdEgfg58EADPpypXCLPrfU5LYocLjvfkipgzgbJD2TjlOBqYRLI9fdh1GMxEOxhI1TIlNaza3uM64HDh4+1WLJEJnU5921SxxTvAvzxEspgmUCp0ZEA8C36P57JFg8Ii8cUPe9JfR+cJ6Wce7EAhLtD0H7q15DRl8lkwSaphA/9moM50xnZnT2XPCVCKTyoUZKG8ZNFuffJAi3oOw9XHfU5VQ9gKBJ72DYTcuTttE4iPe/ykKUrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NzcQOclidjTQ/lFCkFdLo6HP42telio6KOGcc/pmWD4=; b=DyTFTlB3FH/3bolqZz3aSYVFe0H3u4r/8bLREi1byb1aluR/VChF+3ud1b+Cn82mwOaLHhQtXm+23tFp4YpM+7FvIiVFQ/uFTKrbf0yDFEE5V/PbXn10evz15/qbJkabZNOFR01XdOT4xQ1HXQWmzpaXVqMbOnaeH6SRV+XQQ+eLegoXIsySaJKpZNV7L2oS/flf7rSXtnKB/FD4AxXduAk6FEAC7bC1zxoe4ORpReK+N4HlCGP4zkAfci+4KbyivOa19UPhjxF8VkjYsPOG5VE1T46PwToejYB68RDooqQ+eHOuAMV6upw3CgebKF7CcinsLuc6/nRXcPU90JYHKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NzcQOclidjTQ/lFCkFdLo6HP42telio6KOGcc/pmWD4=; b=lboQ+lbX4w4UO3vT2Mz16QUksxl2S0QwnxVsuNs6jqO/dj8V4xcrj9dwJc91KH7FgXaisi4Umu8thT9HWB/vuz0NG+VUA9jvxU4PJzkgLM8fWzZePAarRAovJs7D+EsRjRZW4MOuVn4gvd3CP4gl7zmijhNqkOKjnyaPIXT/XRI= Received: from MW2PR12MB2538.namprd12.prod.outlook.com (2603:10b6:907:5::14) by DM4PR12MB6542.namprd12.prod.outlook.com (2603:10b6:8:89::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Wed, 7 Sep 2022 08:55:59 +0000 Received: from MW2PR12MB2538.namprd12.prod.outlook.com ([fe80::c57e:5ef8:1335:e1f4]) by MW2PR12MB2538.namprd12.prod.outlook.com ([fe80::c57e:5ef8:1335:e1f4%6]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 08:55:58 +0000 From: "Namburu, Chandu-babu" To: "Modali, Bhagyada" , "Yigit, Ferruh" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v2] net/axgbe: optimise scattered rx Thread-Topic: [PATCH v2] net/axgbe: optimise scattered rx Thread-Index: AQHYwegkL5cJ5/m8xUSJodPyr7uLRa3TqwYg Date: Wed, 7 Sep 2022 08:55:58 +0000 Message-ID: References: <20220905102031.110601-1-bhagyada.modali@amd.com> <20220906115915.115598-1-bhagyada.modali@amd.com> In-Reply-To: <20220906115915.115598-1-bhagyada.modali@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-09-07T08:55:05Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=f4c88369-ce9a-4a78-9402-350c316f351b; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_enabled: true msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_setdate: 2022-09-07T08:55:51Z msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_method: Privileged msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_name: Public-AIP 2.0 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_actionid: 9d8a1c6f-5956-47d8-8fd4-c7a2e4e29126 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_contentbits: 0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 86c416a2-484a-42b3-f0d4-08da90aec86e x-ms-traffictypediagnostic: DM4PR12MB6542:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0bheFwlDZ5gYIiyiiWcYPcNj8++c3LGS8Je3k8+BELP6c3vrB7hZEw5FgGOhlB+Vy6knLNRBe+f4Z5T7/HQPw7qGocA9p+mJPwUtPjP7DvDjSlICyMcSfuy96heSABuNyPvuNL1qdYIIVvjp0Eo3eG/2EKexhTIe8t3ZZy5n62mF4A5jhSR8aDfsJdv4bGMtDuAHPnFEXrDAY4++a5yE17NJE0lEhqHA1SwJdVYULRVU9wFvQ50+sy8lhWbz0muGfbW6qog4RFmHsUTyrjROQF6GZMXoxBrMkMfhnQmhMcXNSlG7TChjJeZnrU3BHT+HX0SAwVlY+MO1KVGUpgNlvUoQagGa+l0bAAKExxH+UibNqz9yjxSIyY8bppaJngRjtKw71+/jIRxJxeSUzbNVDIfetu1zK0Z3GBK3fTM7aZKjoY/J8IkptiK37t1MQAYmbTXo4kuX5MmVx8cED+1ukusHvoaH63X74uGKh6HBKcGm4TL/rwqwNWUX9F4ggtBnmH9wcoa/i1NApUk4staF+V2LJuuLwO8Miiy0rkUfYcijXwDfth7Bt9jp+yUAEbnnF4Lx+6ZI5Qth8/O1lloEcSdg60H79bAItsHBlXEROOccLRZ++Nh2rM4NLvHfEcw2zrsadbcDpIbtU49tD5qlIYICP7Ju4ivp78qHNa74ZnU3swWecUITtMnSNb3xs4JzMytDIYftEI7+z5IFeevW3JYvJkrWzkL5kuyXD1WW3iuLbhV4nKB611QO3B/pF+IqKmcDH8/UF7DiTIoNYHFFKlhLz7digsIv+PR3qlqQNeI= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2538.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(396003)(346002)(366004)(136003)(376002)(39860400002)(55016003)(52536014)(8676002)(316002)(66446008)(450100002)(76116006)(66946007)(4326008)(110136005)(6636002)(33656002)(66556008)(2906002)(54906003)(53546011)(7696005)(9686003)(6506007)(26005)(41300700001)(38100700002)(478600001)(64756008)(86362001)(66476007)(5660300002)(122000001)(71200400001)(83380400001)(8936002)(38070700005)(186003)(83323001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nQrC+3YR/DLkgH32VXec03QdcGty3EJmZRFJfULoAQs4UyYROUTWioHWOqEm?= =?us-ascii?Q?PuERNLOFW90XtZpn+grFUgda5fq+njjHQDXTxXgoJyUUZF6IaO5O50viz5Z0?= =?us-ascii?Q?HnxzxEBk74/4ZDFPyYFkOyLgFeZFatjnjG0QJdACpUox9fr+pun3jcc7ansy?= =?us-ascii?Q?+1lEWwJL+pyaWUyhCZy2osW7QxTKxEHSANk9YxduTuFSgvmOyQRxktB8nZaW?= =?us-ascii?Q?N1z940PP/NSa9zJLCJ6I1jj1PVV2FZRmZUlnsGLM/Ooo8kXSEbx+pY565Q7O?= =?us-ascii?Q?g6TvX2gTDXIwpgFN/w1zRh0mumNOCJOV3ytyTDz/lT1t5Juzc1psa2tjKOCy?= =?us-ascii?Q?+9uyEQNceoqDu8DIgVVPq798JvAbmsOvpmMIjztiL3rn6Whk33gjsOSbiSlQ?= =?us-ascii?Q?hGTdPkhw/Wp80eQAEyAXZ6LiGIHwFjXiFa9ZBBGWBwIMp+wy5X5kdOjrBJ2m?= =?us-ascii?Q?fWAKD6g10uANdNddl80p2XUcXMmXtf/DRtJTNCPgkskI19g1jVbJEoQL5oN2?= =?us-ascii?Q?rDGSqgfQSQ0wYTqFQ5mIOO+G2L02A3XqqNsChvekeaVF3IU6fvOnxOJeeOZt?= =?us-ascii?Q?EIfLDbtSdiKsUEAm5rO1vTz+w+HNOS2z370lsL0ReBMyLUlBjWb0KPHK8xOe?= =?us-ascii?Q?c4xbUq3zAweF0L9Vb6D+hujuMJpsyn2ZyhNAX4Rl4Oiv8qV/MD6pvmGeSVMs?= =?us-ascii?Q?MtWIpzJhBGixzXzE0AqeRzPFIfcn2XqBA+okgEROt86YyTAsFN9bQYvtXMaT?= =?us-ascii?Q?VAh1xth4z1eFIdHC4Hh3OAUYAJWDsoTr0VMewzSDIA3C1TbdU9+MsKa13qIR?= =?us-ascii?Q?Zihfb6Ux707kQ9kM9uUi8SHZrj2FkN0MeVxlNnEQquEupZSZ83xM+9BuX0Rl?= =?us-ascii?Q?mf61+IPPRTNWFOCgjPongdRwPR41XCY5HipAIinh+MfrIhQnLJ3nq6XMqY1t?= =?us-ascii?Q?fLE/lkqlp5ZGM6IFiuP/fwyHZr/hNK5Ca1Y+w9yj4FLHQaezUFEaML5wSPOI?= =?us-ascii?Q?UgKU4vFIjlMTRHD3/tzy8HnTN87SSnRhqbXszKzZESlPlV4LgRNijVjFLJ07?= =?us-ascii?Q?ztuRvW19SmtlDumZ9zQmkyMp/i9TOmRfZLWpxfxytSTcVk6SqpYse0jcmM+C?= =?us-ascii?Q?9qeBJq+6IHrWbhj0IyjAm2Imco+djQe8rxkKXOTKWutQyQLLKodc7XHZ5/Zo?= =?us-ascii?Q?eXdMBCcdUJyQ7A8COLABiX4W76fWxE1EpgVpfEqKj1rTcSsFMs1IqKi+9/Xz?= =?us-ascii?Q?PjlklHJSW86AG5uoRLFAlXWg/UQuHkYeBgKKHC8+ANY9ZkYGh3saO2mLznWy?= =?us-ascii?Q?oDsZuRZy6l52NMlLJUI8XvP6PtXd/ZG+1wmT6DvjpRIz7B85v4FvBC5Fb+rY?= =?us-ascii?Q?sbrDGHYzEn+YoQ2x8zaaraYoxIbt+0UVQJBKo8Kb0QvCJKqPVFqBKma17yL+?= =?us-ascii?Q?m7Kqq2QTyfx3DiVBWLoq9wT1Plws3sdNddZ4KYtVwZvdzb1+6xxPbFgR1qW5?= =?us-ascii?Q?JrlP7cklHDr6MgaJ99NVXH33uuVNe1bVbAcplcOwmgk8Ay3TFk+Ws/wOZMzV?= =?us-ascii?Q?dGjV4RyLbmdNNV65Cus=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2538.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86c416a2-484a-42b3-f0d4-08da90aec86e X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 08:55:58.7144 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lPC9WDgbDerrxRS31Csewuzkp5pG3cXzv5tPADHXj7EmKFMJRLv3PDVeeCNBbW3YOTdSD4JHaaiyBZAoqEHRLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6542 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org [Public] Acked-by: Chandubabu Namburu -----Original Message----- From: Modali, Bhagyada =20 Sent: Tuesday, September 6, 2022 5:29 PM To: Namburu, Chandu-babu ; Yigit, Ferruh Cc: dev@dpdk.org; stable@dpdk.org; Modali, Bhagyada Subject: [PATCH v2] net/axgbe: optimise scattered rx Updated the logic to remove the extra increments of the variables. Fixes: 965b3127d425 ("net/axgbe: support scattered Rx") Cc: stable@dpdk.org Signed-off-by: Bhagyada Modali --- v2: * rebased to the latest changes and submitting the patch again --- --- drivers/net/axgbe/axgbe_rxtx.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.= c index 2bad638f79..8b43e8160b 100644 --- a/drivers/net/axgbe/axgbe_rxtx.c +++ b/drivers/net/axgbe/axgbe_rxtx.c @@ -340,7 +340,6 @@ uint16_t eth_axgbe_recv_scattered_pkts(void *rx_queue, struct axgbe_rx_queue *rxq =3D rx_queue; volatile union axgbe_rx_desc *desc; =20 - uint64_t old_dirty =3D rxq->dirty; struct rte_mbuf *first_seg =3D NULL; struct rte_mbuf *mbuf, *tmbuf; unsigned int err =3D 0, etlt; @@ -352,8 +351,7 @@ uint16_t eth_axgbe_recv_scattered_pkts(void *rx_queue, while (nb_rx < nb_pkts) { bool eop =3D 0; next_desc: - if (unlikely(idx =3D=3D rxq->nb_desc)) - idx =3D 0; + idx =3D AXGBE_GET_DESC_IDX(rxq, rxq->cur); =20 desc =3D &rxq->desc[idx]; =20 @@ -446,19 +444,19 @@ uint16_t eth_axgbe_recv_scattered_pkts(void *rx_queue= , ~RTE_MBUF_F_RX_VLAN_STRIPPED; } else { first_seg->ol_flags &=3D - ~(RTE_MBUF_F_RX_VLAN | RTE_MBUF_F_RX_VLAN_STRIPPED); + ~(RTE_MBUF_F_RX_VLAN | + RTE_MBUF_F_RX_VLAN_STRIPPED); first_seg->vlan_tci =3D 0; } } =20 err_set: rxq->cur++; - rxq->sw_ring[idx++] =3D tmbuf; + rxq->sw_ring[idx] =3D tmbuf; desc->read.baddr =3D rte_cpu_to_le_64(rte_mbuf_data_iova_default(tmbuf)); memset((void *)(&desc->read.desc2), 0, 8); AXGMAC_SET_BITS_LE(desc->read.desc3, RX_NORMAL_DESC3, OWN, 1); - rxq->dirty++; =20 if (!eop) { rte_pktmbuf_free(mbuf); @@ -501,12 +499,13 @@ uint16_t eth_axgbe_recv_scattered_pkts(void *rx_queue= , /* Save receive context.*/ rxq->pkts +=3D nb_rx; =20 - if (rxq->dirty !=3D old_dirty) { + if (rxq->dirty !=3D rxq->cur) { rte_wmb(); - idx =3D AXGBE_GET_DESC_IDX(rxq, rxq->dirty - 1); + idx =3D AXGBE_GET_DESC_IDX(rxq, rxq->cur - 1); AXGMAC_DMA_IOWRITE(rxq, DMA_CH_RDTR_LO, low32_value(rxq->ring_phys_addr + (idx * sizeof(union axgbe_rx_desc)))); + rxq->dirty =3D rxq->cur; } return nb_rx; } -- 2.25.1