From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9315B43D0D for ; Thu, 21 Mar 2024 04:39:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 855E14029F; Thu, 21 Mar 2024 04:39:28 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id A5DEB4028B; Thu, 21 Mar 2024 04:39:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710992367; x=1742528367; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=599flMkCZtK2GdLdgjcHitBlcin1IEj48NSoSJsoUso=; b=Mn6xIqOW6Fiz1GBXPCVCI8YJDIQVJ+6vxmGeXIZfrotf/i6vZvTe/Uz4 TLqQI0zbNxdv2OZBgPdzgKdD8zqoehz8W626QkT+zmjFf3jR/k6TRcvdI pGQQ8PKH3KNbGbHF95hnxCrhJSnEyMcbtO4xwuzkBb9qUskSezMlaxh8z wCfUsAqiS/ujpWgew2UjRVJcLbqBOU55CdD36g6dMzETfjya2myecfcBb usW+rR1usnJPbxtFtfKjfAixkwxioL3J832AEiQJClZL5BlfLB4mzpeg2 89PWylIJry6JnXJVZbAVI7HyHeHQ5ouGyDWXaSne+y0ukquumeg4MVtbO A==; X-IronPort-AV: E=McAfee;i="6600,9927,11019"; a="6076456" X-IronPort-AV: E=Sophos;i="6.07,141,1708416000"; d="scan'208";a="6076456" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2024 20:39:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,141,1708416000"; d="scan'208";a="18936997" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Mar 2024 20:39:25 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 20 Mar 2024 20:39:24 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 20 Mar 2024 20:39:24 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 20 Mar 2024 20:39:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E+6sVAcalCGx5NcRwym8q1zl77nKzLg78ZqJ2h41Dy/TKjVy1KetI/tcPeULM+dmCqiLJDbceOCHKGZPdA0aIO8XG5xvxxnmjBwjJQ96+ar0oNFlxgzyAfPWyPC/ApyIq0DH9fV8ZAbN86ZTvYAG7S9KY4sxBlieaEoHFLGR5aky9iONqgz/t9nNAg+NUNv3EIoR1QntXqDVNGHACzLLY+z4EZycTvfadwR28ZlZq8gCSUbuDL7oPSiTEpqEmunGOSbTNtTz3QhaG2T97ZQ6OxdbIpx/WLlASekNCodUi9xrrJ1rVUTiDDefSzWKor1aD1b2EYjLTg+g3cvQb3DH1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KVYHK1OQtsS45EZL4vzWTHSh/sYnB7zckJ/g4QWWK4Q=; b=CPuJPQUrqrJ9gidZeVH8WkWbp0dbl809Bx6TgMVAgvKXQvpjit1d87GuAlefHgv1bC1hnUeHbHNl38ORHub/D6yS/dxpG+4WDWlOAKKtDxXHqQg83HB2DfFt25yOYtUyCmFJ+1v/Mno+2XdiWGOsY5gomtAghSYj1om7kOoZnKpCy7KtyPl1Tx85RLnfkOz/dk3p+xwL72zSV8b7OsB0RnDyCObQNuum2yu/k2uKr8sBhvN85FyXr2JQiNrNOfnnnckd1Hq5GO3BY1obbDBOctvhcfm0IGbykslChbw1Z7hxVZYX9N1ToACwfdax7c8MwIbAGeLHG7974CSqCF0r1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4587.namprd11.prod.outlook.com (2603:10b6:303:58::7) by SA2PR11MB5148.namprd11.prod.outlook.com (2603:10b6:806:11e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.12; Thu, 21 Mar 2024 03:39:21 +0000 Received: from MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::a473:eb2f:6bfe:7d7f]) by MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::a473:eb2f:6bfe:7d7f%6]) with mapi id 15.20.7409.010; Thu, 21 Mar 2024 03:39:21 +0000 From: "Wu, Jingjing" To: "Yan, Zhirun" , "dev@dpdk.org" CC: "jerinj@marvell.com" , "pbhagavatula@marvell.com" , "stable@dpdk.org" Subject: RE: [PATCH] graph: fix head move when graph walk in mcore dispatch Thread-Topic: [PATCH] graph: fix head move when graph walk in mcore dispatch Thread-Index: AQHaecXhFEhPkc/mYkecqf+zpMvy3bE/+x8AgAAvg/CAACcCAIABO8Fw Date: Thu, 21 Mar 2024 03:39:21 +0000 Message-ID: References: <20240319141454.3275543-1-jingjing.wu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW3PR11MB4587:EE_|SA2PR11MB5148:EE_ x-ms-office365-filtering-correlation-id: 60025128-1d12-44fc-f4db-08dc49587f1f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: m9xemv3Fhn+bZFChkFk/L6CeaATdOWKj5xOYjomsylnrKSEd9/tcdXwLWdL8cCCKfF6sd4dRl2c1RBm74O3FHZzX7c7tSLvM999CBgHNoxjnYgmitWqeRx0PLE24QLG+nQInn1UseiaOTKKbTP/OwWvFPrwmwDOrLecFgih8z5H6o0LT0Ik4Pd7Ik30xPvV2bqbPMa+ZFxHQaoQ/qPQ+wN92pSDqxc7AZuUaguPUhF/V8i4h96MClWaN1y8cKuGl4dKZRAsniy9lSPXRWbwCTXZIKo8gIkSfBmyzORrqmIs+6zKnXUMNk/vzlci4iI/TNiw1aB7BvZhfbeiFIiLWR7zqXsU66Q2N3RoD2RRTf5C7mAsO2VOPglNqpz+Hxg/CLbrSaIRZWojjXspHdo7Gl9+BiPBI6q52TfTNlB8p0MkpV6EYSUyIlrobr8XsTqB3VBa68+VgWHzXdcBJ65oAKVTOmUDCg01ro4I82E/CWnM5wdvYhoowjBaD7R0m/25ScnD58RZlGMoCKM/DlijJeZ1I8ijDz4pXIfDYAQ0ns1et2nAPAuERgC6rfbNG5PBJ4suqBRIL9aES09GmVYimuujpdxqMwjigLxon2yXZHrQpdu0FVQvK5abNT6RyFCvTSOWTSZxbcMYWQoBNrs+tjLJE8VOtTYn3IDutCKNLjReFv4QGb0E8rq8W7FkF7zXfK0f/X3HW0NQUk2jP7w5wVClQ/066t0eW+JZ9X5y7src= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4587.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JSlZE6DNUBOJ3Sd0LMv+ILofO9T3wobketY8rToH/8sPF299vYQQLDEb9hmQ?= =?us-ascii?Q?43voKZ3GWgh/DBDUoO1J/rb0ynjBBbQi+DgvrKsrqDjMBHqqX0Nd/UwdO+MR?= =?us-ascii?Q?Kp9vbHEl2S3tYhmMpZDcf98N0FBY9Csu41nn468cPim08toB/YODHKpmcQ3u?= =?us-ascii?Q?/Mi2OGbUxTJpN6w4drw+oWhyi5oT+5hMBmug+QYGeyhrFL3DBmQY4Y7eH5SW?= =?us-ascii?Q?2qEqH/HpaK7AQG1lGLivawKcdrc5iZ+Vnz8d4gCKJrP/e0u2lgwCi9iPt+7V?= =?us-ascii?Q?O68XIPVrb7DbUqTwcxE94CdXA8bz5BMEMjlTAYGSPJvwTDN9jOEdq5jtUdYd?= =?us-ascii?Q?us0LyZeWHL7zf7ACl2i69u/Xkb4JQ9RqibPJmKPEWC0vK0ekwfzXyjZWBHgm?= =?us-ascii?Q?ZkfmHH+i+D1yJGPIbw0ffxJ8iqH2WOii8rR0ihsH+CzNO1du8ct1U+ltAE8m?= =?us-ascii?Q?f8nwpLUl0xp8fTwK5AFox0rF3acDf7/ibcFFNu36oRVUGHR13iwNUIHumYPm?= =?us-ascii?Q?z9ZoJ6SDQtjsWi7duS21tEOu5up4js0CkK3Ar84mJBcpwhCyf0oQQmIcK68r?= =?us-ascii?Q?cNGER0h/NfleWFtOvRcMWN5Ga85PqSDsIPhYQvFx2s9EGSMeYr4GqIrVCyhx?= =?us-ascii?Q?GFb0Vhaw6YEMCbsflNtLohqhqkJDk2k2IwIS6qRiU4EDvmstJ+7OPE81Rfs5?= =?us-ascii?Q?tkybpalucw/akxSXDayFxcLrrKH2pVu3W6vBudtaFGlr3DqRdTo34u8KMOzA?= =?us-ascii?Q?gD4CRlMpLShgs3n8e8zPWi/K9AhiBkpw4hHib08KrHnn7GbwYyaR50CJ7HLM?= =?us-ascii?Q?b0eDFePT3jMI30VKqXug3XVl9lru9zOH9CtyNxtGEU4i496k+p/1Jg5ID8fu?= =?us-ascii?Q?mBFPty/ZhyabUI6yTiFde24dwSxcZU9dGYlMkVMVhdoIVykQ/CSC0Xvs9Y8a?= =?us-ascii?Q?I8B6ZSVRHt9ffSM0TUQ+pjjDJ0arGpmcINioty6WBrAjtZuwfYovoHxEwk1Y?= =?us-ascii?Q?9t7gBbO6RV4LkwHrgTd93eDlVTxOwgtQHi8rx9X4U7LeujToDcmkL/FPDZh7?= =?us-ascii?Q?y6Z5QGiioo9/cwPGchyEGNsNOYxWrChtlgQkmkkrDLg9ysKcH1zlkX09eTmk?= =?us-ascii?Q?TtibATcmWVykXmAw6OQkFt3Ua936gSHb6wEi8tHv5NozQoXrvyKl9OOzL5Lh?= =?us-ascii?Q?xY3ZFouiT+E7Qpjnfuod/qMwbe2CzkOT9MkkHLAEWNPySLJl9lCGYXL2xJx8?= =?us-ascii?Q?aFbmZxIHxEotBlPZd7pBy2sMCCcdn4yie12ZGdIMZhQ4kinub/H3u9qMrPNu?= =?us-ascii?Q?id2YGzbutmd9SQ/MQ9hebWXNnpwvZ/Hu1fRfm81T8qAV9j9VqhOrbzeMAJC0?= =?us-ascii?Q?mTbhmC5zHj7pzSkDjYW/Z90Hbtg6Rkm+401UXRZvbV00lEBnKxBV0FoCKhXg?= =?us-ascii?Q?xd2pm6HKaH09xipr4ZqBdP5eEl2qnW3DHRbzXhxMYiSp4J6aDOyCSrX4TwTQ?= =?us-ascii?Q?COj38nktdykCv0LKV5SYZGSIthwx2XyqAVcMr9eNsbiTSjcK4cPSRGgUZ0g0?= =?us-ascii?Q?fAZQ7E0Doq24tBmDWQb54smvRL3nm/+5HeYQkC39?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4587.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60025128-1d12-44fc-f4db-08dc49587f1f X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2024 03:39:21.8192 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dSMT/CKhTtVstc7jqFGoNFidsR+aKWtcF0TIVLHeU0OUKoyxIl7c2h5sMSr3MGBvT/7K/+9iCR6rmGNpyoxf1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5148 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Yan, Zhirun > Sent: Wednesday, March 20, 2024 4:43 PM > To: Wu, Jingjing ; dev@dpdk.org > Cc: jerinj@marvell.com; pbhagavatula@marvell.com; stable@dpdk.org > Subject: RE: [PATCH] graph: fix head move when graph walk in mcore dispat= ch >=20 >=20 >=20 > > -----Original Message----- > > From: Wu, Jingjing > > Sent: Wednesday, March 20, 2024 2:25 PM > > To: Yan, Zhirun ; dev@dpdk.org > > Cc: jerinj@marvell.com; pbhagavatula@marvell.com; stable@dpdk.org > > Subject: RE: [PATCH] graph: fix head move when graph walk in mcore > dispatch > > > > > > > > /* skip the src nodes which not bind with current worker */ > > > > if ((int32_t)head < 0 && node->dispatch.lcore_id !=3D graph- > > > > >dispatch.lcore_id) > > > > continue; > > > > - > > > > + head++; > > > If current src node not bind with current core, It will go into infin= ite loop. > > > This line would have no chance to run. > > > > Seems reasonable, it might be OK to change "head<0" to "head <1" the > condition > > check? >=20 > No. "head<0" means it is src node. > All src node would put before head =3D 0. "Head<1" is confused. > You could find the details of graph reel under rte_graph_walk_rtc() in > lib/graph/rte_graph_model_rtc.h >=20 > I guess if there are some src node missed, it may be caused by wrong conf= ig, > for example, the missed src node not pin to a lcore. > Use rte_graph_model_mcore_dispatch_node_lcore_affinity_set() to pin the > src node first. I don't think it is confusing because head++ happens before head < 0 check. Yes, it happens when lcore affinity is not set. For example, we have two source nodes, both of them have no lcore affinity = setting. By current code, the second node will also be executed which is not as expe= cted. Thanks Jingjing