From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1CE9A034D for ; Thu, 10 Feb 2022 08:04:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD35241157; Thu, 10 Feb 2022 08:04:58 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 8B00040041; Thu, 10 Feb 2022 08:04:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644476696; x=1676012696; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8ZWu0bmN/PsG5DHnxu38pR+wpIrC/iT1FHH4Hse7wBA=; b=EuGq/OREELfJSV6InC+k9qpN2gE7Z/aey5M0IyUrsK8HXpkcPsO+Z9W7 krwzfiNNjkiE882aQBvUo2Yd+eOoJHOspXdVsqoZvQQnlV0Pw097lyK4Q d2NW661gVd+GlYDca8/GsBWGZYw+nnpsa0X+Ny7SyAyruMpAb/AxO5vBD i7vIXcfkxzImK1LkE7sUDZO/cpq0H0FgMSOTpfOWDq+5y+HJFQBoJXqpp bL2er7jTgs7K1782ibUtz2oYILvMkTm6uzO7xVwQ9hM0zm2k7KfB2g7wR 4eAh6aOwhQDsMfZa7R4kmUYNOb8yCrnb73wzoXfMsIBM0MUYPiuz+x+Y5 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="310166166" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="310166166" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 23:04:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="485577902" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga006.jf.intel.com with ESMTP; 09 Feb 2022 23:04:55 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 9 Feb 2022 23:04:55 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 9 Feb 2022 23:04:54 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 9 Feb 2022 23:04:54 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 9 Feb 2022 23:04:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WlGjJ2Db064fpxdWMAR05wHdr7//4DRwEpirIyAjAD2HTPzEYW+7cIHbwn6jd9ALPeLW3MwFhOMSEVeCPCGlzbo8dkafPmtQyFTIijkKOb+qWQYfYLSW8P5yw4hNfHEDdxFXt9Dduc6KQ+TjXtxSlcZBDAsbFv8vXye+WKNE97CdB1oktkBGgot8VmSoOMjwGJpa9mXYXqrgpzjik4+tQipXd5QWbW02/T4IF42bYrxnrwYvZhErXSfB8mqBk8F0R4x6fjZ89Yqth8aIaffGw72qBU/zqHGEAvL+v0QaQTYSNpgJda7lKH+p1p850c3nP+m5NEGCs1YAgFtZp2O/Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aoHYBLLa4XNvNYX07ZZYBZeCtKNr5M9VXi5PooLHYEY=; b=ld2geyKZ/nRj+fkhYsvSzCz/7wIPMuXJYNXJNM+8xsVkXaUEdHwIxXP6/E7fkUJmYACVp5xulJ4e+Kn2sMpBx/1cVNiHxXG4fzexQTopKJ0jYZgdTQ4xTYjIatzaBlOj3qWd4DvJBaEkVreQJG5bA6K6tSeaMreFr9cLJoMQU0F/Bp4hQs+ad8X0k90jtcInVfkYeYajGOblyrwCqXOcyQlfH4FKR3qU/Tap/lMU41tiEASf5BpsTccCjiqK0JWMPeNer+ZgrM2CgPG1KZIZPy1aL/FR2julFf8mthr+sHUZ/Sa8PGJXGoJl8oxsTxDjyK1s3ScnwQKUVHUiVvP2lQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MW3PR11MB4587.namprd11.prod.outlook.com (2603:10b6:303:58::7) by BYAPR11MB3832.namprd11.prod.outlook.com (2603:10b6:a03:ff::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 10 Feb 2022 07:04:49 +0000 Received: from MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::cd04:de8e:fecc:6978]) by MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::cd04:de8e:fecc:6978%8]) with mapi id 15.20.4951.019; Thu, 10 Feb 2022 07:04:49 +0000 From: "Wu, Jingjing" To: "Guo, Junfeng" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] raw/ntb: add check for DB intr handler registering Thread-Topic: [PATCH] raw/ntb: add check for DB intr handler registering Thread-Index: AQHYHkeINxRO1EzZoUO0rpwjCSQjIayMWaRA Date: Thu, 10 Feb 2022 07:04:49 +0000 Message-ID: References: <20220210062841.646294-1-junfeng.guo@intel.com> In-Reply-To: <20220210062841.646294-1-junfeng.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7883df94-ac02-4830-c437-08d9ec63a0c1 x-ms-traffictypediagnostic: BYAPR11MB3832:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O0Q+aGRivlM+1wbpK5Vl713T36eq/o1EWwhmR0/e0spxKrcZP8TOmSO5dxxPIgfS9FRKN8XWIUHb6nTCCYBISJVLRXzxBolxY6yDzl47S4sCjgsU5flW/kJNyvzcouojsLoghKiSLgsFxOU06ZNcoUyq4JrRHOhvVfNI/xZVOHEHNZ/m1OEbctulGnv2Fyoymsroa5x5lEKj68ALO7/62F9kAEmZmx1WrRrUpIFepcAIuSVgSFyyw8/kPKriLWXk02kLqRF1xU2pFEL637+eOXq9THjDzrhtFggMV4xcvNEYnYkLwLWwcyody9WCRUMz9wlgK7M14V22IQSOPvND6vTL+kzmdauQq8DzfgEOfGfydZyYKqFnuyS6xVSCwFa0od1ag6R0RPw+A1wotgE0SI0DLwa/T+KInLESVg11ZyIgUyTjnet5ANCase0n3SCYerwB6Hsw6bqIDSC2cBdGINh4mu2uCObOdTrXcbR6fxs6CgPM2J42epjHxcfv97YYoIQqBiiBdvuy57JAadDwSunup1pJDB3XF6ws023Vqssn6O35QtbEqlONqFH4i0bpsQXk8idVzygfswylzHqsoxIf+etDqB5E0uBwIPcQ3D2ozb9hLPlcjp+cYXGE1XW/aaiE9WYJG+xD5S+B5fFtiXOTon3H28Cti7F0XC64QVrrKOBhnLs4dNayfYLiYn9mbbCXxWpUrno0UbI7IeZT/g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4587.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(26005)(2906002)(186003)(38100700002)(122000001)(5660300002)(316002)(55016003)(38070700005)(9686003)(6506007)(7696005)(450100002)(53546011)(4326008)(64756008)(52536014)(83380400001)(54906003)(6636002)(76116006)(66946007)(71200400001)(82960400001)(8936002)(66556008)(8676002)(6862004)(66476007)(66446008)(33656002)(508600001)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7U53tBQnwGApnhGmDQJ7owO5SiwXpYQ6tf7zaoA2X5t/9gmgnY0ZhEl/9i+t?= =?us-ascii?Q?KlCtcOpMAOO/h5sTLwwJZiTufB1GiS7smMMSMu3+h5eGpqbRyLDievc6y9HP?= =?us-ascii?Q?kksk1j3rBMtpCX0LJk9NBrImz2KpGUR7Ho6JazBhDACkGwLKT/ciab9lQjNa?= =?us-ascii?Q?Oazuc8dbNgRN/1sehvJOhuc+v0Oy1l19APnB0rmgESmx9XYnQcHj/7ifoBdz?= =?us-ascii?Q?XIruLbiljOhVCQ0wAMse8zeeAnUOzZxriZK6Httjf7/Qfh8TwfMTBZ/vP2Fq?= =?us-ascii?Q?3XLcHn1t3oyzW8nX3yxyUCbC9S1NCiR51aLE0aaZkC4Nk8khFomBeDW3iZji?= =?us-ascii?Q?G/WZkdxTVlmN2wHtBMhmF8jknMDtgvKxvpzww30I3G3T2RlU6QBH8um5Jdc2?= =?us-ascii?Q?vg/sjdPuFs9tO7MDLu5Xs9O5OtdHdQN9QPwRkS62VR3Sjgl4ume95jqVbt9i?= =?us-ascii?Q?zRpcRVW5K70owEs1kbVTOvMqKke2/LbDsCK0bt5zu++NxzhaNfvVtg/WQoVM?= =?us-ascii?Q?9NwTtvMxLf5PxzRG4rNqUPOrUUIEpBmXryFyb+cr6XV3Tu2NYPXn6bg0nxng?= =?us-ascii?Q?BsaxmAoWk0KEVIyWjJOCbIFegOh7gKdcxxE9Rv7UzOlaQgutqM9/rpHkOxl6?= =?us-ascii?Q?Ww2XpcGBtGtH27z7EB4xxSMvaNrrEkfUzPWbjgNWXQD0ybXeM+mMc/acywGE?= =?us-ascii?Q?2AEPZvssUGk2rANejUoGKZghXa0xZxE4S10p2OexCFxnUBIQIZmUWnDnRxE2?= =?us-ascii?Q?w0n1NsYkb5MIo39xJA92D3cd0P0fVy2WBvRY359a0hnf+LGdUhbKuMUgHfVH?= =?us-ascii?Q?cOcClZFatM77h9TU8UOeP0PugVp+8PLChQSAaxvAeHsO9v48qtrEXyRdgKfL?= =?us-ascii?Q?EYjIHBs67n8b6IaUdP4cr/jD1YTbb0XICM+wEh5q4jWy8ALjCbthwxsS/GIj?= =?us-ascii?Q?f4Yb4QFU08L8AFcN6JvW+YBtWJbYJ/2esPBUtx1kSGkEXRy7t4JW9plCu6IY?= =?us-ascii?Q?Fw7k+Y0aBk+43UESaeHl3bOGtXrEne0dhAco2lgNY3quLTCC1q9ajHSNl+n7?= =?us-ascii?Q?zHWQVcLEpAlUqroMHN6Ca5nullPla+KAtrjgfA9GEeQUivGAuYxoePKp6GJE?= =?us-ascii?Q?M9Svq9Uw6cMOqDepWc/o6pL5OCUkl1o1MIOmRLpF0emiYI4ZiqBrvYg8C9u+?= =?us-ascii?Q?u4/9+yiQcgefU1cJbqrllLrgSqjX2aq5AFBbNbhKEPoQzy5IKY8k3vpIIXDK?= =?us-ascii?Q?pAbxzLHh4OlNvILtusH6qaWU2WG2jfl5gI7nhXyRy4lyASQ7YsWwzYkfuThX?= =?us-ascii?Q?jLGizIoV23wEIxTPllpYXGePhl29I8Oqj+yAcVgNUGqK3TrhUb5ioQn3YWNN?= =?us-ascii?Q?Hz+fCW0LM5YlZfODfFNUmsoj+85iOfDXLx46fJidH/uCLiqmbXn8GiAxzs9D?= =?us-ascii?Q?hfmbzRrKD+3FBNutVs2cnYyrfVwn/CGEaSMuVfStBJxd/z/XxJqq99j1O9HZ?= =?us-ascii?Q?SBRIXoio4/iBZWDRI333gap0eACiwxCjNCOy+KTJTeno697954pFSv+hm7Tl?= =?us-ascii?Q?SBqfS40dsGyEWZaR4/hRcJaQigqK6tI2nh6uNX29kHPe7CA7ZS+je6r2E7q8?= =?us-ascii?Q?jg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4587.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7883df94-ac02-4830-c437-08d9ec63a0c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 07:04:49.1513 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: frnRLENImarB7z4O0zUZ4kcKH+uCaeDHCsUp5/pzPIb5qmCS+WA60Crcorp69Hot0o/HHLs8cTafOk41LtWlQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3832 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Guo, Junfeng > Sent: Thursday, February 10, 2022 2:29 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; stable@dpdk.org; Guo, Junfeng > Subject: [PATCH] raw/ntb: add check for DB intr handler registering >=20 > The callback registering of doorbell interrupt handler should be > finished before enabling the interrupt event fd. Thus add the return > value check for this callback registering. >=20 > Fixes: 62012a76811e ("raw/ntb: add handshake process") > Cc: stable@dpdk.org >=20 > Signed-off-by: Junfeng Guo > --- > drivers/raw/ntb/ntb.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c > index cc611dfbb9..0801e6d1ae 100644 > --- a/drivers/raw/ntb/ntb.c > +++ b/drivers/raw/ntb/ntb.c > @@ -1403,8 +1403,12 @@ ntb_init_hw(struct rte_rawdev *dev, struct rte_pci= _device > *pci_dev) >=20 > intr_handle =3D pci_dev->intr_handle; > /* Register callback func to eal lib */ > - rte_intr_callback_register(intr_handle, > - ntb_dev_intr_handler, dev); > + ret =3D rte_intr_callback_register(intr_handle, > + ntb_dev_intr_handler, dev); > + if (ret) { > + NTB_LOG(ERR, "Unable to register doorbell intr handler."); > + return ret; > + } When will this register failure happen? Have you checked what is the root c= ause? =20 >=20 > ret =3D rte_intr_efd_enable(intr_handle, hw->db_cnt); > if (ret) Need roll back, such as rte_intr_callback_unregister is required when fail = or driver remove? > -- > 2.25.1