From: Tal Shnaiderman <talshn@nvidia.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
Matan Azrad <matan@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>
Subject: RE: [PATCH v3 3/3] net/mlx5: fix Windows build with MinGW GCC 12
Date: Wed, 8 Mar 2023 10:27:09 +0000 [thread overview]
Message-ID: <MW4PR12MB5668CDF370E02E8D9DC1B44AA4B49@MW4PR12MB5668.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230302172846.GD29061@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
> Subject: Re: [PATCH v3 3/3] net/mlx5: fix Windows build with MinGW GCC 12
>
> External email: Use caution opening links or attachments
>
>
> On Thu, Mar 02, 2023 at 02:21:50PM +0100, Thomas Monjalon wrote:
> > With recent changes in Meson and MinGW toolchain, the driver mlx5 was
> > not able to compile on Linux for Windows.
> >
> > There were errors due to system detection, non-typed constants,
> > constant going over int range forbidden in pedantic mode, and
> > minimum-comparison of different types.
> >
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
>
> lgtm
>
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Acked-by: Tal Shnaiderman <talshn@nvidia.com>
prev parent reply other threads:[~2023-03-08 10:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230105161020.247780-1-thomas@monjalon.net>
2023-01-05 16:10 ` [PATCH 1/3] eal/windows: fix pedantic build Thomas Monjalon
2023-01-05 16:40 ` Tyler Retzlaff
2023-01-05 16:10 ` [PATCH 3/3] net/mlx5: fix Windows build with MinGW GCC 12 Thomas Monjalon
[not found] ` <20230112203719.1528619-1-thomas@monjalon.net>
2023-01-12 20:37 ` [PATCH v2 1/4] eal/windows: fix pedantic build Thomas Monjalon
2023-03-01 16:33 ` Thomas Monjalon
2023-01-12 20:37 ` [PATCH v2 4/4] net/mlx5: fix Windows build with MinGW GCC 12 Thomas Monjalon
[not found] ` <20230302132150.3330288-1-thomas@monjalon.net>
2023-03-02 13:21 ` [PATCH v3 3/3] " Thomas Monjalon
2023-03-02 17:28 ` Tyler Retzlaff
2023-03-08 10:27 ` Tal Shnaiderman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR12MB5668CDF370E02E8D9DC1B44AA4B49@MW4PR12MB5668.namprd12.prod.outlook.com \
--to=talshn@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).