From: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
To: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"Bronowski, PiotrX" <piotrx.bronowski@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"gakhil@marvell.com" <gakhil@marvell.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Power, Ciara" <ciara.power@intel.com>
Subject: RE: [PATCH v2] crypto/ipsec_mb: fix usage of untrusted value
Date: Wed, 9 Mar 2022 14:34:44 +0000 [thread overview]
Message-ID: <MW5PR11MB580930A08E5C393A85496F40B80A9@MW5PR11MB5809.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MW5PR11MB580976406109D7CFC635A9B2B8089@MW5PR11MB5809.namprd11.prod.outlook.com>
Hi Piotr,
> -----Original Message-----
> From: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Sent: Monday, March 7, 2022 4:27 PM
> To: Bronowski, PiotrX <piotrx.bronowski@intel.com>; dev@dpdk.org
> Cc: thomas@monjalon.net; gakhil@marvell.com; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Doherty, Declan <declan.doherty@intel.com>;
> stable@dpdk.org
> Subject: RE: [PATCH v2] crypto/ipsec_mb: fix usage of untrusted value
>
> > -----Original Message-----
> > From: Bronowski, PiotrX <piotrx.bronowski@intel.com>
> > Sent: Monday, March 7, 2022 3:33 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; thomas@monjalon.net;
> > gakhil@marvell.com; Yigit, Ferruh <ferruh.yigit@intel.com>; Doherty,
> Declan
> > <declan.doherty@intel.com>; Bronowski, PiotrX
> > <piotrx.bronowski@intel.com>; stable@dpdk.org
> > Subject: [PATCH v2] crypto/ipsec_mb: fix usage of untrusted value
> >
> > This patch removes coverity defect CID 375828:
> > Untrusted value as argument (TAINTED_SCALAR)
> >
> > Coverity issue: CID 375828
> > Fixes: 918fd2f1466b ("crypto/ipsec_mb: move aesni_mb PMD")
> >
> > Signed-off-by: Piotr Bronowski <piotrx.bronowski@intel.com>
> >
> > Cc: stable@dpdk.org
> >
> > ---
> > v2: use a different logic to check digest length
> > ---
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
Sorry I missed a point in your change and thanks for Ciara pointing this out.
You are changing the gen_digest_size to 64 which is wrong.
Please send v3.
Also instead of ack - Nack this patch.
next prev parent reply other threads:[~2022-03-09 14:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220307124802.1371808-1-piotrx.bronowski@intel.com>
2022-03-07 15:32 ` Piotr Bronowski
2022-03-07 16:26 ` Zhang, Roy Fan
2022-03-09 13:19 ` Ji, Kai
2022-03-09 14:34 ` Zhang, Roy Fan [this message]
2022-03-09 14:40 ` Power, Ciara
2022-03-09 15:08 ` [PATCH v3] crypto/ipsec_mb: fix coverity issue Piotr Bronowski
2022-03-09 18:02 ` [PATCH v4] " Piotr Bronowski
2022-03-10 9:17 ` Power, Ciara
2022-03-14 10:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW5PR11MB580930A08E5C393A85496F40B80A9@MW5PR11MB5809.namprd11.prod.outlook.com \
--to=roy.fan.zhang@intel.com \
--cc=ciara.power@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gakhil@marvell.com \
--cc=piotrx.bronowski@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).