patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Stokes, Ian" <ian.stokes@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH 1/4] net/i40e: fix AVX-512 pointer copy on 32-bit
Date: Mon, 30 Sep 2024 13:27:34 +0000	[thread overview]
Message-ID: <MW6PR11MB8309CBE7EDFBC6854A6FD51392762@MW6PR11MB8309.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240906141127.628873-2-bruce.richardson@intel.com>

> The size of a pointer on 32-bit is only 4 rather than 8 bytes, so
> copying 32 pointers only requires half the number of AVX-512 load store
> operations.
>
> Fixes: 5171b4ee6b6b ("net/i40e: optimize Tx by using AVX512")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  drivers/net/i40e/i40e_rxtx_vec_avx512.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/i40e/i40e_rxtx_vec_avx512.c
> b/drivers/net/i40e/i40e_rxtx_vec_avx512.c
> index 0238b03f8a..3b2750221b 100644
> --- a/drivers/net/i40e/i40e_rxtx_vec_avx512.c
> +++ b/drivers/net/i40e/i40e_rxtx_vec_avx512.c
> @@ -799,6 +799,7 @@ i40e_tx_free_bufs_avx512(struct i40e_tx_queue *txq)
>               uint32_t copied = 0;
>               /* n is multiple of 32 */
>               while (copied < n) {
> +#ifdef RTE_ARCH_64
>                       const __m512i a = _mm512_load_si512(&txep[copied]);
>                       const __m512i b = _mm512_load_si512(&txep[copied +
> 8]);
>                       const __m512i c = _mm512_load_si512(&txep[copied +
> 16]);
> @@ -808,6 +809,12 @@ i40e_tx_free_bufs_avx512(struct i40e_tx_queue *txq)
>                       _mm512_storeu_si512(&cache_objs[copied + 8], b);
>                       _mm512_storeu_si512(&cache_objs[copied + 16], c);
>                       _mm512_storeu_si512(&cache_objs[copied + 24], d);
> +#else
> +                     const __m512i a = _mm512_load_si512(&txep[copied]);
> +                     const __m512i b = _mm512_load_si512(&txep[copied +
> 16]);
> +                     _mm512_storeu_si512(&cache_objs[copied], a);
> +                     _mm512_storeu_si512(&cache_objs[copied + 16], b);
> +#endif
>                       copied += 32;
>               }
>               cache->len += n;
> --
> 2.43.0

Looks good to me, ACKED.

Thanks
Ian


  reply	other threads:[~2024-09-30 13:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240906141127.628873-1-bruce.richardson@intel.com>
2024-09-06 14:11 ` Bruce Richardson
2024-09-30 13:27   ` Stokes, Ian [this message]
2024-09-06 14:11 ` [PATCH 2/4] net/ice: " Bruce Richardson
2024-09-30 13:29   ` Stokes, Ian
2024-09-06 14:11 ` [PATCH 3/4] net/iavf: " Bruce Richardson
2024-09-06 14:11 ` [PATCH 4/4] common/idpf: " Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW6PR11MB8309CBE7EDFBC6854A6FD51392762@MW6PR11MB8309.namprd11.prod.outlook.com \
    --to=ian.stokes@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).