From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2955A0093 for ; Wed, 20 May 2020 07:13:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2925A1D17A; Wed, 20 May 2020 07:13:37 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id DFCDD1D169; Wed, 20 May 2020 07:13:32 +0200 (CEST) IronPort-SDR: GoGNizZOeXvX2AtsTdAyvxEAdmDpaQUQIHsSQUXp51bhyDJ89wNsEqaGESHgmZpA6IVLTLVmun 2HvxapO2tc/A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 22:13:31 -0700 IronPort-SDR: 1b0E0F6k2ov0v4Rlip0n6+iMe2XzQ7uBBphL8BdtVYLHea5S9GxT9QqMFOoS4vASVAdnpojuOC tZUHPU9q9A/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,412,1583222400"; d="scan'208";a="343378154" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga001.jf.intel.com with ESMTP; 19 May 2020 22:13:31 -0700 Received: from orsmsx124.amr.corp.intel.com (10.22.240.120) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 22:13:31 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX124.amr.corp.intel.com (10.22.240.120) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 22:13:31 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 22:13:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dRBv+DhWgH6Xw+W6mD7k85Ldof05wbiUM6TRgHmjw+Ouh5Nwg9WRyhMkOLERhvYotXVCtlowDvVsieqE5jmYIBzEjGR3Mud9owOmdNcQ8wEdrejiI4rUDjnpFn4cUUbs8No1f4k5uumQU28+4n7VCQau3LmFhuePNVV3es/pDwHy9mnELR/U7+HEWLOziN9dJPmJEOUvtic+XF1UePCekZl0F6H2ACmgl56BGiK2u4N+WsZMqBaVB1bNsDbcvPbrpK5cN2eJE1IHvNOG2iTJVTg+cLJmV3UlNtj1K8d1XMc64/keXu/DliWR7tZMSmUKuGDE3lzSbHAXuQryW1bUDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z2v3miOru9kmlyB+Uq0bysVEzKAqem1wM8zgY7HLF6Y=; b=VaCEkPCB/FkLNaNC2Vf0DMM+g07fn+qjnOUMrhPTlYjngXaQ2EOB1RfDcQ3fHIEfVuU44Gg8vo8yRu1bUVOvup2pNUCGA7IPFuOgB23OMferqSLCvldUV6imqNsNh+mvxzb38K3Q5nsKIobxwP9ZVw+PuEY3AHhOFKUZao2xTMXW6SLWkT2M5sqKH20P1YGElfcYVtXQeFdpdMNQGP3eJoZDt5ffDzRjTwu23I2ugLgguzNi2nqbBLP6IZzfYrwi5B3mQ7iO1hGSIGxN0YbgoIadBBlYKTJlzogT1b8t6T2LluiaFoRmhBrcpWnwveHID8PMYlDVNRJT8fjy1aTyUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z2v3miOru9kmlyB+Uq0bysVEzKAqem1wM8zgY7HLF6Y=; b=uUku/lBciS7jW56rzBbZRw1b6/4fAd+MZGsNvz0b3XHjRE0COUt2flOt2I99sMBgH3jbrQYXL8EK7YvzFjv+PDTIFio8OX3SmOERNkfYKy2vcRSJ5lqGfxENfL/E3ZCsdzfNgC/WEoR3CJ498VKxlTpY4A0cHy5l5VHK0Aq1fA4= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (2603:10b6:300:23::15) by MWHPR11MB1581.namprd11.prod.outlook.com (2603:10b6:301:d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23; Wed, 20 May 2020 05:13:29 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211%7]) with mapi id 15.20.3000.034; Wed, 20 May 2020 05:13:29 +0000 From: "Zhao1, Wei" To: "Xing, Beilei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Guo, Jia" Thread-Topic: [PATCH] net/i40e: fix flow FDIR enable issue Thread-Index: AQHWLbDS52Dfvw1zOUeWoPquTSBw/qiwXrYAgAAQMUA= Date: Wed, 20 May 2020 05:13:28 +0000 Message-ID: References: <20200519071652.26537-1-wei.zhao1@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWJjZGUzOTMtMjliNC00MmM2LWI3NDYtZWQ1NjhhZTlmNTk1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMWZhY2tQdXJtVER3RWZtQjZKZWN4OVlEVkl3blV0YTJ5Q2hkQmtwNnljbTRRRG1naXlqdFhhOVpuN3F4ampIKyJ9 dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 47f538df-f778-4aef-140e-08d7fc7c8877 x-ms-traffictypediagnostic: MWHPR11MB1581: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 04097B7F7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pmL19KgNNKejMvCeItWgvtH6cbX+4yhZWAAwqZ52M695yNa+wqKwmpq87s9mxU1rpNWdkXsgQ65CbNrAaLvGZoACVGYMF5QcObsFiidwpMfb6gm6vMgSj8UvjOskx0kS7IP2Zxa7kqeGjgnnN8NKCeKLjRGWaTvY/XCMw0CH+XA70yaF5aj3MMWo7NmawuKU2xe8XT9umegZdwPuEpqX5PBUKev/NAqAi7rDhfY+TlL+FSD8piCQ6YD8cKu2NZSfr5yjW9ip0ZzQwX+Kt/p83ONRGSLqFG5SYGHSpiffMFW3DWI8J+HCbuN+t0D8OOXTck16xOF0FzKN7PqUWTYYvg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(346002)(396003)(366004)(136003)(39860400002)(376002)(478600001)(4326008)(66446008)(64756008)(86362001)(8936002)(5660300002)(107886003)(8676002)(55016002)(71200400001)(9686003)(186003)(110136005)(52536014)(53546011)(33656002)(6506007)(450100002)(66946007)(316002)(2906002)(66476007)(76116006)(26005)(54906003)(66556008)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: F0e3n7waLAu3jVB12NSK0tuC+xNeNqetjvrwBYbMTokB5nlyAYrNFifYQ+IwNXrjGbgp36JTfbl82SVK9CBWpkI/qVV9VKLkUCPSYNOs5T15r4CFqA9aEIlmHk/GlJFDW0ukDzv0xbdnXy2W0+6iE4P1TfBFSfYZKxtQvEN78Wrv7JNJjZcIpPIJywZaf5nphBe9/tCMggSuT+GApRpyuygrjJk+ARZMalE/em85W6PCX+hFADqrats/P+jDjmHVxxq3YZFTlFP5+2hIhr7JeaJ18deI2XoDMEDenOY6r0NGoZ+cjFEfS2eqpgLLXQyhnE/GpCLBi+0O4o4dM5KBS2dceZ7oYbcauipIXBeZx2kPKaR5OilRYfFgRO7btDSdrXNTVDj8h6TiPPUQLs4KB8NPXS9RAFAkWCXPyg0MiZA2ZdrTnSLlSPlUFP3t7frrkBlLE8uBlu3Yg4fYU1/T/IpvITeJYYDZdzjWNawei48= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 47f538df-f778-4aef-140e-08d7fc7c8877 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2020 05:13:29.0174 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lipMh9DZqFTl/mIi/B+oDXX9+zbsliMF5M3Mureltq2WJBUJPWRuSVncrn1H7J84Ik4czo7+zzUFXWzKsBFzDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1581 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH] net/i40e: fix flow FDIR enable issue X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Xing, Beilei > Sent: Wednesday, May 20, 2020 12:14 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: stable@dpdk.org; Guo, Jia > Subject: RE: [PATCH] net/i40e: fix flow FDIR enable issue >=20 >=20 >=20 > > -----Original Message----- > > From: Zhao1, Wei > > Sent: Tuesday, May 19, 2020 3:17 PM > > To: dev@dpdk.org > > Cc: stable@dpdk.org; Xing, Beilei ; Guo, Jia > > ; Zhao1, Wei > > Subject: [PATCH] net/i40e: fix flow FDIR enable issue > > > > When we flush flow FDIR, all queues are disabled for FDIR. > > If FDIR rule is created again, then the flow list is empty, as it is > > the first time to create rule after flush fdir filter, so we need to > > enable FDRI for all queues. And also, disable FDIR for queues should > > be done in function i40e_flow_flush_fdir_filter(). > > > > Cc: stable@dpdk.org > > Fixes: 1491f63c7559 ("net/i40e: fix flush of flow director filter") > > Fixes: 6ae9b2b5e8c2 ("net/i40e: cache flow director enable value in Rx > > queue") > > > > Signed-off-by: Wei Zhao > > --- > > drivers/net/i40e/i40e_flow.c | 12 +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_flow.c > > b/drivers/net/i40e/i40e_flow.c index > > 25c77e7aa..94fc73092 100644 > > --- a/drivers/net/i40e/i40e_flow.c > > +++ b/drivers/net/i40e/i40e_flow.c > > @@ -3462,6 +3462,12 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev > > *dev, > > } > > } > > > > + /* If the flow list is empty, it is the first time to create > > + * rule after flush fdir filter, so enable fdir. > > + */ > > + if (TAILQ_EMPTY(&pf->fdir.fdir_list)) > > + i40e_fdir_rx_proc_enable(dev, 1); > > + >=20 > i40e_fdir_rx_proc_enable is called in i40e_fdir_configure, so could you c= heck if > we can optimize this and if statement (pf->fdir.fdir_vsi =3D=3D NULL) abo= ve? No, when "flow flush 0", the pf->fdir.fdir_vs is not NULL, but list pf->fdi= r.fdir_list is empty. >=20 > > return 0; > > err: > > i40e_fdir_teardown(pf); > > @@ -5330,9 +5336,6 @@ i40e_flow_flush(struct rte_eth_dev *dev, struct > > rte_flow_error *error) > > return -rte_errno; > > } > > > > - /* Disable FDIR processing as all FDIR rules are now flushed */ > > - i40e_fdir_rx_proc_enable(dev, 0); > > - > > return ret; > > } > > > > @@ -5368,6 +5371,9 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf) > > for (pctype =3D I40E_FILTER_PCTYPE_NONF_IPV4_UDP; > > pctype <=3D I40E_FILTER_PCTYPE_L2_PAYLOAD; pctype++) > > pf->fdir.inset_flag[pctype] =3D 0; > > + > > + /* Disable FDIR processing as all FDIR rules are now flushed */ > > + i40e_fdir_rx_proc_enable(dev, 0); > > } > > > > return ret; > > -- > > 2.19.1