From: "Zhao1, Wei" <wei.zhao1@intel.com> To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Cc: "stable@dpdk.org" <stable@dpdk.org>, "Lu, Nannan" <nannan.lu@intel.com> Subject: Re: [dpdk-stable] [PATCH v3 3/4] net/ice: support switch flow for specific L4 type Date: Mon, 29 Jun 2020 02:01:42 +0000 Message-ID: <MWHPR11MB13916C9F537CFB55D71BABCAB76E0@MWHPR11MB1391.namprd11.prod.outlook.com> (raw) In-Reply-To: <039ED4275CED7440929022BC67E7061154847C39@SHSMSX103.ccr.corp.intel.com> Hi, > -----Original Message----- > From: Zhang, Qi Z <qi.z.zhang@intel.com> > Sent: Monday, June 29, 2020 9:56 AM > To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org > Cc: stable@dpdk.org; Lu, Nannan <nannan.lu@intel.com> > Subject: RE: [PATCH v3 3/4] net/ice: support switch flow for specific L4 type > > > > > -----Original Message----- > > From: Zhao1, Wei <wei.zhao1@intel.com> > > Sent: Sunday, June 28, 2020 1:02 PM > > To: dev@dpdk.org > > Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Nannan > > <nannan.lu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com> > > Subject: [PATCH v3 3/4] net/ice: support switch flow for specific L4 > > type > > > > This patch add more specific tunnel type for ipv4/ipv6 packet, it > > enable tcp/udp layer of ipv4/ipv6 as L4 payload but without > > L4 dst/src port number as input set for the switch filter rule. > > > > Fixes: 47d460d63233 ("net/ice: rework switch filter") > > Cc: stable@dpdk.org > > > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com> > > --- > > drivers/net/ice/ice_switch_filter.c | 27 ++++++++++++++++++++------- > > 1 file changed, 20 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/net/ice/ice_switch_filter.c > > b/drivers/net/ice/ice_switch_filter.c > > index c607e8d17..c1ea74c73 100644 > > --- a/drivers/net/ice/ice_switch_filter.c > > +++ b/drivers/net/ice/ice_switch_filter.c > > @@ -29,6 +29,8 @@ > > #define ICE_PPP_IPV4_PROTO 0x0021 > > #define ICE_PPP_IPV6_PROTO 0x0057 > > #define ICE_IPV4_PROTO_NVGRE 0x002F > > +#define ICE_TUN_VXLAN_VALID 0x0001 > > +#define ICE_TUN_NVGRE_VALID 0x0002 > > Why not apply the same pattern with other valid flag? > I mean use vxlan_valid and nvgre_valid. > Could be tunnel_valid = vxlan_valid | nvgre_valid. Because we will extend to gtp-u or other kinds of packet, there will be more and more xxx_valid variable. I think we can follow rte layer to use bit define kinds of tunnel packet. It is too complex to define too many valid flag. > > > > > #define ICE_SW_INSET_ETHER ( \ > > ICE_INSET_DMAC | ICE_INSET_SMAC | ICE_INSET_ETHERTYPE) @@ > > -471,11 +473,11 @@ ice_switch_inset_get(const struct rte_flow_item > > pattern[], > > const struct rte_flow_item_l2tpv3oip *l2tp_spec, *l2tp_mask; > > const struct rte_flow_item_pfcp *pfcp_spec, *pfcp_mask; > > uint64_t input_set = ICE_INSET_NONE; > > + uint16_t tunnel_valid = 0; > > bool pppoe_elem_valid = 0; > > bool pppoe_patt_valid = 0; > > bool pppoe_prot_valid = 0; > > bool profile_rule = 0; > > - bool tunnel_valid = 0; > > bool ipv6_valiad = 0; > > bool ipv4_valiad = 0; > > bool udp_valiad = 0; > > @@ -924,7 +926,7 @@ ice_switch_inset_get(const struct rte_flow_item > > pattern[], > > return 0; > > } > > > > - tunnel_valid = 1; > > + tunnel_valid = ICE_TUN_VXLAN_VALID; > > if (vxlan_spec && vxlan_mask) { > > list[t].type = ICE_VXLAN; > > if (vxlan_mask->vni[0] || > > @@ -960,7 +962,7 @@ ice_switch_inset_get(const struct rte_flow_item > > pattern[], > > "Invalid NVGRE item"); > > return 0; > > } > > - tunnel_valid = 1; > > + tunnel_valid = ICE_TUN_NVGRE_VALID; > > if (nvgre_spec && nvgre_mask) { > > list[t].type = ICE_NVGRE; > > if (nvgre_mask->tni[0] || > > @@ -1325,6 +1327,21 @@ ice_switch_inset_get(const struct rte_flow_item > > pattern[], > > *tun_type = ICE_SW_TUN_PPPOE; > > } > > > > + if (*tun_type == ICE_NON_TUN) { > > + if (tunnel_valid == ICE_TUN_VXLAN_VALID) > > + *tun_type = ICE_SW_TUN_VXLAN; > > + else if (tunnel_valid == ICE_TUN_NVGRE_VALID) > > + *tun_type = ICE_SW_TUN_NVGRE; > > + else if (ipv4_valiad && tcp_valiad) > > + *tun_type = ICE_SW_IPV4_TCP; > > + else if (ipv4_valiad && udp_valiad) > > + *tun_type = ICE_SW_IPV4_UDP; > > + else if (ipv6_valiad && tcp_valiad) > > + *tun_type = ICE_SW_IPV6_TCP; > > + else if (ipv6_valiad && udp_valiad) > > + *tun_type = ICE_SW_IPV6_UDP; > > + } > > + > > *lkups_num = t; > > > > return input_set; > > @@ -1536,10 +1553,6 @@ ice_switch_parse_pattern_action(struct > > ice_adapter *ad, > > > > for (; item->type != RTE_FLOW_ITEM_TYPE_END; item++) { > > item_num++; > > - if (item->type == RTE_FLOW_ITEM_TYPE_VXLAN) > > - tun_type = ICE_SW_TUN_VXLAN; > > - if (item->type == RTE_FLOW_ITEM_TYPE_NVGRE) > > - tun_type = ICE_SW_TUN_NVGRE; > > if (item->type == RTE_FLOW_ITEM_TYPE_ETH) { > > const struct rte_flow_item_eth *eth_mask; > > if (item->mask) > > -- > > 2.19.1 >
next prev parent reply other threads:[~2020-06-29 2:01 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20200605074031.16231-1-wei.zhao1@intel.com> 2020-06-05 7:40 ` [dpdk-stable] [PATCH 2/4] net/ice: add redirect support for VSI list rule Wei Zhao 2020-06-05 7:40 ` [dpdk-stable] [PATCH 3/4] net/ice: add check for NVGRE protocol Wei Zhao 2020-06-05 7:40 ` [dpdk-stable] [PATCH 4/4] net/ice: support switch flow for specific L4 type Wei Zhao 2020-06-17 6:14 ` [dpdk-stable] [PATCH v2 0/4] enable more PPPoE packet type for switch Wei Zhao 2020-06-17 6:14 ` [dpdk-stable] [PATCH v2 1/4] net/ice: add support " Wei Zhao 2020-06-17 6:14 ` [dpdk-stable] [PATCH v2 2/4] net/ice: add redirect support for VSI list rule Wei Zhao 2020-06-22 15:25 ` Zhang, Qi Z 2020-06-17 6:14 ` [dpdk-stable] [PATCH v2 3/4] net/ice: add check for NVGRE protocol Wei Zhao 2020-06-22 15:49 ` Zhang, Qi Z 2020-06-23 1:11 ` Zhao1, Wei 2020-06-17 6:14 ` [dpdk-stable] [PATCH v2 4/4] net/ice: support switch flow for specific L4 type Wei Zhao 2020-06-22 15:36 ` Zhang, Qi Z 2020-06-23 1:12 ` Zhao1, Wei 2020-06-28 3:21 ` [dpdk-stable] [PATCH v3 0/4] enable more PPPoE packet type for switch Wei Zhao 2020-06-28 3:21 ` [dpdk-stable] [PATCH v3 1/4] net/ice: add support " Wei Zhao 2020-06-28 3:21 ` [dpdk-stable] [PATCH v3 2/4] net/ice: fix tunnel type for switch rule Wei Zhao 2020-06-28 3:21 ` [dpdk-stable] [PATCH v3 3/4] net/ice: support switch flow for specific L4 type Wei Zhao 2020-06-28 3:21 ` [dpdk-stable] [PATCH v3 4/4] net/ice: add input set byte number check Wei Zhao 2020-06-28 5:01 ` [dpdk-stable] [PATCH v3 0/4] enable more PPPoE packet type for switch Wei Zhao 2020-06-28 5:01 ` [dpdk-stable] [PATCH v3 1/4] net/ice: add support " Wei Zhao 2020-06-28 5:01 ` [dpdk-stable] [PATCH v3 2/4] net/ice: fix tunnel type for switch rule Wei Zhao 2020-06-28 5:01 ` [dpdk-stable] [PATCH v3 3/4] net/ice: support switch flow for specific L4 type Wei Zhao 2020-06-29 1:55 ` Zhang, Qi Z 2020-06-29 2:01 ` Zhao1, Wei [this message] 2020-06-28 5:01 ` [dpdk-stable] [PATCH v3 4/4] net/ice: add input set byte number check Wei Zhao 2020-06-28 5:28 ` [dpdk-stable] [PATCH v4 0/4] enable more PPPoE packet type for switch Wei Zhao 2020-06-28 5:28 ` [dpdk-stable] [PATCH v4 1/4] net/ice: add support " Wei Zhao 2020-06-28 5:28 ` [dpdk-stable] [PATCH v4 2/4] net/ice: fix tunnel type for switch rule Wei Zhao 2020-06-28 5:28 ` [dpdk-stable] [PATCH v4 3/4] net/ice: support switch flow for specific L4 type Wei Zhao 2020-06-28 5:28 ` [dpdk-stable] [PATCH v4 4/4] net/ice: add input set byte number check Wei Zhao 2020-06-29 5:10 ` [dpdk-stable] [PATCH v5 0/5] enable more PPPoE packet type for switch Wei Zhao 2020-06-29 5:10 ` [dpdk-stable] [PATCH v5 1/5] net/ice: add support " Wei Zhao 2020-06-29 5:10 ` [dpdk-stable] [PATCH v5 2/5] net/ice: fix tunnel type for switch rule Wei Zhao 2020-06-29 5:10 ` [dpdk-stable] [PATCH v5 3/5] net/ice: support switch flow for specific L4 type Wei Zhao 2020-06-29 5:10 ` [dpdk-stable] [PATCH v5 4/5] net/ice: add input set byte number check Wei Zhao 2020-06-29 5:10 ` [dpdk-stable] [PATCH v5 5/5] net/ice: fix typo Wei Zhao 2020-07-03 2:47 ` [dpdk-stable] [PATCH v5 0/5] enable more PPPoE packet type for switch Lu, Nannan 2020-07-03 6:19 ` [dpdk-stable] [PATCH v6 " Wei Zhao 2020-07-03 6:19 ` [dpdk-stable] [PATCH v6 1/5] net/ice: add support more PPPoE packeat " Wei Zhao 2020-07-03 6:19 ` [dpdk-stable] [PATCH v6 2/5] net/ice: fix tunnel type for switch rule Wei Zhao 2020-07-03 6:19 ` [dpdk-stable] [PATCH v6 3/5] net/ice: support switch flow for specific L4 type Wei Zhao 2020-07-03 6:19 ` [dpdk-stable] [PATCH v6 4/5] net/ice: add input set byte number check Wei Zhao 2020-07-03 6:19 ` [dpdk-stable] [PATCH v6 5/5] net/ice: fix typo Wei Zhao 2020-07-03 13:46 ` [dpdk-stable] [PATCH v6 0/5] enable more PPPoE packet type for switch Zhang, Qi Z
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=MWHPR11MB13916C9F537CFB55D71BABCAB76E0@MWHPR11MB1391.namprd11.prod.outlook.com \ --to=wei.zhao1@intel.com \ --cc=dev@dpdk.org \ --cc=nannan.lu@intel.com \ --cc=qi.z.zhang@intel.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git