patches for DPDK stable branches
 help / color / Atom feed
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Sun, GuinanX" <guinanx.sun@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	"Yang, Qiming" <qiming.yang@intel.com>,
	"Ye, Xiaolong" <xiaolong.ye@intel.com>
Subject: Re: [dpdk-stable] [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter
Date: Fri, 22 May 2020 09:46:37 +0000
Message-ID: <MWHPR11MB13917B712CFC69E062E2BF4AB7B40@MWHPR11MB1391.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200522061208.31694-1-guinanx.sun@intel.com>

Hi,

> -----Original Message-----
> From: Sun, GuinanX <guinanx.sun@intel.com>
> Sent: Friday, May 22, 2020 2:12 PM
> To: dev@dpdk.org
> Cc: Zhao1, Wei <wei.zhao1@intel.com>; Sun, GuinanX
> <guinanx.sun@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter
> 
> If some user set mac_ctrl_frame_fwd to 1 from fc ops, then he do a port reset
> process of
> 
> testpmd> start
> testpmd> set flow_ctrl mac_ctrl_frame_fwd on 0 stop port stop 0 port
> testpmd> start 0 start
> 
> Then after this process, the mac_ctrl_frame_fwd has been change to "off", so
> we should delete "adapter->mac_ctrl_frame_fwd = 0;" from dev-stop.
> 
> In addition, add a value to mac_ctrl_frame_fwd in the ixgbe_flow_ctrl_get ()
> function.
> 
> Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
> Cc: stable@dpdk.org
> 
> Signed-off-by: SunGuinan <guinanx.sun@intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index f8a84c565..dd4023f01 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2939,8 +2939,6 @@ ixgbe_dev_stop(struct rte_eth_dev *dev)
> 
>  	adapter->rss_reta_updated = 0;
> 
> -	adapter->mac_ctrl_frame_fwd = 0;
> -
>  	hw->adapter_stopped = true;
>  }
> 
> @@ -4754,6 +4752,8 @@ ixgbe_flow_ctrl_get(struct rte_eth_dev *dev, struct
> rte_eth_fc_conf *fc_conf)
>  	 * MFLCN register.
>  	 */
>  	mflcn_reg = IXGBE_READ_REG(hw, IXGBE_MFLCN);
> +	fc_conf->mac_ctrl_frame_fwd = mflcn_reg;
> +


Error, that is not right!!

>  	if (mflcn_reg & (IXGBE_MFLCN_RPFCE | IXGBE_MFLCN_RFCE))
>  		rx_pause = 1;
>  	else
> --
> 2.17.1


  parent reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22  6:12 Guinan Sun
2020-05-22  7:46 ` [dpdk-stable] [dpdk-dev] " Yang, Qiming
2020-05-22  9:42 ` [dpdk-stable] " Zhao1, Wei
2020-05-22  9:46 ` Zhao1, Wei [this message]
2020-05-23  2:35   ` Sun, GuinanX
     [not found] ` <20200523052239.62928-1-guinanx.sun@intel.com>
2020-05-23  5:22   ` [dpdk-stable] [PATCH v2 1/2] net/ixgbe: fix incorrect MAC control frame forward Guinan Sun
2020-05-23  5:22   ` [dpdk-stable] [PATCH v2 2/2] net/ixgbe: fix flow control status get Guinan Sun

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB13917B712CFC69E062E2BF4AB7B40@MWHPR11MB1391.namprd11.prod.outlook.com \
    --to=wei.zhao1@intel.com \
    --cc=dev@dpdk.org \
    --cc=guinanx.sun@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox