From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2979A41C2A for ; Tue, 7 Feb 2023 07:41:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CE5341148; Tue, 7 Feb 2023 07:41:32 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 1E0D340ED9; Tue, 7 Feb 2023 07:41:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675752090; x=1707288090; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=aUfTnhE0BCJDJ1x0LH133VLx5vwyKGVab7ZCJnTeC/o=; b=PBgZBfoZVo8PUzGojfbAOju1muyfdVwcHwkANj9kyTVOFK/PNQOB/Atm 86H5dRUBQKPVD9fDBKgotIGIbr+e2riTLXHGQrng4M6bqUF6C2QDPTAgT n/RHkH9NXrJw+OOn9ozUJJPApNBHWHvSnaX8OZiBq98WMr087OSIMb5IB R62xH4fM4LuAKdX1zf5dWYyKbj5hWBf+k5OVe7pkDfuz939GGZxntHLQo BeZvT8qK5BaUkq3qvG014RHfCO94JIM3ChfW2paohjLIm5rqe5aTFbbJf +k3/EZcG5g5iclqmNs3R0abxMcCSK3LrG/hLTe+XmcM/X4FiUis8yBeYN Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="394020992" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="394020992" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 22:41:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="809410737" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="809410737" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 06 Feb 2023 22:41:28 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 6 Feb 2023 22:41:28 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 6 Feb 2023 22:41:28 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 6 Feb 2023 22:41:28 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.43) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 6 Feb 2023 22:41:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gTgdkkVqfBMZv9D8r9QltpAD85zYSnR5lM78gTyDCpI/grIal0J5gcvLMprVfUZFekBeuDQCR5Lw7Elx2bpdHaPF6YB2rN3o2FATXc+pCq2nFKDaWCXFaOeQRX4yxTG+z3hBicRgrwivuqG8FhFEQNWg/6ThiSfbpDCxNmSzfhoWbAXU2k9pvWKWhCpdgphZ+dXKJexiwYI5RODDQueDh9ZImPxsvi9nuYqK4eKY/WdrhWIJqQ8ce0xZez3ETnSJK0dpzCYHqNXNSjKRseLhrX2sJmpPk11VtzFZvVn/P4ZBvC8tNBRvDoXsfizrfvOKlJAgBDHUjRKiywzXIMKTyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xIBoHLz05Uxsvc0V+wYkMlWSr2l3+vwD/AELnycEnlc=; b=eCwFbnV9C/uQBakVRS8g0BrS9Q2xJ2kXkWy7KSVWCleBnr5N9oDGxdXsJWPsRlYRzaHpA+bqessZRd2zyK6IxIQSGeISR4E2XB3i5IlFHh+M2wtih1PKQj3powPDOioIAP8ZnFFV+HWd2YPccN5pO2i24SiwdUQUMU29FVy+0xB3XAeLKconpD2orgEeW1r48TXHwqNglUmpg9i4MYHXFWYwyCZHxh/eaZYfxzZbe9XWyF8OH4Jb316J2yPJVp9BNH8AAfTa9vCOlje0FuluWy6+OZuV6zoFRPvWIA36aXqU750autQApnrpmbXwH26Zp4BffLUB7IJjsz7I4Ciepg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1886.namprd11.prod.outlook.com (2603:10b6:300:110::9) by CO1PR11MB4835.namprd11.prod.outlook.com (2603:10b6:303:9e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Tue, 7 Feb 2023 06:41:26 +0000 Received: from MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::6c25:9f9b:b5ec:24ad]) by MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::6c25:9f9b:b5ec:24ad%7]) with mapi id 15.20.6064.036; Tue, 7 Feb 2023 06:41:26 +0000 From: "Yang, Qiming" To: "Deng, KaiwenX" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhou, YidingX" , "Wu, Wenjun1" , "Zhao1, Wei" , "Xing, Beilei" , "Lu, Wenzhuo" , "Dai, Wei" Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API Thread-Topic: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API Thread-Index: AQHZMuxpTINWsuJrB027uwxOPYuvPa67M3yQgAAMkgCAB9hCsA== Date: Tue, 7 Feb 2023 06:41:26 +0000 Message-ID: References: <20230128071519.42946-1-kaiwenx.deng@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1886:EE_|CO1PR11MB4835:EE_ x-ms-office365-filtering-correlation-id: 600266d3-f934-4df6-40f4-08db08d6560a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1GR4Vih/2yNlqNHJEOgxN6bvALWWosm6V/ADTlI/Fkr+VHe+6l5WyRieUm1B9k0sGAS69KgsMdhBOyOQNev91NvD7Bv4hw62OXdOEkmVYJjayj5us0IXgGB85djvNLBJkkJNWJ6ws/tju6bNcevfyanUwhHumqmpROVNIuy15i1aT4hMVDtZUgY/NQqik1rSrywJV23gStEjXLYhx3AKi5vjMztSLZwe2D6ZdDH6RXRN5UpEEnG/jfk7FdZx28f/7J9xvNO5zGj3pCsYCkOHiVLKqXC+lxV008KJbR/tXFvALH81ZIsgYvpJu/vA/f5NNHQ4q3RDXovAGmVersjCSfIFXmf8DMMmgPhGbyMDNznE/iz9mxbx6ecBdbfr/JqSyQh0DqTpIrnz9MKTy2RfmA16cK190L5ii0oHcwE9ubwwGh2o0s4xCb98gM5Wj1gQ8p6GA3QI5Zhm589nhYbSRKVqAeVINAYiW8iawpPSvRoQxyIfasKz7wOsPo2I/Ef3pUYjCtXr/AibdG6QLiC/poXt0jUUdb6rHll/WNelJ3PSSFWbzlUluh0OQhBCS+lSpAy69v+7OCxWrb3WcQ/slcvHtwwK+jCjltBqzZxZ7dC6MhmY8OdThiviejrBZDXbjlr4JttuDt9/pYNx/zQ/UiRzTVK3HONCAIHf9dWvNhjJsdBIHGqDelTEMWpGgdDCfsphsppf5LHjBgolfQplnEiMbiI/Gpg1J/psEu9rfS0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1886.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(366004)(136003)(396003)(376002)(39860400002)(346002)(451199018)(66946007)(76116006)(66476007)(66556008)(54906003)(316002)(110136005)(66446008)(450100002)(86362001)(33656002)(2906002)(82960400001)(83380400001)(41300700001)(52536014)(53546011)(6506007)(478600001)(9686003)(55016003)(186003)(26005)(8676002)(107886003)(4326008)(64756008)(38100700002)(38070700005)(5660300002)(8936002)(7696005)(71200400001)(122000001)(41533002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UkYb6jikjsRoItktPrSo03Sy0ixVh9PZcBqoCDYstR1AYJWYV4ATu4GDLspT?= =?us-ascii?Q?O18XahJgDyjuypzdiL8k4ze2We9x4fcRRR38/u3iFyU5llYzMG0jBncOE9/u?= =?us-ascii?Q?glE9jeUJ5qorXtTUO9/4YQ0CjJ1tz48lTMpkUZjzxlIqWIcB7PlxFgqiB8G7?= =?us-ascii?Q?3L+5Hl6wMt0Wf9nEOfw8iU2P4aWtYZ4lEkBfp4v31ax4wfJR0rB9sV6X9CNN?= =?us-ascii?Q?uNlw72vzwZYMq49H9JlzW/5fmZ3L9xMn7zzubzmzjgrhJC0W7NiNfeovbvQc?= =?us-ascii?Q?Ns+YSTdA6p+T6rR+x613hKKk5uJ0Sfe9MNCMfLyk8UO1qIzUk044CI0WYSeT?= =?us-ascii?Q?Uu4W95483LwWQJ2/srAde879dKPtuG6VIg8kC1k9LY0l0ItVxw7QRkHdieKi?= =?us-ascii?Q?EJ4moro6NtPtFq38Yzc+r4Zq8rFGW4BHzIRkxo/ECjPguti6Ho0cVrZTd+ss?= =?us-ascii?Q?7hN0zPlbVasdGUcsMFbglYZPyYLVQUlTaeBVChuGa9awSIMBrbx30tMBuQw0?= =?us-ascii?Q?DZ0HaKDzC9yyzB9GypkI6UZiPyiJhwCK2hqpFM73HJwpvdF6Adzf8LsGNYBc?= =?us-ascii?Q?rTgdy7+H9lZdSkTqvfOhJqsJr519ThqafMQJGgZqgs1T38iNflDp4PMQlCGA?= =?us-ascii?Q?61aovHXEm73f8eUJ+gfGFN/K8wIWP5ZMOUG6xGar9AdQuTmXC3rSJA97GxiG?= =?us-ascii?Q?kuMyLsKLBo54oVynf9kVGWpAHZUunAyCCgIpZuFGc9T100Z5vOGsmr5FIIw+?= =?us-ascii?Q?SN1rX1oo7oU7oHPKRH0R+72VKMWRgEpx3M63KJD2EviDcnZ0MumnX+EVAxIC?= =?us-ascii?Q?i7RL0k6t+tZQgPRAavratbY4HXezUdMBGHumDJ2nogovqOuhgcyk5X7Vc7qZ?= =?us-ascii?Q?mMMk1xV3dmQxThy0JtFX1wwyLiFj4t9Gu0hg8rjbOhzaxiI0ToGZrUFaRe8m?= =?us-ascii?Q?foL8QzguMJAa2JlqpsoO8vBIinopUkz5AFEQAzrSzJZYAIKoe1oSXCmzVr6+?= =?us-ascii?Q?Dx/xAweWY0OSnZ1Dg8QO81woclqTobtoXV6V8YEckoKk0UK8JoPOl9QeBDyi?= =?us-ascii?Q?tus9qHIb4OHJ8oidUXDvgJRYWpb4yjd/XpMdvLPL3RbZKdZafNrHm3nP7mW8?= =?us-ascii?Q?ADnDn8OTop6HHT4duBGHIcffMgQRl/l8VNABD9f2HNvvsR/hzAuTjeNJDAL0?= =?us-ascii?Q?RMCKcHFYDn4WP0fM/bllvRnUbNzbXQXcwezPNtFlQTJFmHNCGmZTV4fI2vn/?= =?us-ascii?Q?itxQP3zTNoWl0od5NPZOf8n1kdSSHKcnsqmaqYmJx5pB/E6SpzzkDbbkn/yu?= =?us-ascii?Q?hOr4tfoN7U460bx13IR066vTy+mnb5IKMI5ms8Mh1u/jc07yW5JZ3e9UPAG0?= =?us-ascii?Q?82drITUmTi/RX0CphNFMG+D4M5k/ClpYC/MC5wARX1o8JEk7u+r784idK6Fu?= =?us-ascii?Q?ssHr4gH2pZN8RbUSuqKDQDTI9sfygDSLrqLfLv2kR6unlFVrRsxm1WUuK0tg?= =?us-ascii?Q?xnvpKK5sOS+joq7XnKn1itwC3ImB77GvwYoZliFQPcaUEgIhdJvrIKi0lv3U?= =?us-ascii?Q?yXMxvho9cSsnUFgPpuub85xkwxECf9BUp9sTp8e1?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1886.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 600266d3-f934-4df6-40f4-08db08d6560a X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2023 06:41:26.1968 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oYLwoEJBMcGkRh9reT6KhudJUzL9NUHFJ8/puNT4wTWJ3nqUnFRFKjLS95dZWVMLg1F3MDuNlM5Mr1UbuVNZSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4835 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, > -----Original Message----- > From: Deng, KaiwenX > Sent: Thursday, February 2, 2023 2:53 PM > To: Yang, Qiming ; dev@dpdk.org > Cc: stable@dpdk.org; Zhou, YidingX ; Wu, > Wenjun1 ; Zhao1, Wei ; > Xing, Beilei ; Lu, Wenzhuo ; > Dai, Wei > Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API >=20 >=20 >=20 > > -----Original Message----- > > From: Yang, Qiming > > Sent: Thursday, February 2, 2023 2:10 PM > > To: Deng, KaiwenX ; dev@dpdk.org > > Cc: stable@dpdk.org; Zhou, YidingX ; Wu, > > Wenjun1 ; Zhao1, Wei ; > > Xing, Beilei ; Lu, Wenzhuo > > ; Dai, Wei > > Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API > > > > Hi, Kaiwen > > > > The code looks good to me. > > Can you ask someone to test this behavior and add a tested-by? > > > > Qiming > > > Hi,Qiming >=20 > Peng Yuan just added tested-by. >=20 > Kaiwen > > > -----Original Message----- > > > From: Deng, KaiwenX > > > Sent: Saturday, January 28, 2023 3:15 PM > > > To: dev@dpdk.org > > > Cc: stable@dpdk.org; Zhou, YidingX ; Deng, > > > KaiwenX ; Yang, Qiming > > > ; Wu, Wenjun1 ; > > Zhao1, > > > Wei ; Xing, Beilei ; Lu, > > > Wenzhuo ; Dai, Wei > > > Subject: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API > > > > > > Add IPv6 addr mask and L4 mask support for rte_flow APIs. > > > > > > IPv6 flow rules do not take effect in ixgbe when set > > > IPv6 addr mask and L4 mask to default value as 0xFF. > > > > > > Set IPv6 addr mask and L4 mask as 0 to enable fields can fix this iss= ue. > > > > > > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Kaiwen Deng > > > --- > > > drivers/net/ixgbe/ixgbe_flow.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/drivers/net/ixgbe/ixgbe_flow.c > > > b/drivers/net/ixgbe/ixgbe_flow.c index 110ff34fcc..d2ba87df27 100644 > > > --- a/drivers/net/ixgbe/ixgbe_flow.c > > > +++ b/drivers/net/ixgbe/ixgbe_flow.c > > > @@ -1645,6 +1645,10 @@ ixgbe_parse_fdir_filter_normal(struct > > > rte_eth_dev *dev, > > > memset(&rule->mask, 0xFF, sizeof(struct ixgbe_hw_fdir_mask)); > > > rule->mask.vlan_tci_mask =3D 0; > > > rule->mask.flex_bytes_mask =3D 0; > > > + rule->mask.dst_port_mask =3D 0; > > > + rule->mask.src_port_mask =3D 0; > > > + rule->mask.src_ipv6_mask =3D 0; > > > + rule->mask.dst_ipv6_mask =3D 0; > > > > > > /** > > > * The first not void item should be > > > -- > > > 2.34.1 Acked-by: Qiming Yang