From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B648141BA8 for ; Thu, 2 Feb 2023 07:10:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CA52406A2; Thu, 2 Feb 2023 07:10:07 +0100 (CET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 576454067B; Thu, 2 Feb 2023 07:10:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675318206; x=1706854206; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=7GvsOxEII1VZChD9Teq6pcUhbii8LtD4UbRkt7FjtVY=; b=CA3SKywkiLoDbfkUF21cjU7yzXLSDVSIs//BFUBnbRkJaL29D4sKh3MF ZUqUPEum3M+5/Fq/bR81C/Gyf/XJlTLvKlQYMWjYH52xYJoA4M1y3AeNq tOK86RU8CkGVci/QrXrxER6KNw+ZPmR3Pq/mbKLvlkTlq1yGY5BUUIPgg MW5lxQjruI+P5jRSjoGc/Y1eMI88tElGNPZyvLc/cyQ9T8XUjP7yPkYkZ vziuVUMCFKaF2nIY4E2e4dD2tR4vJvNaBxsXpEhl6+yxniUYX2yrK1tGu 3D5TUwVUSB9bMICNjHVDFx+7HjG4OtgX3RBAzCk7fQiH2fdsZetvU7tvd A==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="390754888" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="390754888" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 22:09:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="642774857" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="642774857" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 01 Feb 2023 22:09:42 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Feb 2023 22:09:42 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Feb 2023 22:09:41 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 1 Feb 2023 22:09:41 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 1 Feb 2023 22:09:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U7ki4sPmwl4noHd2rmXdx/m5N/j83DsEmaSy3jd1/cnX01NIGh3Baa1sJAon1Ubm4yBkm3czbdeUDwna7ejB0PJnqqMoGRKX1rZpa4djYlnKwIlFVSAfGSu7K/RnTjGePbimzHkEE7q/7+djpli1H0C78tsZovev8JnX8Snvn/7hMQEHOcyHq9/jMb20X9dMNw2ypOEF8p2vkVSe23U3nThgvVqEHYPldpyaYsnO4R7eaPBadViggnjU4CAgOyjXlAw+QSyWelDRgV48feISRMYBwAJn6qnGhWuQspbo/1jzDaltLlC9J8dYm2XPQKRKerWcgJAeah8VdRyS1c+NAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q8/L5miRpw97KmYtPj2LW1pQXNob/gzK9ButpUDqN20=; b=M+gILFJkfqgYr6/nSBydyUZbkOYByZBsevWC5/mc14eWH7o81R/VNzuhjJU3VOfNjGTh9FIVuhVXTt/JZdnjA3+HpK7mkMV273UdwdSnJ2SpH40bx3UAV+6YDMWWAxuZGdpyPcMfFebYuHTMe7BbNZWmWM/ZJ4yjlfDSxVngQXaANb9OplfKnTZKNAumNFJYh/v3W+lpkqAt6IB6EjKZbHlZ0QoGQKgLyIZPJKbXHSkHj2KJIJL5CcMJZzvb68ZVNUpD17ugRcbd5cUsi1+KMzlDQDRN7w5/3c4OClMc/D7Wru7JRACm0rhlfdI/UJVLu/vJaBMAaLFngXagwyR2YA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1886.namprd11.prod.outlook.com (2603:10b6:300:110::9) by CH3PR11MB8139.namprd11.prod.outlook.com (2603:10b6:610:157::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Thu, 2 Feb 2023 06:09:37 +0000 Received: from MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::6c25:9f9b:b5ec:24ad]) by MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::6c25:9f9b:b5ec:24ad%7]) with mapi id 15.20.6064.027; Thu, 2 Feb 2023 06:09:37 +0000 From: "Yang, Qiming" To: "Deng, KaiwenX" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhou, YidingX" , "Wu, Wenjun1" , "Zhao1, Wei" , "Xing, Beilei" , "Lu, Wenzhuo" , "Dai, Wei" Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API Thread-Topic: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API Thread-Index: AQHZMuxpTINWsuJrB027uwxOPYuvPa67M3yQ Date: Thu, 2 Feb 2023 06:09:37 +0000 Message-ID: References: <20230128071519.42946-1-kaiwenx.deng@intel.com> In-Reply-To: <20230128071519.42946-1-kaiwenx.deng@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1886:EE_|CH3PR11MB8139:EE_ x-ms-office365-filtering-correlation-id: 49b89fc4-66b1-41e2-a320-08db04e4102b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SAs9p6czI6rqkTmjnko2PkY0jr6g8aElQ/U4j1pU+bHHOyg0mdahoeyGbedOqejFsmVTybTBVX28DJzXjeGkM+bPjBW6pYkTSQhiGGcVlRGDjBXn9QfZPO9ZktUXtfsJLc4Lj9D5bvVhmDnVYcxDnFKU4//6OkVpCAzoxU9O5zTUzhDaG4pqKmEHfc/b0W+E7NCzx2A2ttUFrDES9LFDdGhl6ZpE20f68U1+dbX6VKjT1DvSC3BwnyLKEWQWE4Ff4TqqixTy2eB9LQTkyg2KbJcSuBKnDv8pNV6mO8uCKbhnQTjXwWJ73e0z3TvWCplzZ3myMNbRR1ppzt87PDktYU8ErI7YcdzRFJ8+PyHw8XZtEs2q4K3eicItbp1YONqE6P+Qo66R1M3oeXZYVfr58WRYFLcB1V5Wp0FQxJ/djIdHTpYiv/+vtZlkPWkFCf1H+iCAFm30OxjqNHVCUn3OM4T59tPq0aiOrtQUEMv3Dga9LmRa+1p++vtYX94gblXU2kroCq65x5HrorqNTLrOC/xKK1crzM4/NauiY6pcYRNdLcvNDfekX32QQdgo7LNGx9h0pfOG9DdMYhC7l2mahQBmRuH97XFc5s5vC9Lld0bBu0+L/eefuaKv2rMw4UVd9+BuJOwCuTsIQNubiP63wfxzFDJGrb9i6u5KwSdD8NY0bUCQEw2D/YrjaMjw7Ve9Mz6Bdv/CL7wMg7AMPcIeuwXIur8iaNgu2DuGNYNXEtM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1886.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(366004)(136003)(376002)(346002)(396003)(39860400002)(451199018)(53546011)(55016003)(38070700005)(66556008)(478600001)(6506007)(26005)(107886003)(9686003)(186003)(7696005)(71200400001)(33656002)(83380400001)(66946007)(450100002)(76116006)(54906003)(110136005)(316002)(41300700001)(2906002)(52536014)(82960400001)(64756008)(8676002)(4326008)(66446008)(66476007)(8936002)(86362001)(5660300002)(122000001)(38100700002)(41533002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?++3k0cVOPnDKSJqUBzZcy0guW8mPnckkNRnj/QiT1UWRkYCBEP9bn+huFiCu?= =?us-ascii?Q?HycAYmqWtYeKg0ySTbT7Soslr6kC034TJJrdOY5QcUEG4EsBYvnz3+/gNiar?= =?us-ascii?Q?IcAdZxxrSp+pCIK05Zg7jZCNmHFiw0ePgvsvfoelt91afGcwpflP5HxwsTqH?= =?us-ascii?Q?NZTfwxKafS1ePmEf7pbDpNsZIkcJIqFLIPdlRAHOaw0f1OJhvBAYYyvwAF/k?= =?us-ascii?Q?Fg/EbNih/DswOHOXIOsVedv7+dpSJjwy+0PVjKLCQ57NKEiGB3hKasKAJSFk?= =?us-ascii?Q?eBMjAnfxiCVHN6R/EB0ZCHGoyNpcG/InX5uYFSqxDxirdlVQWC0klXZnPZUm?= =?us-ascii?Q?sdp2fwBCJoBUJFhh20LZt/WVfswCBlICOoR7B4CMXHMpbivpHUYs+2FI0tvM?= =?us-ascii?Q?RFw2AcR8RVPkXWkhkdN1YWmV3g52cyQ7DY2q9Mly3r0cVsmUpuieG51gsqp8?= =?us-ascii?Q?d8fF4dJ7uLIgO9VDr94Xl7WsVTbbMKZ72XCTRIdpbJqydWJXl3UImPH0Nb6D?= =?us-ascii?Q?AT5YvHjofw3XAdqGi9WJWSR58ux5OPQ2Ie0ykNO+o7aVGuCmDY3+zKlK7qMP?= =?us-ascii?Q?/t/nmbws3b9TbdYExCAsfrIvKuy1pq9YnyZExW9EvDldfUBMNLzcyvnY78am?= =?us-ascii?Q?S4Yla5XNPBP0ypjS6SDN1R3OwKbBkcQdp+QnjJU2Ao76Vlu88os2BtTkhNHz?= =?us-ascii?Q?ipZClfPOVABK2X/AfrW7B4uq9Uqur/EWR2wwdsmZDWrxs6WQh1ON2JLbBW1/?= =?us-ascii?Q?51htMEEGGMlwrZ0icQSZOMo11nxMlpkO1TNSGjW+1ZL30FiP+vlHTNrbjFSs?= =?us-ascii?Q?zvZz8BXf7mI0s1H3ejx/aFzWWcP1iG+MlllxVAfAW5aIWpt1ad0FzATyEkg9?= =?us-ascii?Q?FhM9NSJ2xmGlN0nuyKpzaZcGIty4mW3oF4aL1hQQD+/dJO4jzbryxaQwF8Ed?= =?us-ascii?Q?7fqO8CSYfIWDJPgxKRw+byTLVBNEdXds0Uf6rcfexcdJu1fvPIsbl8gBbxm6?= =?us-ascii?Q?QoURnUdzhD5Yqic3fuQqshGWa/fYTPCcRozz0UP2kxShvItUAR93DmoNBcFC?= =?us-ascii?Q?tFDJ1uk49R4sCF9QIga6MXHc+LP+TT3nCu+XILPyEgR1f2UsU2+FbZDgpSEM?= =?us-ascii?Q?lahcVm1Ou9zia9lHic2g3zMyTh5X+BoNEKCPi4/8fk56mG5wdCn/CDfaHwm/?= =?us-ascii?Q?vlfJhfznKqNn34M5rjvJfvaKouv8sHoufpF7DoiZQv0Ohd1U0t90IZvIRFV1?= =?us-ascii?Q?Iihlb7nFk+05j5kxm3wKjmvEFIW/qc01307lkMtgp4VOn9PoI7g0qXXls3uB?= =?us-ascii?Q?P+yTLWaWrsa/WF0XcOsBUrNNO+yVYWKA7hOdPNiaGwaD8UaUDGL5lPskr29y?= =?us-ascii?Q?THU9mu7mmWFaWXS+oUjEKyfhwZpv3KVjlnJh1BV9T+gjsc5SVUrsk7yjWR8E?= =?us-ascii?Q?mbdtrFh4rco6q64kZ9o3N9Nv52TSHjYrIT1obvGLo4ocYlqn6SOADlteC4T7?= =?us-ascii?Q?0AFT9N4FYd9nPuBM4FdAqtYjdo+NjGqzlneUU0tBZvcXUUPRE5QnJNtbXoU2?= =?us-ascii?Q?nSv9xXBww1903oyIy5HQB7yhhvyOLmFnMctDeQMO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1886.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49b89fc4-66b1-41e2-a320-08db04e4102b X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2023 06:09:37.3047 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CjNpVI5gGTIcooveTnIixoq1u0NNjm26uUYRFLSk8Bbi6UeSNfGPoXalOjNvMjHTBelgwg+k4ckw4QfzUhSNDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8139 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, Kaiwen The code looks good to me. Can you ask someone to test this behavior and add a tested-by? Qiming > -----Original Message----- > From: Deng, KaiwenX > Sent: Saturday, January 28, 2023 3:15 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Zhou, YidingX ; Deng, > KaiwenX ; Yang, Qiming > ; Wu, Wenjun1 ; Zhao1, > Wei ; Xing, Beilei ; Lu, > Wenzhuo ; Dai, Wei > Subject: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API >=20 > Add IPv6 addr mask and L4 mask support for rte_flow APIs. >=20 > IPv6 flow rules do not take effect in ixgbe when set > IPv6 addr mask and L4 mask to default value as 0xFF. >=20 > Set IPv6 addr mask and L4 mask as 0 to enable fields can fix this issue. >=20 > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") > Cc: stable@dpdk.org >=20 > Signed-off-by: Kaiwen Deng > --- > drivers/net/ixgbe/ixgbe_flow.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flo= w.c > index 110ff34fcc..d2ba87df27 100644 > --- a/drivers/net/ixgbe/ixgbe_flow.c > +++ b/drivers/net/ixgbe/ixgbe_flow.c > @@ -1645,6 +1645,10 @@ ixgbe_parse_fdir_filter_normal(struct > rte_eth_dev *dev, > memset(&rule->mask, 0xFF, sizeof(struct ixgbe_hw_fdir_mask)); > rule->mask.vlan_tci_mask =3D 0; > rule->mask.flex_bytes_mask =3D 0; > + rule->mask.dst_port_mask =3D 0; > + rule->mask.src_port_mask =3D 0; > + rule->mask.src_ipv6_mask =3D 0; > + rule->mask.dst_ipv6_mask =3D 0; >=20 > /** > * The first not void item should be > -- > 2.34.1